From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jagan Teki Date: Wed, 14 Nov 2018 15:20:23 +0530 Subject: [U-Boot] [ANN] U-Boot v2018.11 delayed a day In-Reply-To: <20181114092303.EE8D3240044@gemini.denx.de> References: <20181112214016.GS11247@bill-the-cat> <8668e5b6-00a7-0ebb-8910-b9dd8dabf81b@gmail.com> <20181112222515.GU11247@bill-the-cat> <64cad1b6-99d6-f692-4b9f-aced8fd86fb5@gmail.com> <20181113011247.GV11247@bill-the-cat> <1f09ec2c-d2e6-0e83-541b-5e43fc736f41@gmail.com> <20181113113326.1a328b0b@xps13> <08bc9e78-1b67-1100-db62-dac7d6a89802@gmail.com> <20181113115459.5dce801c@bbrezillon> <62e23948-12c2-b5dd-7136-8f6c915b2f6f@gmail.com> <20181113155701.8C211240044@gemini.denx.de> <20181114092303.EE8D3240044@gemini.denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Nov 14, 2018 at 2:53 PM Wolfgang Denk wrote: > > Dear Jagan, > > In message you wrote: > > > > These changes were fully tested, not an immediate changes. What I mean > > a immediate fix here is not for the series, for the comment mentioned > > by Marek about patch 1/5. > > Come on. You mean this code: > > >> else if (env_get_f("mtdparts", tmp_parts, sizeof(tmp_parts) != -1)) > > was "fully tested"? It may have been compile clean, but it > certainly was functionally broken, so it was NOT sufficiently > tested. Just running travis is simply not enough to claim the stuff > was tested. One thing I can say here is, I didn't test 1/5 or either the series since I don't have relevant hardware to produce the issue. I commented "about testing" based on author testing, Tested-by credit and how much this is needed for the release since I would trying to send the PR. Sorry if you understand differently, but I'm still on the same page what I mentioned in previous mail.