From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jagan Teki Date: Fri, 13 Sep 2019 07:58:04 +0530 Subject: [U-Boot] [PATCH v6 1/4] dm: spi: Convert Freescale ESPI driver to driver model In-Reply-To: References: <20190826092516.13245-1-xiaowei.bao@nxp.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de On Mon, Sep 9, 2019 at 1:13 PM Prabhakar Kushwaha wrote: > > > > -----Original Message----- > > From: Jagan Teki > > Sent: Monday, September 9, 2019 11:37 AM > > To: Xiaowei Bao > > Cc: Prabhakar Kushwaha ; wd at denx.de; > > Shengzhou Liu ; Ruchika Gupta > > ; sjg at chromium.org; Chuanhua Han > > ; Jagdish Gediya ; > > bmeng.cn at gmail.com; u-boot at lists.denx.de; York Sun ; > > Jiafei Pan > > Subject: Re: [PATCH v6 1/4] dm: spi: Convert Freescale ESPI driver to driver > > model > > > > On Mon, Sep 9, 2019 at 9:27 AM Xiaowei Bao wrote: > > > > > > > > > > > > > -----Original Message----- > > > > From: Prabhakar Kushwaha > > > > Sent: 2019年8月26日 23:12 > > > > To: Xiaowei Bao ; wd at denx.de; Shengzhou Liu > > > > ; Ruchika Gupta ; > > > > jagan at amarulasolutions.com; sjg at chromium.org; Chuanhua Han > > > > ; Jagdish Gediya ; > > > > bmeng.cn at gmail.com; u-boot at lists.denx.de > > > > Cc: York Sun ; Xiaowei Bao > > > > Subject: RE: [PATCH v6 1/4] dm: spi: Convert Freescale ESPI driver > > > > to driver model > > > > > > > > Dear Jagan, > > > > > > > > > -----Original Message----- > > > > > From: Xiaowei Bao > > > > > Sent: Monday, August 26, 2019 2:55 PM > > > > > To: wd at denx.de; Shengzhou Liu ; Ruchika > > > > > Gupta ; jagan at amarulasolutions.com; > > > > sjg at chromium.org; > > > > > Prabhakar Kushwaha ; Chuanhua Han > > > > > ; Jagdish Gediya ; > > > > > bmeng.cn at gmail.com; u-boot at lists.denx.de > > > > > Cc: York Sun ; Xiaowei Bao > > > > > Subject: [PATCH v6 1/4] dm: spi: Convert Freescale ESPI driver to > > > > > driver model > > > > > > > > > > From: Chuanhua Han > > > > > > > > > > Modify the Freescale ESPI driver to support the driver model. > > > > > Also resolved the following problems: > > > > > > > > > > ===================== WARNING ====================== This > > > > board does > > > > > not use CONFIG_DM_SPI. Please update the board before v2019.04 for > > > > > no dm conversion and v2019.07 for partially dm converted drivers. > > > > > Failure to update can lead to driver/board removal See doc/driver- > > > > > model/MIGRATION.txt for more info. > > > > > ==================================================== > > > > > ===================== WARNING ====================== This > > > > board does > > > > > not use CONFIG_DM_SPI_FLASH. Please update the board to use > > > > > CONFIG_SPI_FLASH before the v2019.07 release. > > > > > Failure to update by the deadline may result in board removal. > > > > > See doc/driver-model/MIGRATION.txt for more info. > > > > > ==================================================== > > > > > > > > > > Signed-off-by: Chuanhua Han > > > > > Signed-off-by: Xiaowei Bao > > > > > --- > > > > > depends on: > > > > > https://patc > > > > > hwo > > > > > > > > > > > rk.ozlabs.org%2Fcover%2F1146494%2F&data=02%7C01%7Cprabhakar.k > > > > us > > > > > > > > > hwaha%40nxp.com%7Ccc2424972d4e4d6835f908d72a08b877%7C686ea1d3 > > > > bc2 > > > > > > > > > b4c6fa92cd99c5c301635%7C0%7C0%7C637024089250212151&sdata= > > > > 3Ki9 > > > > > mrnn9YXWMR0vjoDmeE2eKBIn1RKlgnRC81SZQbU%3D&reserved=0 > > > > > Changes in v6: > > > > > - Change #ifndef CONFIG_DM_SPI to #if !CONFIG_IS_ENABLED(DM_SPI). > > > > > Changes in v5: > > > > > - Modify the function spi_cs_activate to fsl_spi_cs_activate. > > > > > - Move cs to the parameter of the fsl_spi_cs_activate function. > > > > > Changes in v4: > > > > > - Update copyright information. > > > > > - Move the fsl_espi_platdata data structure to the > > > > > include/dm/platform_data/. > > > > > - Merge the contents of the fsl_espi_priv structure into the > > > > > fsl_spi_slave structure. > > > > > - Implement the fsl_espi_set_speed function. > > > > > - Implement the fsl_espi_set_mode function. > > > > > - Implement the espi_release_bus function. > > > > > - Remove unwanted fsl_espi_bind functions. > > > > > - Implement the fsl_espi_child_pre_probe function as needed. > > > > > - Use #if CONFIG_IS_ENABLED(OF_CONTROL) && > > > > > !CONFIG_IS_ENABLED(OF_PLATDATA). > > > > > Changes in v3: > > > > > - Add a cover-letter for this patch set. > > > > > Changes in v2: > > > > > - The fsl_espi driver support both OF_CONTROL and PLATDATA. > > > > > > > > > > drivers/spi/fsl_espi.c | 445 > > > > ++++++++++++++++++++++++++---------- > > > > > drivers/spi/fsl_espi.c | 445 > > > > ++++++++++++++++++++++++++---------- > > > > > include/dm/platform_data/fsl_espi.h | 16 ++ > > > > > 2 files changed, 337 insertions(+), 124 deletions(-) create mode > > > > > 100644 > > > > > > > > Please review this patch-set and provide your comments. > > > > > > > > Once reviewed, I will send pull request via mpc85xx tree > > > > > > Hi Prabhakar and Jagan, > > > > > > What is the progress, if there are any comments, please let me know, > > > if no comments, please help to merge it, thanks a lot. > > > > I marked my r-b tag, and Prabhakar would take this via his tree (as he > > mentioned) > > Thanks Jagan.. > > We will pull it via our tree Hope it for next release, true?