From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752102AbeENSDn (ORCPT ); Mon, 14 May 2018 14:03:43 -0400 Received: from mail-it0-f65.google.com ([209.85.214.65]:39496 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752078AbeENSDl (ORCPT ); Mon, 14 May 2018 14:03:41 -0400 X-Google-Smtp-Source: AB8JxZrhprNhXCnfQ6ey+1g97/QsmmBqPNoHSw0+1lO0z4w6beJmq8k92nqWqWWTQOKcJy1em7ZCxKTu7wNs8fCxlrE= MIME-Version: 1.0 In-Reply-To: <20180419093225.614-5-wens@csie.org> References: <20180419093225.614-1-wens@csie.org> <20180419093225.614-5-wens@csie.org> From: Jagan Teki Date: Mon, 14 May 2018 23:33:40 +0530 Message-ID: Subject: Re: [PATCH 4/6] drm/panel: simple: Add support for Banana Pi 7" S070WV20-CT16 panel To: Chen-Yu Tsai Cc: Maxime Ripard , David Airlie , Thierry Reding , Rob Herring , Mark Rutland , dri-devel , linux-arm-kernel , linux-kernel , devicetree , Jonathan Liu Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 19, 2018 at 3:02 PM, Chen-Yu Tsai wrote: > This panel is marketed as Banana Pi 7" LCD display. On the back is > a sticker denoting the model name S070WV20-CT16. > > This is a 7" 800x480 panel connected through a 24-bit RGB interface. > However the panel only does 262k colors. > > Signed-off-by: Chen-Yu Tsai > --- > .../display/panel/bananapi,s070wv20-ct16.txt | 7 ++++++ > drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++ > 2 files changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt > > diff --git a/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt b/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt > new file mode 100644 > index 000000000000..2ec35ce36e9a > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt > @@ -0,0 +1,7 @@ > +Banana Pi 7" (S070WV20-CT16) TFT LCD Panel > + > +Required properties: > +- compatible: should be "bananapi,s070wv20-ct16" > + > +This binding is compatible with the simple-panel binding, which is specified > +in simple-panel.txt in this directory. > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index cbf1ab404ee7..9bc037f74d6c 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -745,6 +745,28 @@ static const struct panel_desc avic_tm070ddh03 = { > }, > }; > > +static const struct drm_display_mode bananapi_s070wv20_ct16_mode = { > + .clock = 30000, > + .hdisplay = 800, > + .hsync_start = 800 + 40, > + .hsync_end = 800 + 40 + 48, > + .htotal = 800 + 40 + 48 + 40, > + .vdisplay = 480, > + .vsync_start = 480 + 13, > + .vsync_end = 480 + 13 + 3, > + .vtotal = 480 + 13 + 3 + 29, > +}; > + > +static const struct panel_desc bananapi_s070wv20_ct16 = { > + .modes = &bananapi_s070wv20_ct16_mode, > + .num_modes = 1, > + .bpc = 6, > + .size = { > + .width = 154, > + .height = 86, > + }, > +}; I think this parallel RGB interface right? I too have same display with DSI I'm sure these setting will not useful right? do we need to write separate panel driver for that? From mboxrd@z Thu Jan 1 00:00:00 1970 From: jagan@amarulasolutions.com (Jagan Teki) Date: Mon, 14 May 2018 23:33:40 +0530 Subject: [PATCH 4/6] drm/panel: simple: Add support for Banana Pi 7" S070WV20-CT16 panel In-Reply-To: <20180419093225.614-5-wens@csie.org> References: <20180419093225.614-1-wens@csie.org> <20180419093225.614-5-wens@csie.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Apr 19, 2018 at 3:02 PM, Chen-Yu Tsai wrote: > This panel is marketed as Banana Pi 7" LCD display. On the back is > a sticker denoting the model name S070WV20-CT16. > > This is a 7" 800x480 panel connected through a 24-bit RGB interface. > However the panel only does 262k colors. > > Signed-off-by: Chen-Yu Tsai > --- > .../display/panel/bananapi,s070wv20-ct16.txt | 7 ++++++ > drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++ > 2 files changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt > > diff --git a/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt b/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt > new file mode 100644 > index 000000000000..2ec35ce36e9a > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt > @@ -0,0 +1,7 @@ > +Banana Pi 7" (S070WV20-CT16) TFT LCD Panel > + > +Required properties: > +- compatible: should be "bananapi,s070wv20-ct16" > + > +This binding is compatible with the simple-panel binding, which is specified > +in simple-panel.txt in this directory. > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index cbf1ab404ee7..9bc037f74d6c 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -745,6 +745,28 @@ static const struct panel_desc avic_tm070ddh03 = { > }, > }; > > +static const struct drm_display_mode bananapi_s070wv20_ct16_mode = { > + .clock = 30000, > + .hdisplay = 800, > + .hsync_start = 800 + 40, > + .hsync_end = 800 + 40 + 48, > + .htotal = 800 + 40 + 48 + 40, > + .vdisplay = 480, > + .vsync_start = 480 + 13, > + .vsync_end = 480 + 13 + 3, > + .vtotal = 480 + 13 + 3 + 29, > +}; > + > +static const struct panel_desc bananapi_s070wv20_ct16 = { > + .modes = &bananapi_s070wv20_ct16_mode, > + .num_modes = 1, > + .bpc = 6, > + .size = { > + .width = 154, > + .height = 86, > + }, > +}; I think this parallel RGB interface right? I too have same display with DSI I'm sure these setting will not useful right? do we need to write separate panel driver for that?