From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jagan Teki Date: Mon, 8 Apr 2019 18:51:48 +0530 Subject: [U-Boot] arm: sunxi: Bananapi_M2_Ultra not working with DM_MMC In-Reply-To: <20190408131044.GG4664@bill-the-cat> References: <20190408131044.GG4664@bill-the-cat> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: u-boot@lists.denx.de + Andre On Mon, Apr 8, 2019 at 6:40 PM Tom Rini wrote: > > On Mon, Apr 08, 2019 at 06:23:29PM +0530, Jagan Teki wrote: > > Hi Paul, > > > > On Mon, Apr 8, 2019 at 6:00 PM Paul Kocialkowski > > wrote: > > > > > > Hi, > > > > > > On Thu, 2019-04-04 at 05:51 -0300, Pablo Sebasti=C3=A1n Greco wrote: > > > > A few days ago I tried to boot my Bananapi_M2_Ultra with 2019.04rc,= I > > > > found that it wasn't booting, 2019.01 was working ok. > > > > Bisecting indicated that the problem was after > > > > http://git.denx.de/?p=3Du-boot.git;a=3Dcommitdiff;h=3Da7cca5793774e= e139b75a704d6efaa4d29f09f93 > > > > > > I think the patch should be reverted ASAP since it obviously breaks > > > some supported configs. Sadly, the offending commit doesn't say > > > anything about the test coverage for the change and what the status is > > > after it. There is probably a reason why it was enabled for sun4i only > > > before and there must have been a motivation for doing this on all > > > sunxi platforms, but then again, the commit message says nothing about > > > those underlying reasons. > > > > > > I believe we should be more strict on patch review and not let any > > > change bringing such a major change get applied with a commit message > > > that provides no context about why the change is okay and how it was > > > tested. > > > > Appropriate your concern. > > > > If you please list what all boards are not working with this effect, > > please write back. we will defiantly look into it. All these changes > > were merged in MW which is 2.5 months back, commenting in final stage > > like this is not the professional way. > > OK, but what platforms was this all tested on? Thanks! We have tested DM_MMC all the Allwinner SoC platforms and I couldn't find any mmc issues so-far on my boards atleast. Jagan.