From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 918D3C433F5 for ; Fri, 8 Oct 2021 12:40:56 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B259360F93 for ; Fri, 8 Oct 2021 12:40:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B259360F93 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8F48B835A4; Fri, 8 Oct 2021 14:40:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="pwWrwGk5"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 59FD5835BC; Fri, 8 Oct 2021 14:40:51 +0200 (CEST) Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DF0698356E for ; Fri, 8 Oct 2021 14:40:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jagan@amarulasolutions.com Received: by mail-ed1-x536.google.com with SMTP id g10so35029881edj.1 for ; Fri, 08 Oct 2021 05:40:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=n9qrLSJuiS84fWw4QJxHCn2j3zU5ydDisoLfEbkvPaA=; b=pwWrwGk5uW0lLfNvkpgova8nqjEkcr/22OCpTGUcNHZzSpMjDVKP0rcIVMfUJXm2bL 5M9aV0YdK/0w4TjYmr/ZusjOVWNT/h+CRiG4352dIgvhNLQ/U70p2+1AYK1xvHRRLswW u3ZLotSUcRXELU3q6B4+sapqrKu4517rM9Ab4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=n9qrLSJuiS84fWw4QJxHCn2j3zU5ydDisoLfEbkvPaA=; b=XYiRX1izWNTMXgHNFySKcG/+DeRW/R7jUJxEVzvK08bbLVCBExOARYd2zorlsQBN56 BvWvTXWI9tOiPDFUWCkASruGW6u8MnGW4Z+asl4xh2Bod1nQ5L0Nge5wrwKwcWO/yvB5 EzATbhlJUSJI5CASc2BxOrZZqbBf+2PVQMwwRmY6N8BQPciig2IhGYofEkaNBkZPMEKT Fq4C/icPasleEjNUaDbf7VM2zS8AYOquh//5d/2R/CUKS7KgzeySL+My4XMzgZ1h/jhX MUy97ntXcId8RUDfUYlQd6ZdkQNWJlKZ1WdarXJk8aNGKqvvdV2ZOw4nS6+/v0Vwi8LF hlhQ== X-Gm-Message-State: AOAM530e2aw9G6KMNKgzw/zAUVRANJbLOelGDdm4FRLIv/ArrzIaeS7R BZn0FgmcQYpnJnoV1S0D0lhusUnhJ6NAcS163ZjYNQ== X-Google-Smtp-Source: ABdhPJzx8Nk73g4tqbJCpA8ai2is1yTsdGPRgCDjZXH+10kwFFfyVfYfouwOTi44+ppD5Bdrt41ItohWHtzqJU0TNBI= X-Received: by 2002:a17:906:b104:: with SMTP id u4mr3838074ejy.201.1633696847585; Fri, 08 Oct 2021 05:40:47 -0700 (PDT) MIME-Version: 1.0 References: <20210919214937.3829422-1-sjg@chromium.org> <20210919214937.3829422-2-sjg@chromium.org> In-Reply-To: <20210919214937.3829422-2-sjg@chromium.org> From: Jagan Teki Date: Fri, 8 Oct 2021 18:10:36 +0530 Message-ID: Subject: Re: [PATCH v4 1/5] command: Use a constant pointer for the help To: Simon Glass Cc: U-Boot Mailing List , Heinrich Schuchardt Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Mon, Sep 20, 2021 at 3:19 AM Simon Glass wrote: > > This text should never change during execution, so it makes sense to > use a const char * so that it can be declared as const in the code. > Update struct cmd_tbl with a const char * pointer for 'help'. > > We cannot make usage const because of the bmode command, used on mx53ppd > for example. > > Signed-off-by: Simon Glass > --- > > (no changes since v2) > > Changes in v2: > - Explain why 'usage' cannot be const Reviewed-by: Jagan Teki