From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34AF970 for ; Tue, 30 Mar 2021 14:05:47 +0000 (UTC) Received: by mail-ej1-f52.google.com with SMTP id u9so25011184ejj.7 for ; Tue, 30 Mar 2021 07:05:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jGFF9gdonKt1Ey7EFMkwXk5G5SyST+KFl475vOEXsnA=; b=hN1KXQB6gjh8kexBKcrelNe8Sz4rfhPoccrZdPuN4usGsTRZFYPCMAr3NGtf3wcSqB /+RFavdLPO15oWZxdfUp578dEn8es0bzJ7CUyPCNOO/poa8689P0Ueqa8czz8Njt/u1z f0b0ErUgK+mIdX0x4DbttqBecDI91IXXySU5c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jGFF9gdonKt1Ey7EFMkwXk5G5SyST+KFl475vOEXsnA=; b=PYQ7OYVPQAT/gilQFBEwk2vp7qDatW2vvZyaxH4fxUf96HlZmEZupHM375xtnShI7Y 0W5LsNZ2xh54H8w1r3q/x+42d72XAZJ4ogV4Yq57T+gaMDfuqjuckgiqSfMj45SwaZxP TU1Zkj7aNmWcz2y0fpjtfMdxWxsZEhrYewPJSLiBQutQASZLQkopSBk8/p6RYNkUpda0 DvOZA9i8R2An7JZMhu6WtlLUXbbr/TbxzUwOabXTWzCaXo97ke/8WC07W8TarNRVlx4n M32TCoImg9FoocMuIoL1Dj0cXzxdTWpMJuzp3Qcqh4P4fjMokopzl2oOquhJbPyvY9WF ovoQ== X-Gm-Message-State: AOAM533EmObJEtHLRA6zJR07jGczlDIPuvUitgEogru6UNB28F+GMxcL JCHL+X2Tp5wF824ITBOe4xkX3RH2dIvX8eD+mJtWUg== X-Google-Smtp-Source: ABdhPJwMS/K6RYtxbzf950h8vh3nOccngkIxXxgRMbpaJsd699dOb8aup1+c9oabgjJ+AWmgxHWfGGBUcTB82R8jpMA= X-Received: by 2002:a17:906:2bc3:: with SMTP id n3mr33741675ejg.418.1617113146311; Tue, 30 Mar 2021 07:05:46 -0700 (PDT) X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20210330130122.3915-1-andre.przywara@arm.com> <20210330130122.3915-3-andre.przywara@arm.com> <912b7c69-fdac-8e2d-9d52-b28141beb299@sholland.org> In-Reply-To: <912b7c69-fdac-8e2d-9d52-b28141beb299@sholland.org> From: Jagan Teki Date: Tue, 30 Mar 2021 19:35:34 +0530 Message-ID: Subject: Re: [PATCH 2/2] sunxi: dts: H616: Drop reserved-memory node To: Samuel Holland Cc: Andre Przywara , Jernej Skrabec , Simon Glass , Tom Rini , U-Boot-Denx , linux-sunxi , linux-sunxi@lists.linux.dev Content-Type: text/plain; charset="UTF-8" On Tue, Mar 30, 2021 at 7:21 PM Samuel Holland wrote: > > On 3/30/21 8:28 AM, Jagan Teki wrote: > > On Tue, Mar 30, 2021 at 6:31 PM Andre Przywara wrote: > >> > >> Trusted Firmware now adds the /reserved-memory subnode to the DT at > >> runtime[1], putting in the right values. > >> > >> Drop our hard-coded version, as this might clash with the actual values > >> (which have also changed), and rely on TF-A to add the node. > >> > >> [1] https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/7770 > >> > >> Signed-off-by: Andre Przywara > > Reviewed-by: Samuel Holland > > >> --- > >> arch/arm/dts/sun50i-h616.dtsi | 12 ------------ > >> 1 file changed, 12 deletions(-) > >> > >> diff --git a/arch/arm/dts/sun50i-h616.dtsi b/arch/arm/dts/sun50i-h616.dtsi > >> index 953e8fac20f..dd4d2f31111 100644 > >> --- a/arch/arm/dts/sun50i-h616.dtsi > >> +++ b/arch/arm/dts/sun50i-h616.dtsi > >> @@ -51,18 +51,6 @@ > >> }; > >> }; > >> > >> - reserved-memory { > >> - #address-cells = <2>; > >> - #size-cells = <2>; > >> - ranges; > >> - > >> - /* 512KiB reserved for ARM Trusted Firmware (BL31) */ > >> - secmon_reserved: secmon@40000000 { > >> - reg = <0x0 0x40000000 0x0 0x80000>; > >> - no-map; > >> - }; > >> - }; > >> - > > > > As said always. it's better to not touch Linux dts files. If the same > > fix same available in Linux add SHA1 on the commit message otherwise > > keep /delete-node on -u-boot.dtsi. This how we are maintaining sofar > > at least on sunxi. > > This file has not yet been added to the Linux tree, so that rule does not apply > in this case. Reviewed-by: Jagan Teki From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jagan Teki Date: Tue, 30 Mar 2021 19:35:34 +0530 Subject: [PATCH 2/2] sunxi: dts: H616: Drop reserved-memory node In-Reply-To: <912b7c69-fdac-8e2d-9d52-b28141beb299@sholland.org> References: <20210330130122.3915-1-andre.przywara@arm.com> <20210330130122.3915-3-andre.przywara@arm.com> <912b7c69-fdac-8e2d-9d52-b28141beb299@sholland.org> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Mar 30, 2021 at 7:21 PM Samuel Holland wrote: > > On 3/30/21 8:28 AM, Jagan Teki wrote: > > On Tue, Mar 30, 2021 at 6:31 PM Andre Przywara wrote: > >> > >> Trusted Firmware now adds the /reserved-memory subnode to the DT at > >> runtime[1], putting in the right values. > >> > >> Drop our hard-coded version, as this might clash with the actual values > >> (which have also changed), and rely on TF-A to add the node. > >> > >> [1] https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/7770 > >> > >> Signed-off-by: Andre Przywara > > Reviewed-by: Samuel Holland > > >> --- > >> arch/arm/dts/sun50i-h616.dtsi | 12 ------------ > >> 1 file changed, 12 deletions(-) > >> > >> diff --git a/arch/arm/dts/sun50i-h616.dtsi b/arch/arm/dts/sun50i-h616.dtsi > >> index 953e8fac20f..dd4d2f31111 100644 > >> --- a/arch/arm/dts/sun50i-h616.dtsi > >> +++ b/arch/arm/dts/sun50i-h616.dtsi > >> @@ -51,18 +51,6 @@ > >> }; > >> }; > >> > >> - reserved-memory { > >> - #address-cells = <2>; > >> - #size-cells = <2>; > >> - ranges; > >> - > >> - /* 512KiB reserved for ARM Trusted Firmware (BL31) */ > >> - secmon_reserved: secmon at 40000000 { > >> - reg = <0x0 0x40000000 0x0 0x80000>; > >> - no-map; > >> - }; > >> - }; > >> - > > > > As said always. it's better to not touch Linux dts files. If the same > > fix same available in Linux add SHA1 on the commit message otherwise > > keep /delete-node on -u-boot.dtsi. This how we are maintaining sofar > > at least on sunxi. > > This file has not yet been added to the Linux tree, so that rule does not apply > in this case. Reviewed-by: Jagan Teki