From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2DC16C43334 for ; Fri, 1 Jul 2022 12:04:55 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E38CA84440; Fri, 1 Jul 2022 14:04:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="aa6mQMOH"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 61A5F842A3; Fri, 1 Jul 2022 14:04:51 +0200 (CEST) Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 83DCB842A3 for ; Fri, 1 Jul 2022 14:04:48 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jagan@amarulasolutions.com Received: by mail-ej1-x633.google.com with SMTP id u12so3657429eja.8 for ; Fri, 01 Jul 2022 05:04:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WpbWGqPUl5qcyl+9i59jwHjQaDsd+JHIZWK+P6PrwGs=; b=aa6mQMOHVaHe6Eas41Ad0ySVaegqdIORn18emvwPcjAx4U9w+iHX6TFws8+csfqzgB xTL6M3hfJsob7rrkRS98wqzSIFa1qLeuC88oYWDoTy4eogrO/bCcNELbOoXGUjw8sWF8 mtOn7GEHf845r1NjCiHuiNXysLesueYm5+YVY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WpbWGqPUl5qcyl+9i59jwHjQaDsd+JHIZWK+P6PrwGs=; b=k1ZRrgPy5SjwEtO45hxdjtOtPy8z+8+6+MkSF9/YzlRsbSiCHgIllKGrxr6ISIAGNM D8J39KUU7CUP5i4Iz61m0aQh0m4lga2P5v5Rn9QmH6Ag4KWjDZKCuo2vAHlZ/c+6LX3i 2g+DFflEoeZMWRiB0sq9xKbgQuY3zSyYx9LP/c3AgpDUDMGv7F6WpxsMHdzLKdikjB3j bLJWSIASUEJn1o5dW52P8NZfHJaziZFWmHQZ83o1IgBC+PKxi/fH/k5OmNA+9cBArgFs eEz3lP11yLuTZWkEGrqBEGkJa3XQay4YUg3NHFkkzvIGNUKDHwvioLxQUpxsUkVPs/6h LlvQ== X-Gm-Message-State: AJIora99kRSmD6S5+OmJWwjtMD3+sXLuenBgph+Pi+fhHfRtffqujp6a M55tpjB+m6GyKw/PAPM17774zio5Ipy5Pl6u9bHrAw== X-Google-Smtp-Source: AGRyM1v38BgxTQ1gv5096aHVCLfvwSiLjA8xi0n6DzCFlOSPNHHOgLQUhuLACkoDidHdADJzId3uwpjQWDPKGu86TmM= X-Received: by 2002:a17:907:3e9a:b0:726:d079:d868 with SMTP id hs26-20020a1709073e9a00b00726d079d868mr14460176ejc.620.1656677088073; Fri, 01 Jul 2022 05:04:48 -0700 (PDT) MIME-Version: 1.0 References: <20220524055650.1115899-1-chin-ting_kuo@aspeedtech.com> <20220524055650.1115899-8-chin-ting_kuo@aspeedtech.com> In-Reply-To: <20220524055650.1115899-8-chin-ting_kuo@aspeedtech.com> From: Jagan Teki Date: Fri, 1 Jul 2022 17:34:37 +0530 Message-ID: Subject: Re: [v4 07/12] spi-mem: Add dirmap API from Linux To: Chin-Ting Kuo Cc: chiawei_wang@aspeedtech.com, lukma@denx.de, seanga2@gmail.com, ryan_chen@aspeedtech.com, BMC-SW@aspeedtech.com, vigneshr@ti.com, clg@kaod.org, u-boot@lists.denx.de, p.yadav@ti.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Tue, May 24, 2022 at 11:28 AM Chin-Ting Kuo wrote: > > This adds the dirmap API originally introduced in Linux commit aa167f3 > ("spi: spi-mem: Add a new API to support direct mapping"). This also > includes several follow-up patches and fixes. > > Changes from Linux include: > * Added Kconfig option > * Changed struct device to struct udevice > * Changed struct spi_mem to struct spi_slave > > This patch is obtained from the following patch > https://patchwork.ozlabs.org/project/uboot/patch/20210205043924.149504-3-seanga2@gmail.com/ > > Signed-off-by: Chin-Ting Kuo > Signed-off-by: Sean Anderson > Acked-by: Pratyush Yadav > --- > v2: Remove "#if CONFIG_SPI_DIRMAP" compile wrapper. > v3: Fix a grammatical error in spi-mem.h. > > drivers/spi/Kconfig | 10 ++ > drivers/spi/spi-mem.c | 268 ++++++++++++++++++++++++++++++++++++++++++ > include/spi-mem.h | 79 +++++++++++++ > 3 files changed, 357 insertions(+) > > diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig > index a616294910..297253714a 100644 > --- a/drivers/spi/Kconfig > +++ b/drivers/spi/Kconfig > @@ -40,6 +40,16 @@ config SPI_MEM > This extension is meant to simplify interaction with SPI memories > by providing an high-level interface to send memory-like commands. > > +config SPI_DIRMAP Look like the following code is not part of this if construct, we need that to build only when SPI_DIRMAP is defined otherwise it footprint increase for non-DIRMAPs. Also please take care of unnecessary code while copying from Linux and add SHA1 in the commit message. Jagan.