From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7AB2C433DB for ; Wed, 24 Mar 2021 09:16:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 686B9619FB for ; Wed, 24 Mar 2021 09:16:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232101AbhCXJPy (ORCPT ); Wed, 24 Mar 2021 05:15:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234529AbhCXJPL (ORCPT ); Wed, 24 Mar 2021 05:15:11 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7287C061763 for ; Wed, 24 Mar 2021 02:15:09 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id h10so26717736edt.13 for ; Wed, 24 Mar 2021 02:15:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zsFZ3U+MTNyWBA6xTX8iF9xhpZHq3owuoQogBCZG32k=; b=SFaIWTPXjQmFIZdTzls7n3rZGu4qFTSI7ywPxkxDafUt+AG1O9zJ6P1P/a/TiI2mWP JyFpey4vtoBKpJMOf9daf8sVPp1ktAftF5yUmUQoRacS6+vGRKilP4xu9aRHgZ14jCE2 voQErrwf259SU9J9GSKws7cwMszh3ta43hPQs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zsFZ3U+MTNyWBA6xTX8iF9xhpZHq3owuoQogBCZG32k=; b=CVVUjek3zB0UwzPxRbdmmR2a71tjqCtJYot64Nf8UwN1ChnD9c+Gmhn0iSL7h5A/P+ cBKoi68qwwPVU4KRIklVMYdphOkuT6kofUy13Ni2A+c6OYRxkfXVvxQcxh1PHfgeE45H FBtAQTP2FqlctVs8K6K0QXu8IwC2JEaDMsK+lirTTRvayo9WYUpolQjAnEy5nqAbT8ta EXgBhdVCx6b4XqNAOfX9zCcTQS+8Xf7TnmHJa0m7rXQsaKZ338jShCA/1utgPyeDig25 pbjNratyeAPYCmFW4HhSS5+qxJM2JniZ7LcQjQlZhOetiZHLkajxWPPTyBjCCdwV3Tt2 Zbmw== X-Gm-Message-State: AOAM531bYsntpKiI9o6T7cPFW33e4CNpKdmlUcNn2qKepYhqsUQRO202 suRDn3DfPDx6O3jDAshYOhlX5YCOOKLqOBCR/8oAlw== X-Google-Smtp-Source: ABdhPJzmOXx9kgtZw4VSF8lAJqdI06RPrtHvtgVdVzxXyy5P7sR9NmJCv5xvsQKHo/odSeVeUt60nl7GZ+W71/v/OPI= X-Received: by 2002:a05:6402:4244:: with SMTP id g4mr2349372edb.204.1616577308579; Wed, 24 Mar 2021 02:15:08 -0700 (PDT) MIME-Version: 1.0 References: <20210322140152.101709-1-jagan@amarulasolutions.com> <20210322140152.101709-2-jagan@amarulasolutions.com> In-Reply-To: From: Jagan Teki Date: Wed, 24 Mar 2021 14:44:57 +0530 Message-ID: Subject: Re: [PATCH v4 1/4] drm: sun4i: dsi: Use drm_of_find_panel_or_bridge To: Samuel Holland Cc: Laurent Pinchart , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , dri-devel , linux-arm-kernel , linux-kernel , linux-amarula , linux-sunxi Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 24, 2021 at 8:18 AM Samuel Holland wrote: > > On 3/23/21 5:53 PM, Laurent Pinchart wrote: > > Hi Jagan, > > > > Thank you for the patch. > > > > On Mon, Mar 22, 2021 at 07:31:49PM +0530, Jagan Teki wrote: > >> Replace of_drm_find_panel with drm_of_find_panel_or_bridge > >> for finding panel, this indeed help to find the bridge if > >> bridge support added. > >> > >> Added NULL in bridge argument, same will replace with bridge > >> parameter once bridge supported. > >> > >> Signed-off-by: Jagan Teki > > > > Looks good, there should be no functional change. > > Actually this breaks all existing users of this driver, see below. > > > Reviewed-by: Laurent Pinchart > > > >> --- > >> Changes for v4, v3: > >> - none > >> > >> drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 11 ++++++++--- > >> 1 file changed, 8 insertions(+), 3 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > >> index 4f5efcace68e..2e9e7b2d4145 100644 > >> --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > >> +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > >> @@ -21,6 +21,7 @@ > >> > >> #include > >> #include > >> +#include > >> #include > >> #include > >> #include > >> @@ -963,10 +964,14 @@ static int sun6i_dsi_attach(struct mipi_dsi_host *host, > >> struct mipi_dsi_device *device) > >> { > >> struct sun6i_dsi *dsi = host_to_sun6i_dsi(host); > >> - struct drm_panel *panel = of_drm_find_panel(device->dev.of_node); > > This is using the OF node of the DSI device, which is a direct child of > the DSI host's OF node. There is no OF graph involved. > > >> + struct drm_panel *panel; > >> + int ret; > >> + > >> + ret = drm_of_find_panel_or_bridge(dsi->dev->of_node, 0, 0, > >> + &panel, NULL); > > However, this function expects to find the panel using OF graph. This > does not work with existing device trees (PinePhone, PineTab) which do > not use OF graph to connect the panel. And it cannot work, because the > DSI host's binding specifies a single port: the input port from the > display engine. Thanks for noticing this. I did understand your point and yes, I did mention the updated pipeline in previous versions and forgot to add it to this series. Here is the updated pipeline to make it work: https://patchwork.kernel.org/project/dri-devel/patch/20190524104252.20236-1-jagan@amarulasolutions.com/ Let me know your comments on this, so I will add a patch for the above-affected DTS files. Jagan. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95D4EC433DB for ; Wed, 24 Mar 2021 09:17:16 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 124C2619FC for ; Wed, 24 Mar 2021 09:17:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 124C2619FC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uL0pjhXzpiN5w5KLXwV3JCLyhAE0Q5bQwH0qGWk05vo=; b=eNP/vyZ3fBZRAS3NMBls0t9I2 epNwu4lZCS/+nQg5zeVLLAKeZIs68xbZ4quCIc3F4IiCJwtCBL8PAV+I4aMtxHtJO+WzYxVMcQYhi Ba7NrpOVvzO0sArSqZlPWPrq8dsGFZLheMCls6fy0AH4AFFlvmZkgsP20rfmL/nt0MXQ8EetrSx+v JeY7CSnp195flzTfcHUxT/6mH0BeOjmtIinkrpLe3xiOc4Igdw8twhh1hNc24xmO33LWshW4caQSA k1RxdMXMBkBrQgc+AB5DS59ETqEuQR6EAw+HhZQumSCmqWR4e8Lji/Xd1rlDlKq6lFeqcNOfQlrVU NTSPtaiKg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lOzbg-00Ghf1-Et; Wed, 24 Mar 2021 09:15:16 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lOzba-00Ghdd-0p for linux-arm-kernel@lists.infradead.org; Wed, 24 Mar 2021 09:15:12 +0000 Received: by mail-ed1-x535.google.com with SMTP id x21so26758141eds.4 for ; Wed, 24 Mar 2021 02:15:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zsFZ3U+MTNyWBA6xTX8iF9xhpZHq3owuoQogBCZG32k=; b=SFaIWTPXjQmFIZdTzls7n3rZGu4qFTSI7ywPxkxDafUt+AG1O9zJ6P1P/a/TiI2mWP JyFpey4vtoBKpJMOf9daf8sVPp1ktAftF5yUmUQoRacS6+vGRKilP4xu9aRHgZ14jCE2 voQErrwf259SU9J9GSKws7cwMszh3ta43hPQs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zsFZ3U+MTNyWBA6xTX8iF9xhpZHq3owuoQogBCZG32k=; b=c7iHuZ/Jzd1vlhqmwPPHrjHM8ac89Vl9nai4IShrmt/30zIYZ1Hmp93ycnt8TN/f17 zyjaSM5w0T/Rg0C/6r0ZmELDQD1twFCyL/VLAEr7MQBdJC0iE4Zu1ekedm2XsJTM/CCX K0XLAyHUN2Ew6O42b5VB6M3Pyi0FAVMzeSdDKh8QdEEK2fmkxP3evDBdUoKCWx+Q+ona LGDDvKya7X0zNkrety/x8b6xnbJazLG9uCeIeO5Iu97+u6qA313JiwpClvpydJaH27yh IK5JAnxCEvzxEUYZ1vsHpAFYvbMBTdOVjeF0zCCAwE32g1bV1UQF0fxwcSZBv6ACOhf2 Mv3g== X-Gm-Message-State: AOAM532DKnEs6BFPzi2SeTVHZFW/CPVqo7LZN4rhl9Uxu5DVIRTPc60y kD2bMEZkGI/DRSXAuuU1nGufkKz7HHG7+5xPhhB8rvlKgUA90U9L X-Google-Smtp-Source: ABdhPJzmOXx9kgtZw4VSF8lAJqdI06RPrtHvtgVdVzxXyy5P7sR9NmJCv5xvsQKHo/odSeVeUt60nl7GZ+W71/v/OPI= X-Received: by 2002:a05:6402:4244:: with SMTP id g4mr2349372edb.204.1616577308579; Wed, 24 Mar 2021 02:15:08 -0700 (PDT) MIME-Version: 1.0 References: <20210322140152.101709-1-jagan@amarulasolutions.com> <20210322140152.101709-2-jagan@amarulasolutions.com> In-Reply-To: From: Jagan Teki Date: Wed, 24 Mar 2021 14:44:57 +0530 Message-ID: Subject: Re: [PATCH v4 1/4] drm: sun4i: dsi: Use drm_of_find_panel_or_bridge To: Samuel Holland Cc: Laurent Pinchart , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , dri-devel , linux-arm-kernel , linux-kernel , linux-amarula , linux-sunxi X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210324_091510_242131_2C5706D6 X-CRM114-Status: GOOD ( 28.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 24, 2021 at 8:18 AM Samuel Holland wrote: > > On 3/23/21 5:53 PM, Laurent Pinchart wrote: > > Hi Jagan, > > > > Thank you for the patch. > > > > On Mon, Mar 22, 2021 at 07:31:49PM +0530, Jagan Teki wrote: > >> Replace of_drm_find_panel with drm_of_find_panel_or_bridge > >> for finding panel, this indeed help to find the bridge if > >> bridge support added. > >> > >> Added NULL in bridge argument, same will replace with bridge > >> parameter once bridge supported. > >> > >> Signed-off-by: Jagan Teki > > > > Looks good, there should be no functional change. > > Actually this breaks all existing users of this driver, see below. > > > Reviewed-by: Laurent Pinchart > > > >> --- > >> Changes for v4, v3: > >> - none > >> > >> drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 11 ++++++++--- > >> 1 file changed, 8 insertions(+), 3 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > >> index 4f5efcace68e..2e9e7b2d4145 100644 > >> --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > >> +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > >> @@ -21,6 +21,7 @@ > >> > >> #include > >> #include > >> +#include > >> #include > >> #include > >> #include > >> @@ -963,10 +964,14 @@ static int sun6i_dsi_attach(struct mipi_dsi_host *host, > >> struct mipi_dsi_device *device) > >> { > >> struct sun6i_dsi *dsi = host_to_sun6i_dsi(host); > >> - struct drm_panel *panel = of_drm_find_panel(device->dev.of_node); > > This is using the OF node of the DSI device, which is a direct child of > the DSI host's OF node. There is no OF graph involved. > > >> + struct drm_panel *panel; > >> + int ret; > >> + > >> + ret = drm_of_find_panel_or_bridge(dsi->dev->of_node, 0, 0, > >> + &panel, NULL); > > However, this function expects to find the panel using OF graph. This > does not work with existing device trees (PinePhone, PineTab) which do > not use OF graph to connect the panel. And it cannot work, because the > DSI host's binding specifies a single port: the input port from the > display engine. Thanks for noticing this. I did understand your point and yes, I did mention the updated pipeline in previous versions and forgot to add it to this series. Here is the updated pipeline to make it work: https://patchwork.kernel.org/project/dri-devel/patch/20190524104252.20236-1-jagan@amarulasolutions.com/ Let me know your comments on this, so I will add a patch for the above-affected DTS files. Jagan. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78277C433E5 for ; Wed, 24 Mar 2021 09:15:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A7AFE61A08 for ; Wed, 24 Mar 2021 09:15:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A7AFE61A08 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F04B36E989; Wed, 24 Mar 2021 09:15:10 +0000 (UTC) Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by gabe.freedesktop.org (Postfix) with ESMTPS id E51D16E989 for ; Wed, 24 Mar 2021 09:15:09 +0000 (UTC) Received: by mail-ed1-x52c.google.com with SMTP id z1so26804487edb.8 for ; Wed, 24 Mar 2021 02:15:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zsFZ3U+MTNyWBA6xTX8iF9xhpZHq3owuoQogBCZG32k=; b=SFaIWTPXjQmFIZdTzls7n3rZGu4qFTSI7ywPxkxDafUt+AG1O9zJ6P1P/a/TiI2mWP JyFpey4vtoBKpJMOf9daf8sVPp1ktAftF5yUmUQoRacS6+vGRKilP4xu9aRHgZ14jCE2 voQErrwf259SU9J9GSKws7cwMszh3ta43hPQs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zsFZ3U+MTNyWBA6xTX8iF9xhpZHq3owuoQogBCZG32k=; b=qmjo/2aG9EjyFRt5BX7aXU8erWjWcGbvAZsyQsINq+JM6UUqogeGZLYABYUiEK+vin yrPwtJWNtYcuDMRJszw02iQ7RNkdk4jmqzIH3+p3le39dfa7R63RcBhAxxWutpUjnzx7 8mpAWJ7idlgEqCaOStfTSnivSna+3i90roArOlpASSDNfOb4V7JOu5y1hsoGLdv2Vzz8 qKbMdYFXrgXZiIyDiOTD793aFxy928r5bjcoAvhQmGoDqKBFNbaSsHI3cx+Di/A0t97G C35k21hZ6r132Kkq0gOE1RKbphu84xXaKE1zhlfWHrxLkg4O/Z3+YOCKxguDpC4NsgGp GU9g== X-Gm-Message-State: AOAM530iCo92NzLSip429jXy5/HFhWeI/BXnPyeNgKWh0O5KDNk3LpS0 MbqJ3YwRnyW73syibnR9iQl1pBIeGsG99mhp7m5S0A== X-Google-Smtp-Source: ABdhPJzmOXx9kgtZw4VSF8lAJqdI06RPrtHvtgVdVzxXyy5P7sR9NmJCv5xvsQKHo/odSeVeUt60nl7GZ+W71/v/OPI= X-Received: by 2002:a05:6402:4244:: with SMTP id g4mr2349372edb.204.1616577308579; Wed, 24 Mar 2021 02:15:08 -0700 (PDT) MIME-Version: 1.0 References: <20210322140152.101709-1-jagan@amarulasolutions.com> <20210322140152.101709-2-jagan@amarulasolutions.com> In-Reply-To: From: Jagan Teki Date: Wed, 24 Mar 2021 14:44:57 +0530 Message-ID: Subject: Re: [PATCH v4 1/4] drm: sun4i: dsi: Use drm_of_find_panel_or_bridge To: Samuel Holland X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , linux-sunxi , linux-kernel , dri-devel , Chen-Yu Tsai , Laurent Pinchart , linux-amarula , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Mar 24, 2021 at 8:18 AM Samuel Holland wrote: > > On 3/23/21 5:53 PM, Laurent Pinchart wrote: > > Hi Jagan, > > > > Thank you for the patch. > > > > On Mon, Mar 22, 2021 at 07:31:49PM +0530, Jagan Teki wrote: > >> Replace of_drm_find_panel with drm_of_find_panel_or_bridge > >> for finding panel, this indeed help to find the bridge if > >> bridge support added. > >> > >> Added NULL in bridge argument, same will replace with bridge > >> parameter once bridge supported. > >> > >> Signed-off-by: Jagan Teki > > > > Looks good, there should be no functional change. > > Actually this breaks all existing users of this driver, see below. > > > Reviewed-by: Laurent Pinchart > > > >> --- > >> Changes for v4, v3: > >> - none > >> > >> drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 11 ++++++++--- > >> 1 file changed, 8 insertions(+), 3 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > >> index 4f5efcace68e..2e9e7b2d4145 100644 > >> --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > >> +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > >> @@ -21,6 +21,7 @@ > >> > >> #include > >> #include > >> +#include > >> #include > >> #include > >> #include > >> @@ -963,10 +964,14 @@ static int sun6i_dsi_attach(struct mipi_dsi_host *host, > >> struct mipi_dsi_device *device) > >> { > >> struct sun6i_dsi *dsi = host_to_sun6i_dsi(host); > >> - struct drm_panel *panel = of_drm_find_panel(device->dev.of_node); > > This is using the OF node of the DSI device, which is a direct child of > the DSI host's OF node. There is no OF graph involved. > > >> + struct drm_panel *panel; > >> + int ret; > >> + > >> + ret = drm_of_find_panel_or_bridge(dsi->dev->of_node, 0, 0, > >> + &panel, NULL); > > However, this function expects to find the panel using OF graph. This > does not work with existing device trees (PinePhone, PineTab) which do > not use OF graph to connect the panel. And it cannot work, because the > DSI host's binding specifies a single port: the input port from the > display engine. Thanks for noticing this. I did understand your point and yes, I did mention the updated pipeline in previous versions and forgot to add it to this series. Here is the updated pipeline to make it work: https://patchwork.kernel.org/project/dri-devel/patch/20190524104252.20236-1-jagan@amarulasolutions.com/ Let me know your comments on this, so I will add a patch for the above-affected DTS files. Jagan. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel