From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E038C433F5 for ; Mon, 1 Nov 2021 07:12:32 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1296860FE8 for ; Mon, 1 Nov 2021 07:12:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1296860FE8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F19248203C; Mon, 1 Nov 2021 08:12:29 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="VgwyOJbD"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C073D83323; Mon, 1 Nov 2021 08:12:28 +0100 (CET) Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CBE2E801DD for ; Mon, 1 Nov 2021 08:12:25 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jagan@amarulasolutions.com Received: by mail-ed1-x532.google.com with SMTP id m14so8281222edd.0 for ; Mon, 01 Nov 2021 00:12:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kR5R05NOfqw3NDY1WzQaLvHoWnBSBVfCaOAv4qRCTv8=; b=VgwyOJbDRWFPr61XC8j3C+9fLbWYdJ529v7N8QioMOuyWidYs2Gwk2jPr9uYPIneR0 LY4AMigh5P1c5B7HKFloULJCsvuuMtwNyHj3UOe7MhJoD02ghaDGj1twkoBROP8u02Qt 5T8ktMgMEaJPbvb1JuY3kdP8Y5yHz9lwqKt6A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kR5R05NOfqw3NDY1WzQaLvHoWnBSBVfCaOAv4qRCTv8=; b=qmS8u44IGRWl8cGNfg1sMg2NgL34WLK0rE7mwwQA06QXe8V3UDqF8ez80JBkZqYIvO nsHu7k+IIZs986MC6b4HwF2sZptk4cQgNkRdHO3nasqQHCMG1vCirxYBeWiTiYWw4KEX dQYncbxa7yqwj+ifipVGizjmhlvOj/SjC58kbJiycepOQs1Q8YGB2FQoxDv45M05Qclj GRjGQxeE34tKmFUIxIjzpugMFkF2B66KzvpsLXXbsK6i/H7Dtx/71UEt9yh7qz7eLbHV ujGiC/64ms0v6RmytjSaI8TkyYwYsXHvRSvafsP59S4usNAGcTT3aJGyqgmmPfw1c9oa tt+Q== X-Gm-Message-State: AOAM533ZKDCFcse18nGH9vDQG6JdL0uz3KVfu6abDK5O4fHS5G1Ofv03 bnBHaPH0D4gAExqaQ0waLqymxr1zTGmQ01/e74fuvg== X-Google-Smtp-Source: ABdhPJwhJcnVcSbsACP3CT15be8Lu6PA0CaEGxXjx4rNLG/22D/xOJeWSuyxw7TFQRB580ZNLrf1ZM2cFcWbURqQMHY= X-Received: by 2002:a50:e004:: with SMTP id e4mr38878757edl.246.1635750745487; Mon, 01 Nov 2021 00:12:25 -0700 (PDT) MIME-Version: 1.0 References: <20211025123639.v4.1.Ibcd6b4db038dac555a5071d1406a0c2f757c9570@changeid> In-Reply-To: <20211025123639.v4.1.Ibcd6b4db038dac555a5071d1406a0c2f757c9570@changeid> From: Jagan Teki Date: Mon, 1 Nov 2021 12:42:14 +0530 Message-ID: Subject: Re: [PATCH v4] driver: spi: add bcm iproc qspi support. To: Roman Bacik Cc: U-Boot Mailing List , Rayagonda Kokatanur , Bharat Gooty , Vignesh R Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Tue, Oct 26, 2021 at 1:07 AM Roman Bacik wrote: > > From: Rayagonda Kokatanur > > IPROC qspi driver supports both BSPI and MSPI modes. > > Signed-off-by: Rayagonda Kokatanur > Signed-off-by: Bharat Gooty > Acked-by: Rayagonda Kokatanur > > Signed-off-by: Roman Bacik > --- > > Changes in v4: > - move iproc_qspi.c from spi to mtd/spi > - remove iproc_qspi.h > - rename IPROC_QSPI to SPI_FLASH_IPROC > > Changes in v3: > - fix warning by including linux/delay.h > - change ofdata_to_platdata to of_to_plat > - change priv_auto_alloc_size to priv_auto > > Changes in v2: > - remove include spi-nor.h > - define and use named BITs for writing register values > - remove bspi_set_4byte_mode() method > > drivers/mtd/spi/Kconfig | 6 + > drivers/mtd/spi/Makefile | 1 + > drivers/mtd/spi/iproc_qspi.c | 718 +++++++++++++++++++++++++++++++++++ > 3 files changed, 725 insertions(+) > create mode 100644 drivers/mtd/spi/iproc_qspi.c Look like you confused what I've mentioned before, your driver is flash specific so add a driver in UCLASS_SPI_FLASH. drivers with UCLASS_SPI to be in drivers/spi/ Jagan.