From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 267AFC43381 for ; Mon, 21 Dec 2020 19:34:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E618522B3B for ; Mon, 21 Dec 2020 19:34:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726330AbgLUTeB (ORCPT ); Mon, 21 Dec 2020 14:34:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726022AbgLUTeA (ORCPT ); Mon, 21 Dec 2020 14:34:00 -0500 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C8E4C061282 for ; Mon, 21 Dec 2020 11:33:20 -0800 (PST) Received: by mail-ej1-x634.google.com with SMTP id j22so14999018eja.13 for ; Mon, 21 Dec 2020 11:33:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pb1m+eHhWw+yOXKOAnhn6l+hywm6OGgR2u/XR7HjvII=; b=h26DYkpqx32ip/b6q/4C8kMeM8GbTSR0NR5L8UoOmvKIy9o/VpcDLBuKJlKgdx8G1r HZ5v2r/bT3psa8oMnj8AHOtwADEfFpP389O91qC9GSHcwHEoIEzbliG6Y5i+nbJ5zDY3 XaRcq5OlHGr8QIfL6X5q64udokFl1SkVztQvc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pb1m+eHhWw+yOXKOAnhn6l+hywm6OGgR2u/XR7HjvII=; b=jH0HHIrE+bRseRG4xgAECiOsYiohTPOgEqjMVthqyjE3tZDQaSNLMqMKDejkmiI6T8 3kNyMvVgEVQ8lOum1ctGOat5wd/ahQbEeCZDriyK+JkUzCM32FBluqKP2b4AUgY9U4+n Wx1AdRGg6tIg5H+kx1wISdtzYVGhfXtvxbdZAfsLTYKE29Ug3aOwQNqcU8EdPEkVlLLj TLWXvJo7dOGioiJnAC0TXLJvDlnTA2ZRAU7rgM51qoLML2hkthI9v9DX7e03YTnTMj2J BBpQX5LDORsvEB8QMeaZQg8rx2jfvHKqaA9hyBehtXBy5o5ruHWtpDMW7xpu+aL8s68X 5Dew== X-Gm-Message-State: AOAM530+qKKcZRBsAl2xW90fhaxFidQRSdr90ErthAKZzYUwmPA3IDai wP7pMV7450hWSrLLd2xidcDNm6QG94XclNSlBJSxcA== X-Google-Smtp-Source: ABdhPJxrRJkhtvKdQvdWpu00aAd7fHCVYwl0DO8M3A1Z9aI2vXDj+Z8Dm/ZyRbRIbwNVZDnN+K2kB2ZvWTTgxkaEacA= X-Received: by 2002:a17:906:c310:: with SMTP id s16mr16805482ejz.186.1608579199023; Mon, 21 Dec 2020 11:33:19 -0800 (PST) MIME-Version: 1.0 References: <20201221113151.94515-1-jagan@amarulasolutions.com> <20201221113151.94515-7-jagan@amarulasolutions.com> <20201221140642.GF31176@kozik-lap> In-Reply-To: <20201221140642.GF31176@kozik-lap> From: Jagan Teki Date: Tue, 22 Dec 2020 01:03:07 +0530 Message-ID: Subject: Re: [PATCH v2 6/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit To: Krzysztof Kozlowski Cc: Rob Herring , Shawn Guo , Li Yang , Fabio Estevam , devicetree , linux-kernel , linux-arm-kernel , NXP Linux Team , linux-amarula , Catalin Marinas , Will Deacon , Matteo Lisi Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 21, 2020 at 7:36 PM Krzysztof Kozlowski wrote: > > On Mon, Dec 21, 2020 at 05:01:51PM +0530, Jagan Teki wrote: > > Engicam EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive > > Evaluation Board. > > > > Genaral features: > > - LCD 7" C.Touch > > - microSD slot > > - Ethernet 1Gb > > - Wifi/BT > > - 2x LVDS Full HD interfaces > > - 3x USB 2.0 > > - 1x USB 3.0 > > - HDMI Out > > - Mini PCIe > > - MIPI CSI > > - 2x CAN > > - Audio Out > > > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam. > > > > i.Core MX8M Mini needs to mount on top of this Evaluation board for > > creating complete i.Core MX8M Mini EDIMM2.2 Starter Kit. > > > > PCIe, DSI, CSI nodes will add it into imx8mm-engicam-edimm2.2.dtsi once > > Mainline Linux supported. > > > > Add support for it. > > > > Signed-off-by: Matteo Lisi > > Signed-off-by: Jagan Teki > > --- > > Changes for v2: > > - updated commit message > > - dropped engicam from filename since it aligned with imx6 engicam > > dts files naming conventions. > > > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > .../freescale/imx8mm-engicam-edimm2.2.dtsi | 7 +++++++ > > .../freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 21 +++++++++++++++++++ > > 3 files changed, 29 insertions(+) > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > > index 8d49a2c74604..43783076f856 100644 > > --- a/arch/arm64/boot/dts/freescale/Makefile > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > @@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb > > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > new file mode 100644 > > index 000000000000..294df07289a2 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > @@ -0,0 +1,7 @@ > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > +/* > > + * Copyright (c) 2020 Engicam srl > > + * Copyright (c) 2020 Amarula Solutions(India) > > + */ > > + > > +#include "imx8mm-engicam-common.dtsi" > > It seems you ignored my comments from previous email. That's not how we > go with the process. > > Don't create confusing or overcomplicated hierarchy of includes. Don't > create files which do nothing. Idea is to move common nodes in separate dtsi instead of adding redundant nodes into respective areas. let me know if it still confusing. Jagan. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CEA1C433DB for ; Mon, 21 Dec 2020 19:34:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3828022B43 for ; Mon, 21 Dec 2020 19:34:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3828022B43 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=L8gs2PdQncUQmS3+zOI5Yf13fG0ApwhWAhZBJ9aHUtQ=; b=zYJdICBrDZmB+9AC1pAqnwzvd qE/hyHxYg5+j54tjpFnDhnrupAv6Kdu5DKA4u4Ic4MEejFQZJA8oX/8Q+ukhelzAbDwGohEB4+K+V pPdwIU9orALU1ULM5U2695BshNo7JMb/uOT7wJ+eZlpjfyinuKw+PAYVS7UXAa2gnIuvAkaUgsyW0 vBmAPEJmIhmjhzvsaOu5c+iKAm7DkWwgydQCmwavgy/cV4y6gctvpUcM1Ma5k/yLQY2IyDTi8U87a aOdwQmtWTOBZd8kbGakrRDZakifmB8oEp1R6nS5latj3Av0+lUN+/Vo4+2sGe5YS3uNJ9QOXSebuT y7VvLrfdg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1krQvq-0003Iq-SN; Mon, 21 Dec 2020 19:33:22 +0000 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1krQvn-0003IL-U8 for linux-arm-kernel@lists.infradead.org; Mon, 21 Dec 2020 19:33:21 +0000 Received: by mail-ej1-x636.google.com with SMTP id d17so15015519ejy.9 for ; Mon, 21 Dec 2020 11:33:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pb1m+eHhWw+yOXKOAnhn6l+hywm6OGgR2u/XR7HjvII=; b=h26DYkpqx32ip/b6q/4C8kMeM8GbTSR0NR5L8UoOmvKIy9o/VpcDLBuKJlKgdx8G1r HZ5v2r/bT3psa8oMnj8AHOtwADEfFpP389O91qC9GSHcwHEoIEzbliG6Y5i+nbJ5zDY3 XaRcq5OlHGr8QIfL6X5q64udokFl1SkVztQvc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pb1m+eHhWw+yOXKOAnhn6l+hywm6OGgR2u/XR7HjvII=; b=Ro7jFTaF7GkeBs6RZPGLHkhhdY7BS7KA13LkMX1Yxe1W62B8i3vb7biKGfaePpshej VrWL4XNVfNBGoJ2Fml/mFm/bxx3AxC7qV15jMfumUxJqiWxxDBrLLd6RrGV9DHhcT8ZS A1DqGB4RDzltfhxU1opAKsF0o6AGUmkHmz0AEYZZegKtYg8xYCExhxK6feI/ghuHasKS CNS/aQqY8NaVUuuZt4whyISarz8b3gHFuZ3CaDt8KI+QwI4z794h2cHxb8fUdmhDpl5U o7KhCQT8m0Sb2agdqVxtXLKwFVkr9Dcow2bBqoySue72R5WYUDiOOdr+VBSZoHg2ydiP 5G/A== X-Gm-Message-State: AOAM531ocC97FKAO1dKSnaMstwM9/TD2ek4FPOzDpk/Y1USAnaqbF79h 5v3jdmjDPaiMpH4qAaodnIKF1A8niSemPCoEhahKbQ== X-Google-Smtp-Source: ABdhPJxrRJkhtvKdQvdWpu00aAd7fHCVYwl0DO8M3A1Z9aI2vXDj+Z8Dm/ZyRbRIbwNVZDnN+K2kB2ZvWTTgxkaEacA= X-Received: by 2002:a17:906:c310:: with SMTP id s16mr16805482ejz.186.1608579199023; Mon, 21 Dec 2020 11:33:19 -0800 (PST) MIME-Version: 1.0 References: <20201221113151.94515-1-jagan@amarulasolutions.com> <20201221113151.94515-7-jagan@amarulasolutions.com> <20201221140642.GF31176@kozik-lap> In-Reply-To: <20201221140642.GF31176@kozik-lap> From: Jagan Teki Date: Tue, 22 Dec 2020 01:03:07 +0530 Message-ID: Subject: Re: [PATCH v2 6/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit To: Krzysztof Kozlowski X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201221_143320_283497_3BF24D2E X-CRM114-Status: GOOD ( 23.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Matteo Lisi , Will Deacon , Shawn Guo , linux-kernel , Li Yang , Rob Herring , NXP Linux Team , Catalin Marinas , Fabio Estevam , linux-amarula , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 21, 2020 at 7:36 PM Krzysztof Kozlowski wrote: > > On Mon, Dec 21, 2020 at 05:01:51PM +0530, Jagan Teki wrote: > > Engicam EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive > > Evaluation Board. > > > > Genaral features: > > - LCD 7" C.Touch > > - microSD slot > > - Ethernet 1Gb > > - Wifi/BT > > - 2x LVDS Full HD interfaces > > - 3x USB 2.0 > > - 1x USB 3.0 > > - HDMI Out > > - Mini PCIe > > - MIPI CSI > > - 2x CAN > > - Audio Out > > > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam. > > > > i.Core MX8M Mini needs to mount on top of this Evaluation board for > > creating complete i.Core MX8M Mini EDIMM2.2 Starter Kit. > > > > PCIe, DSI, CSI nodes will add it into imx8mm-engicam-edimm2.2.dtsi once > > Mainline Linux supported. > > > > Add support for it. > > > > Signed-off-by: Matteo Lisi > > Signed-off-by: Jagan Teki > > --- > > Changes for v2: > > - updated commit message > > - dropped engicam from filename since it aligned with imx6 engicam > > dts files naming conventions. > > > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > .../freescale/imx8mm-engicam-edimm2.2.dtsi | 7 +++++++ > > .../freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 21 +++++++++++++++++++ > > 3 files changed, 29 insertions(+) > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > > index 8d49a2c74604..43783076f856 100644 > > --- a/arch/arm64/boot/dts/freescale/Makefile > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > @@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb > > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > new file mode 100644 > > index 000000000000..294df07289a2 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > @@ -0,0 +1,7 @@ > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > +/* > > + * Copyright (c) 2020 Engicam srl > > + * Copyright (c) 2020 Amarula Solutions(India) > > + */ > > + > > +#include "imx8mm-engicam-common.dtsi" > > It seems you ignored my comments from previous email. That's not how we > go with the process. > > Don't create confusing or overcomplicated hierarchy of includes. Don't > create files which do nothing. Idea is to move common nodes in separate dtsi instead of adding redundant nodes into respective areas. let me know if it still confusing. Jagan. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel