From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83840C433DB for ; Tue, 22 Dec 2020 08:52:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B45A22517 for ; Tue, 22 Dec 2020 08:52:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726279AbgLVIvt (ORCPT ); Tue, 22 Dec 2020 03:51:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725913AbgLVIvs (ORCPT ); Tue, 22 Dec 2020 03:51:48 -0500 Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E917DC0613D6 for ; Tue, 22 Dec 2020 00:51:07 -0800 (PST) Received: by mail-qk1-x72a.google.com with SMTP id z11so11264560qkj.7 for ; Tue, 22 Dec 2020 00:51:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Jw7pAvMhTMzCdwMwDUYDkty+J1oyK3sGi3/Q3qZzhI4=; b=M7rKzFAvnf1eVok6BR2BkWW8L3u6lT17e0MCu4a7zRxzT1SFl2ADqVVldn9Vs1J8ZK cVN8iYFnRfq2Hna8rrb/BzeVVqTvA3vltkdkcj7hnu+PcOsS0hpvRhj8hlJZwygFm4m9 t5Hz9EHUlAUFFiPYn2caTRqRc6VwgN+WAq6OE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Jw7pAvMhTMzCdwMwDUYDkty+J1oyK3sGi3/Q3qZzhI4=; b=AfCyf+fJYXj1dQ5nEdM8kNv5ZgcPxXbsLLWmAvntciD8iDHjkrFftHAHFh3dj5Q036 wACRi3LYtQff+BXa5KSfNemw6kMKVGiljZ2+c8DWcpJDv8FLgqzkt4W5kKgtrS2k/rwy 5Yw/CSXXQJ9U+tZPNDj8RUwDrDladEvXu+f0njV7fELZq3aJ8iulUI68r90bkeAG62jB +z1jyvNAWzoSCXmgIxNynQ4MdcC8Ee9b3A4AeIFd7CnCxzQBziSTKdXxtxW0uJ3V+nbj eQJR+IaK/7HWcZJbUl8VdNG9XSQoaTDHVom4lUed37RRF232otC4GjIJ2OY8Ah5aTWgX qJGA== X-Gm-Message-State: AOAM531L+ejb0L8vd3P8+L3qB/PHoGnkVVLHDR3op6jeB+8CC1fZC4tF +rcTYCUeKMt3pgxmpJMPyhURq+O74uSsfG7i3hynxw== X-Google-Smtp-Source: ABdhPJx8RkliIALcQxSbRGxUhy8aMdeHkw9BI0+O7yz/6tnxHqaYrBeFbmioRudR3PD6pX7lsQYQ0xyzp7n61rjUTiQ= X-Received: by 2002:a37:a1d6:: with SMTP id k205mr21033434qke.384.1608627067021; Tue, 22 Dec 2020 00:51:07 -0800 (PST) MIME-Version: 1.0 References: <20201221113151.94515-1-jagan@amarulasolutions.com> <20201221113151.94515-7-jagan@amarulasolutions.com> <20201221140642.GF31176@kozik-lap> <20201221210601.GB2504@kozik-lap> In-Reply-To: <20201221210601.GB2504@kozik-lap> From: Jagan Teki Date: Tue, 22 Dec 2020 14:20:55 +0530 Message-ID: Subject: Re: [PATCH v2 6/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit To: Krzysztof Kozlowski Cc: Rob Herring , Shawn Guo , Li Yang , Fabio Estevam , devicetree , linux-kernel , linux-arm-kernel , NXP Linux Team , linux-amarula , Catalin Marinas , Will Deacon , Matteo Lisi Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 22, 2020 at 2:36 AM Krzysztof Kozlowski wrote: > > On Tue, Dec 22, 2020 at 01:03:07AM +0530, Jagan Teki wrote: > > On Mon, Dec 21, 2020 at 7:36 PM Krzysztof Kozlowski wrote: > > > > > > On Mon, Dec 21, 2020 at 05:01:51PM +0530, Jagan Teki wrote: > > > > Engicam EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive > > > > Evaluation Board. > > > > > > > > Genaral features: > > > > - LCD 7" C.Touch > > > > - microSD slot > > > > - Ethernet 1Gb > > > > - Wifi/BT > > > > - 2x LVDS Full HD interfaces > > > > - 3x USB 2.0 > > > > - 1x USB 3.0 > > > > - HDMI Out > > > > - Mini PCIe > > > > - MIPI CSI > > > > - 2x CAN > > > > - Audio Out > > > > > > > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam. > > > > > > > > i.Core MX8M Mini needs to mount on top of this Evaluation board for > > > > creating complete i.Core MX8M Mini EDIMM2.2 Starter Kit. > > > > > > > > PCIe, DSI, CSI nodes will add it into imx8mm-engicam-edimm2.2.dtsi once > > > > Mainline Linux supported. > > > > > > > > Add support for it. > > > > > > > > Signed-off-by: Matteo Lisi > > > > Signed-off-by: Jagan Teki > > > > --- > > > > Changes for v2: > > > > - updated commit message > > > > - dropped engicam from filename since it aligned with imx6 engicam > > > > dts files naming conventions. > > > > > > > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > > > .../freescale/imx8mm-engicam-edimm2.2.dtsi | 7 +++++++ > > > > .../freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 21 +++++++++++++++++++ > > > > 3 files changed, 29 insertions(+) > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > > > > index 8d49a2c74604..43783076f856 100644 > > > > --- a/arch/arm64/boot/dts/freescale/Makefile > > > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > > > @@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb > > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > > > new file mode 100644 > > > > index 000000000000..294df07289a2 > > > > --- /dev/null > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > > > @@ -0,0 +1,7 @@ > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > > +/* > > > > + * Copyright (c) 2020 Engicam srl > > > > + * Copyright (c) 2020 Amarula Solutions(India) > > > > + */ > > > > + > > > > +#include "imx8mm-engicam-common.dtsi" > > > > > > It seems you ignored my comments from previous email. That's not how we > > > go with the process. > > > > > > Don't create confusing or overcomplicated hierarchy of includes. Don't > > > create files which do nothing. > > > > Idea is to move common nodes in separate dtsi instead of adding > > redundant nodes into respective areas. let me know if it still > > confusing. > > A file which *only* includes another file does not fulfill this idea of > moving common nodes to a separate DTSI file. Or if I still miss > something, please point me, what common nodes are stored in > imx8mm-engicam-edimm2.2.dtsi? imx8mm-engicam-edimm2.2.dtsi for EDIMM2.2 Carrier imx8mm-engicam-ctouch2.dtsi for C.TOUCH2 Carrier imx8mm-engicam-common.dtsi for common nodes for above 2 carrier boards. Yes, imx8mm-engicam-edimm2.2.dtsi is empty now but nodes like PCIe, CSI, DSI will support once the respective drivers are part of Mainline but those are not supported in C.TOUCH2 carrier board dtsi. There are some GPIO pins differences between EDIMM2.2 and C.TOUCH2 carriers on WiFi/BT so those will be part of the respective carrier dtsi. Hope this would clear. Jagan. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20F3DC433E0 for ; Tue, 22 Dec 2020 08:52:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B0233221FA for ; Tue, 22 Dec 2020 08:52:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B0233221FA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LDr1uNoIATIT6GnZqLrjHoLMKLdXlHB+YTxvMZ5L4zg=; b=H7F+h1CLTTg0HZT0RlFzhtjoc IUGZuXMrN0Y15HeHPoSXG3PaKvhAjUAOIhodgSmdd8nn0L7/oHz5Hj72jTcU6mOWkvhJR2pmPIlGK mIxYYv5r/rb+oRmn9DthtdXJpzBNLS+m9ns7bBOM8gqD0ANu45J/4BMj//DlXD8XSsevAEQ2/8U5q btDTrHiJqigXncYJAakMlhUMlxANOaq48zedAThUWkQBtplqvXh/yJERuFM2YPA6MgPVyzOLTi0yX V0bdOiKuwHTBrPOheIe2vFkBbnKpfSIiZPzYvyWfHEQyzSDx9dzMKuHd76fTXW0/+UjlLp3LTGFKP VYZbmyrkw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1krdNy-0004fw-Hl; Tue, 22 Dec 2020 08:51:14 +0000 Received: from mail-qk1-x732.google.com ([2607:f8b0:4864:20::732]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1krdNt-0004eY-4t for linux-arm-kernel@lists.infradead.org; Tue, 22 Dec 2020 08:51:12 +0000 Received: by mail-qk1-x732.google.com with SMTP id v126so6766121qkd.11 for ; Tue, 22 Dec 2020 00:51:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Jw7pAvMhTMzCdwMwDUYDkty+J1oyK3sGi3/Q3qZzhI4=; b=M7rKzFAvnf1eVok6BR2BkWW8L3u6lT17e0MCu4a7zRxzT1SFl2ADqVVldn9Vs1J8ZK cVN8iYFnRfq2Hna8rrb/BzeVVqTvA3vltkdkcj7hnu+PcOsS0hpvRhj8hlJZwygFm4m9 t5Hz9EHUlAUFFiPYn2caTRqRc6VwgN+WAq6OE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Jw7pAvMhTMzCdwMwDUYDkty+J1oyK3sGi3/Q3qZzhI4=; b=suSBlDYktnZQ93DyWdKKNW1Mdxlw9ZyUbZIKbrscLTCp8S9I21K2/hWrwbNN/LxoQG oTJ0i5C8jc/JTdlDlbhMV4uv+h+4wxIuC0wMb4uDdI7T4ERb8vijxDnNCva6efaXRiUQ mjLMffE+aG0ZA1nsSWtyriqzr6vCgF7b5RAAsdBHavs7t0b55tcnlb0P8+v+zHjMIpl8 KuSO79Ths4MB2laF9YEcorG7gJDY/Novh8hSCam0ICKNzXN2W7uw0eAVjRkwFMkvkQ3d 7Te86daFYSdEe7mawmp0uj839RQczi9RbQrI5ylmlT6kJSYM5tyEDypimi45FupYWiFi aHhQ== X-Gm-Message-State: AOAM531mXUgrgMWkkdz67aJkdHBl0cr2uus6UBdyWTc+4REaxYdmOzM8 N9a9EiEadx6B2XXrrAVGAP8Ot53qhyLh327lV31yLg== X-Google-Smtp-Source: ABdhPJx8RkliIALcQxSbRGxUhy8aMdeHkw9BI0+O7yz/6tnxHqaYrBeFbmioRudR3PD6pX7lsQYQ0xyzp7n61rjUTiQ= X-Received: by 2002:a37:a1d6:: with SMTP id k205mr21033434qke.384.1608627067021; Tue, 22 Dec 2020 00:51:07 -0800 (PST) MIME-Version: 1.0 References: <20201221113151.94515-1-jagan@amarulasolutions.com> <20201221113151.94515-7-jagan@amarulasolutions.com> <20201221140642.GF31176@kozik-lap> <20201221210601.GB2504@kozik-lap> In-Reply-To: <20201221210601.GB2504@kozik-lap> From: Jagan Teki Date: Tue, 22 Dec 2020 14:20:55 +0530 Message-ID: Subject: Re: [PATCH v2 6/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit To: Krzysztof Kozlowski X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201222_035109_938079_EFF69B32 X-CRM114-Status: GOOD ( 29.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Matteo Lisi , Will Deacon , Shawn Guo , linux-kernel , Li Yang , Rob Herring , NXP Linux Team , Catalin Marinas , Fabio Estevam , linux-amarula , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 22, 2020 at 2:36 AM Krzysztof Kozlowski wrote: > > On Tue, Dec 22, 2020 at 01:03:07AM +0530, Jagan Teki wrote: > > On Mon, Dec 21, 2020 at 7:36 PM Krzysztof Kozlowski wrote: > > > > > > On Mon, Dec 21, 2020 at 05:01:51PM +0530, Jagan Teki wrote: > > > > Engicam EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive > > > > Evaluation Board. > > > > > > > > Genaral features: > > > > - LCD 7" C.Touch > > > > - microSD slot > > > > - Ethernet 1Gb > > > > - Wifi/BT > > > > - 2x LVDS Full HD interfaces > > > > - 3x USB 2.0 > > > > - 1x USB 3.0 > > > > - HDMI Out > > > > - Mini PCIe > > > > - MIPI CSI > > > > - 2x CAN > > > > - Audio Out > > > > > > > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam. > > > > > > > > i.Core MX8M Mini needs to mount on top of this Evaluation board for > > > > creating complete i.Core MX8M Mini EDIMM2.2 Starter Kit. > > > > > > > > PCIe, DSI, CSI nodes will add it into imx8mm-engicam-edimm2.2.dtsi once > > > > Mainline Linux supported. > > > > > > > > Add support for it. > > > > > > > > Signed-off-by: Matteo Lisi > > > > Signed-off-by: Jagan Teki > > > > --- > > > > Changes for v2: > > > > - updated commit message > > > > - dropped engicam from filename since it aligned with imx6 engicam > > > > dts files naming conventions. > > > > > > > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > > > .../freescale/imx8mm-engicam-edimm2.2.dtsi | 7 +++++++ > > > > .../freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 21 +++++++++++++++++++ > > > > 3 files changed, 29 insertions(+) > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > > > > index 8d49a2c74604..43783076f856 100644 > > > > --- a/arch/arm64/boot/dts/freescale/Makefile > > > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > > > @@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb > > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > > > new file mode 100644 > > > > index 000000000000..294df07289a2 > > > > --- /dev/null > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > > > @@ -0,0 +1,7 @@ > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > > +/* > > > > + * Copyright (c) 2020 Engicam srl > > > > + * Copyright (c) 2020 Amarula Solutions(India) > > > > + */ > > > > + > > > > +#include "imx8mm-engicam-common.dtsi" > > > > > > It seems you ignored my comments from previous email. That's not how we > > > go with the process. > > > > > > Don't create confusing or overcomplicated hierarchy of includes. Don't > > > create files which do nothing. > > > > Idea is to move common nodes in separate dtsi instead of adding > > redundant nodes into respective areas. let me know if it still > > confusing. > > A file which *only* includes another file does not fulfill this idea of > moving common nodes to a separate DTSI file. Or if I still miss > something, please point me, what common nodes are stored in > imx8mm-engicam-edimm2.2.dtsi? imx8mm-engicam-edimm2.2.dtsi for EDIMM2.2 Carrier imx8mm-engicam-ctouch2.dtsi for C.TOUCH2 Carrier imx8mm-engicam-common.dtsi for common nodes for above 2 carrier boards. Yes, imx8mm-engicam-edimm2.2.dtsi is empty now but nodes like PCIe, CSI, DSI will support once the respective drivers are part of Mainline but those are not supported in C.TOUCH2 carrier board dtsi. There are some GPIO pins differences between EDIMM2.2 and C.TOUCH2 carriers on WiFi/BT so those will be part of the respective carrier dtsi. Hope this would clear. Jagan. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel