From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E32CC433E1 for ; Thu, 23 Jul 2020 06:34:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3BCBE206E3 for ; Thu, 23 Jul 2020 06:34:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="rkKiIc4b" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726716AbgGWGe1 (ORCPT ); Thu, 23 Jul 2020 02:34:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725843AbgGWGe0 (ORCPT ); Thu, 23 Jul 2020 02:34:26 -0400 Received: from mail-ej1-x641.google.com (mail-ej1-x641.google.com [IPv6:2a00:1450:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74547C0619E2 for ; Wed, 22 Jul 2020 23:34:25 -0700 (PDT) Received: by mail-ej1-x641.google.com with SMTP id o18so5126790eje.7 for ; Wed, 22 Jul 2020 23:34:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YHBydU8vIOvimRwIQ4AVmmdC0WTsfc4hrzMrtnp6v40=; b=rkKiIc4bIcWziclAnuygl88kLrosymEFhyaR5U3rtuhiQbRhU/oG9QfgSw6A9Ons5p UATja2ojOHWqBgsAldLe/SfxOn3rNlg0RYcHhV+SvOb1w+Zy3Do086g2y+175lAWp6r2 oEaQbXci13z0gFCVVQAYjUiwdjjx7wso13jrM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YHBydU8vIOvimRwIQ4AVmmdC0WTsfc4hrzMrtnp6v40=; b=Y3JtaQotXS5qI67oALe6JtZ3ij7zpfL1H65UhwQ/SU7F17bySPtQL0mykHNWYMjgGM 4w3seiBF2tuvN+dTCHxH3RnHaVCE8WGP5cU+mvdQEPJ4BVR3OvgRyXHdwunYQU+ykOFS RbaX1yHhUc73wVt7zidLTh3w44LEBR5ggN7uVeVPxzEno8ss5XsbKA/43c+G/BnpmvIb lN8aBNDOxfpldXgD0fKXijP5dCNaZZpglRoeprdhl/z2SdFIEm1FFXZY4oK9PgWdFDuB ussEWpILbT+FR1Eth6h7zlj4wvR9WFp1vVkvXGq4S3BysevqYrZN1qWhD8J7cmFAUBbY rWoQ== X-Gm-Message-State: AOAM530TT3FIBOpIY4EW4+9pUShoqULU6lXE45kEtsuSJciwT9W4E9sa QUszIFqvDwVr58Hy5PTnGPz/E2zO+cZh3LjpZJAxtQ== X-Google-Smtp-Source: ABdhPJxsyATkUuOcnQe0rXO2IGjkjtHk9Fd38vKQTVik9MvcczWGbe4wq7L/G9FA2hVRAHtaDc0LvXdPYIpmPCd4id0= X-Received: by 2002:a17:906:e46:: with SMTP id q6mr2058869eji.234.1595486063946; Wed, 22 Jul 2020 23:34:23 -0700 (PDT) MIME-Version: 1.0 References: <20200722190949.215656-1-jagan@amarulasolutions.com> <20200722190949.215656-3-jagan@amarulasolutions.com> <3893924.cuH9TW0V3R@phil> In-Reply-To: <3893924.cuH9TW0V3R@phil> From: Jagan Teki Date: Thu, 23 Jul 2020 12:04:12 +0530 Message-ID: Subject: Re: [PATCH v2 3/6] dt-bindings: arm: rockchip: Add ROCKPi 4B binding To: Heiko Stuebner Cc: Rob Herring , Suniel Mahesh , Michael Trimarchi , linux-arm-kernel , "open list:ARM/Rockchip SoC..." , devicetree , linux-kernel , linux-amarula Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko, On Thu, Jul 23, 2020 at 4:43 AM Heiko Stuebner wrote: > > Hi Jagan, > > Am Mittwoch, 22. Juli 2020, 21:09:46 CEST schrieb Jagan Teki: > > Add dt-bindings for ROCKPi 4B which is similar to 4A with > > additional AP6256 Wifi/BT, PoE. > > > > Signed-off-by: Jagan Teki > > --- > > Changes for v2: > > - new patch > > > > Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > > index 36057c9e4b83..7250adb43d24 100644 > > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > > @@ -448,6 +448,12 @@ properties: > > - const: radxa,rockpi4a > > - const: rockchip,rk3399 > > > > + - description: Radxa ROCK Pi 4B > > + items: > > + - const: radxa,rockpi4 > > + - const: radxa,rockpi4b > > + - const: rockchip,rk3399 > > + > > Please do all RockPi4 variants into one entry, so we want something like: > > - description: Radxa ROCK Pi 4 What if the description has something like below. - description: Radxa ROCK Pi 4A/B/C Jagan. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jagan Teki Subject: Re: [PATCH v2 3/6] dt-bindings: arm: rockchip: Add ROCKPi 4B binding Date: Thu, 23 Jul 2020 12:04:12 +0530 Message-ID: References: <20200722190949.215656-1-jagan@amarulasolutions.com> <20200722190949.215656-3-jagan@amarulasolutions.com> <3893924.cuH9TW0V3R@phil> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <3893924.cuH9TW0V3R@phil> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Heiko Stuebner Cc: Rob Herring , Suniel Mahesh , Michael Trimarchi , linux-arm-kernel , "open list:ARM/Rockchip SoC..." , devicetree , linux-kernel , linux-amarula List-Id: linux-rockchip.vger.kernel.org Hi Heiko, On Thu, Jul 23, 2020 at 4:43 AM Heiko Stuebner wrote: > > Hi Jagan, > > Am Mittwoch, 22. Juli 2020, 21:09:46 CEST schrieb Jagan Teki: > > Add dt-bindings for ROCKPi 4B which is similar to 4A with > > additional AP6256 Wifi/BT, PoE. > > > > Signed-off-by: Jagan Teki > > --- > > Changes for v2: > > - new patch > > > > Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > > index 36057c9e4b83..7250adb43d24 100644 > > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > > @@ -448,6 +448,12 @@ properties: > > - const: radxa,rockpi4a > > - const: rockchip,rk3399 > > > > + - description: Radxa ROCK Pi 4B > > + items: > > + - const: radxa,rockpi4 > > + - const: radxa,rockpi4b > > + - const: rockchip,rk3399 > > + > > Please do all RockPi4 variants into one entry, so we want something like: > > - description: Radxa ROCK Pi 4 What if the description has something like below. - description: Radxa ROCK Pi 4A/B/C Jagan. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA13FC433E1 for ; Thu, 23 Jul 2020 06:36:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 763F8206D7 for ; Thu, 23 Jul 2020 06:36:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UibiUXVV"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="rkKiIc4b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 763F8206D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WINmwkUtgxOuyEskymLeMnxJXK8fPspYbjv6IgtzffI=; b=UibiUXVVCORFDibG3yeEoHXSw z9kFp2haf+O0Vmk+zPkG9gbcpOmmT4m4nWgLp3kvNNVzoCf1rVW/EAM9Bl8VuU+2OZoSsooWjZlXI GxhxiciW48Hf6YWhpAi6YTwP+EYr687yJ8JEroYz0BkrUJlQSC4rp6LIXZo1eIn456cjEzHMHWACm gt9T21qdiSxL6VQ24HwLqh07sNatyF/DtAeAqp9iaTDV1hyl4BMOBiLT4cOTNWPg340mbE1Ml6GMv UXqF6cRRt/j2VJjSQStjfJrUzZ8n+gDK8DtUgyRKqGqSVFP/etB3dbudgLsLJ/hyiYPitWWwhTxar SqkOuc9XQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyUoJ-0007Pf-Pm; Thu, 23 Jul 2020 06:34:31 +0000 Received: from mail-ej1-x644.google.com ([2a00:1450:4864:20::644]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyUoE-0007OB-2K for linux-arm-kernel@lists.infradead.org; Thu, 23 Jul 2020 06:34:29 +0000 Received: by mail-ej1-x644.google.com with SMTP id a21so5129537ejj.10 for ; Wed, 22 Jul 2020 23:34:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YHBydU8vIOvimRwIQ4AVmmdC0WTsfc4hrzMrtnp6v40=; b=rkKiIc4bIcWziclAnuygl88kLrosymEFhyaR5U3rtuhiQbRhU/oG9QfgSw6A9Ons5p UATja2ojOHWqBgsAldLe/SfxOn3rNlg0RYcHhV+SvOb1w+Zy3Do086g2y+175lAWp6r2 oEaQbXci13z0gFCVVQAYjUiwdjjx7wso13jrM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YHBydU8vIOvimRwIQ4AVmmdC0WTsfc4hrzMrtnp6v40=; b=CaSxXF9ybE4XGFusC9j5cd1X79OWKvMJhkmj/5CE8zrKTjMOXoppHB2pNS6IvW9iXC f7Wa59UhSGKI+jc+q5VAJKiaYxANi1hqsjz0T3T2p7hFnwbRl6HcMTJe9NAIZbywxmW6 fr3SEXCnAMGDJgVNIEqHDqL6KBZaL8jFsAeV4CSVWciaPerpuzRXTane2+6jImvenKXD 93zlMOn3AnOIdZBsDGujofHmnxykNw5V4hvnJoVNLopolP1fjCus0RifyHsYzSj3zRn9 JsrBql/GNq8qCEe/goTBlIEOTq7DEh/GkJR8qz1SknCWEKABrbIj0ZOmmhLqjKfeNHz7 5dkQ== X-Gm-Message-State: AOAM532gW1SuioOcfeIqJiVQLZAngZ91/jQsKY1tcAoAjigALgvk8R/K n3e0mbOf+5/U12knlJegr5pt6DX64iRgpazdRDm90w== X-Google-Smtp-Source: ABdhPJxsyATkUuOcnQe0rXO2IGjkjtHk9Fd38vKQTVik9MvcczWGbe4wq7L/G9FA2hVRAHtaDc0LvXdPYIpmPCd4id0= X-Received: by 2002:a17:906:e46:: with SMTP id q6mr2058869eji.234.1595486063946; Wed, 22 Jul 2020 23:34:23 -0700 (PDT) MIME-Version: 1.0 References: <20200722190949.215656-1-jagan@amarulasolutions.com> <20200722190949.215656-3-jagan@amarulasolutions.com> <3893924.cuH9TW0V3R@phil> In-Reply-To: <3893924.cuH9TW0V3R@phil> From: Jagan Teki Date: Thu, 23 Jul 2020 12:04:12 +0530 Message-ID: Subject: Re: [PATCH v2 3/6] dt-bindings: arm: rockchip: Add ROCKPi 4B binding To: Heiko Stuebner X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200723_023426_423462_C51102CC X-CRM114-Status: GOOD ( 15.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , linux-kernel , "open list:ARM/Rockchip SoC..." , Rob Herring , Suniel Mahesh , Michael Trimarchi , linux-amarula , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Heiko, On Thu, Jul 23, 2020 at 4:43 AM Heiko Stuebner wrote: > > Hi Jagan, > > Am Mittwoch, 22. Juli 2020, 21:09:46 CEST schrieb Jagan Teki: > > Add dt-bindings for ROCKPi 4B which is similar to 4A with > > additional AP6256 Wifi/BT, PoE. > > > > Signed-off-by: Jagan Teki > > --- > > Changes for v2: > > - new patch > > > > Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > > index 36057c9e4b83..7250adb43d24 100644 > > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > > @@ -448,6 +448,12 @@ properties: > > - const: radxa,rockpi4a > > - const: rockchip,rk3399 > > > > + - description: Radxa ROCK Pi 4B > > + items: > > + - const: radxa,rockpi4 > > + - const: radxa,rockpi4b > > + - const: rockchip,rk3399 > > + > > Please do all RockPi4 variants into one entry, so we want something like: > > - description: Radxa ROCK Pi 4 What if the description has something like below. - description: Radxa ROCK Pi 4A/B/C Jagan. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel