From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jagan Teki Date: Tue, 9 Apr 2019 00:41:48 +0530 Subject: [U-Boot] arm: sunxi: Bananapi_M2_Ultra not working with DM_MMC In-Reply-To: <20190408190951.GA4664@bill-the-cat> References: <20190408182643.GY4664@bill-the-cat> <20190408184907.GZ4664@bill-the-cat> <20190408190951.GA4664@bill-the-cat> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: u-boot@lists.denx.de On Tue, Apr 9, 2019 at 12:39 AM Tom Rini wrote: > > On Tue, Apr 09, 2019 at 12:37:04AM +0530, Jagan Teki wrote: > > Hi Tom, > > > > On Tue, Apr 9, 2019 at 12:19 AM Tom Rini wrote: > > > > > > On Tue, Apr 09, 2019 at 12:17:15AM +0530, Jagan Teki wrote: > > > > On Tue, Apr 9, 2019 at 12:02 AM Michael Nazzareno Trimarchi > > > > wrote: > > > > > > > > > > Hi jagan > > > > > > > > > > > > > > > On Mon., 8 Apr. 2019, 8:26 pm Tom Rini, wrot= e: > > > > >> > > > > >> On Mon, Apr 08, 2019 at 06:23:29PM +0530, Jagan Teki wrote: > > > > >> > Hi Paul, > > > > >> > > > > > >> > On Mon, Apr 8, 2019 at 6:00 PM Paul Kocialkowski > > > > >> > wrote: > > > > >> > > > > > > >> > > Hi, > > > > >> > > > > > > >> > > On Thu, 2019-04-04 at 05:51 -0300, Pablo Sebasti=C3=A1n Grec= o wrote: > > > > >> > > > A few days ago I tried to boot my Bananapi_M2_Ultra with 2= 019.04rc, I > > > > >> > > > found that it wasn't booting, 2019.01 was working ok. > > > > >> > > > Bisecting indicated that the problem was after > > > > >> > > > http://git.denx.de/?p=3Du-boot.git;a=3Dcommitdiff;h=3Da7cc= a5793774ee139b75a704d6efaa4d29f09f93 > > > > >> > > > > > > >> > > I think the patch should be reverted ASAP since it obviously= breaks > > > > >> > > some supported configs. Sadly, the offending commit doesn't = say > > > > >> > > anything about the test coverage for the change and what the= status is > > > > >> > > after it. There is probably a reason why it was enabled for = sun4i only > > > > >> > > before and there must have been a motivation for doing this = on all > > > > >> > > sunxi platforms, but then again, the commit message says not= hing about > > > > >> > > those underlying reasons. > > > > >> > > > > > > >> > > I believe we should be more strict on patch review and not l= et any > > > > >> > > change bringing such a major change get applied with a commi= t message > > > > >> > > that provides no context about why the change is okay and ho= w it was > > > > >> > > tested. > > > > >> > > > > > >> > Appropriate your concern. > > > > >> > > > > > >> > If you please list what all boards are not working with this e= ffect, > > > > >> > please write back. we will defiantly look into it. All these c= hanges > > > > >> > were merged in MW which is 2.5 months back, commenting in fina= l stage > > > > >> > like this is not the professional way. > > > > >> > > > > >> Being release day, here's my big concern. How bad is this? Is = it a > > > > >> single platform? Later in the thread Jagan did enumerate the So= Cs he > > > > >> tested the overall series on. But there's a lot of Allwinner So= Cs and > > > > >> boards. I have a pine64 somewhere around here, but that's alrea= dy been > > > > >> checked off. My other allwinner platform I took out of my testi= ng loop > > > > >> due to it not being a reliable piece of hardware. So, does anyo= ne have > > > > >> a feel for how many platforms may or may not be broken right now? > > > > >> Thanks! > > > > > > > > > > > > > > > You have 13 to 15 boards. Can you just report all of them? > > > > > > > > Issue, seems to be on SCSI side. MMC is able to probe and boot (you > > > > may see initial logs on the thread). Enabling DM_MMC breaking SCSI > > > > reads, debugging same with Pablo will get back. > > > > > > OK, thanks, please keep us up to date! > > > > As expected, SCSI reads failing. DM_MMC is forcing BLK so which > > expecting boards to enable DM_SCSI. So the migration plan for DM_SCSI > > and DM_MMC should be in same line, as of now it's not. > > Ah, is the scsi driver for Allwinner DM-ified yet? And for the release > I'd really like to do today can we just switch off DM_MMC on the DM_SCSI > Allwinner platforms? Since the migration plan still there for DM_SCSI (v2019.07) we haven't enabled DM_SCSI yet.