From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD53DC433E0 for ; Wed, 24 Feb 2021 12:38:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E82E64ED6 for ; Wed, 24 Feb 2021 12:38:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233404AbhBXMil (ORCPT ); Wed, 24 Feb 2021 07:38:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233320AbhBXMih (ORCPT ); Wed, 24 Feb 2021 07:38:37 -0500 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 773B6C061574 for ; Wed, 24 Feb 2021 04:37:56 -0800 (PST) Received: by mail-ed1-x530.google.com with SMTP id c6so2327796ede.0 for ; Wed, 24 Feb 2021 04:37:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g07oglWDP6MW/sT/0KORfHFay4I08yTBqKpnsZcOxR0=; b=JkQw5OpKBkdZyh07F+JVOE82ubO8e/yH6drILRD6olCknp04OYbWD4oNqMHuM/UjK7 +zBfNqPxRal7XD1E0ebOlxQAfduFI6Nn9+JmjgCYDPZg4HrB9UR3emBLUwvTq68oONb0 9DnsGxRqNiIwUq3wwJU0Ww3mcInwW+P7LtdMY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g07oglWDP6MW/sT/0KORfHFay4I08yTBqKpnsZcOxR0=; b=sWMpJOdhTftjishowWjQM8LVW/rlgh8yiu4CcR1y5rxxceiol6nkzTuwZZdGsQ0ROa H3zehIH7SRErcscAkIxAeRa4DuqOd2PKIRhSrF1x+oHJ5VKzllWh+h+tQC4d1ozRRbkA cXYTvRxhL1UFhaWVK6W5z7oTnzAx8ITZxocSmyoRuVH8i1e9cWklwXNr0deaQXWvo208 3s/Ef8i5OmrPX+CO0xuWtaGZ1Vo7/4PskknFQgJGgFii+pHvhxSRBVpDs42M8d0yiyvP dG848MLWWAgz984yWrHSvFBjr8uvyPlgDZG60WRRYIplwUD/MEa7t7doa8wjSaZU+O8J 1dbg== X-Gm-Message-State: AOAM533aTAy/+Ld/R3mbrcnFMdTuCODnBtT8+T0Nf+/H3n2eJdBgMIFe EuQwgSiALysOEq4OMozpPqEsQfp/IoFaqF1d8UmhfQ== X-Google-Smtp-Source: ABdhPJyVP8jYaoGikQdL4uI2tbLxt5QZyKSbb5dZCpNiGmPPFJtjCN7iayaf+Wq/05Dty7VWud+PoyKrDNCgfqwiU/c= X-Received: by 2002:a05:6402:33a:: with SMTP id q26mr28983732edw.150.1614170275198; Wed, 24 Feb 2021 04:37:55 -0800 (PST) MIME-Version: 1.0 References: <20210214175211.105107-1-jagan@amarulasolutions.com> In-Reply-To: From: Jagan Teki Date: Wed, 24 Feb 2021 18:07:43 +0530 Message-ID: Subject: Re: [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for Chipone ICN6211 To: Laurent Pinchart Cc: Rob Herring , Andrzej Hajda , Neil Armstrong , Jonas Karlman , Jernej Skrabec , Sam Ravnborg , dri-devel , linux-kernel , devicetree , linux-amarula Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Laurent, On Mon, Feb 15, 2021 at 5:48 PM Laurent Pinchart wrote: > > Hi Jagan, > > Thank you for the patch. > > On Sun, Feb 14, 2021 at 11:22:10PM +0530, Jagan Teki wrote: > > ICN6211 is MIPI-DSI to RGB Convertor bridge from Chipone. > > > > It has a flexible configuration of MIPI DSI signal input and > > produce RGB565, RGB666, RGB888 output format. > > > > Add dt-bingings for it. > > > > Signed-off-by: Jagan Teki > > --- > > Changes for v3: > > - updated to new dt-bindings style > > > > .../display/bridge/chipone,icn6211.yaml | 90 +++++++++++++++++++ > > 1 file changed, 90 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > new file mode 100644 > > index 000000000000..13764f13fe46 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > @@ -0,0 +1,90 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/bridge/chipone,icn6211.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Chipone ICN6211 MIPI-DSI to RGB Converter bridge > > + > > +maintainers: > > + - Jagan Teki > > + > > +description: | > > + ICN6211 is MIPI-DSI to RGB Convertor bridge from chipone. > > + > > + It has a flexible configuration of MIPI DSI signal input and > > + produce RGB565, RGB666, RGB888 output format. > > How does one select between the output formats ? Should the output > connection option be described in the device tree ? I think that is a good option to select output formats via dts. what if it makes it a generic property like data-lanes? since it is common across many other bridges. > > > + > > +properties: > > + compatible: > > + enum: > > + - chipone,icn6211 > > + > > + reg: > > + maxItems: 1 > > + description: virtual channel number of a DSI peripheral > > + > > + reset-gpios: > > + description: GPIO connected for the reset pin > > + > > + ports: > > + $ref: /schemas/graph.yaml#/properties/ports > > + > > + properties: > > + port@0: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: > > + Video port for MIPI DSI input > > + > > + port@1: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: > > + Video port for MIPI DPI output (panel or connector). > > + > > + required: > > + - port@0 > > + - port@1 > > + > > +required: > > + - compatible > > + - reg > > + - reset-gpios > > + - ports > > How about regulators ? Will add it in the next version. Jagan. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ECDCC433E0 for ; Wed, 24 Feb 2021 12:37:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 31CBD64DCF for ; Wed, 24 Feb 2021 12:37:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 31CBD64DCF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 786FF6E8C2; Wed, 24 Feb 2021 12:37:57 +0000 (UTC) Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by gabe.freedesktop.org (Postfix) with ESMTPS id 825AD6E8C2 for ; Wed, 24 Feb 2021 12:37:56 +0000 (UTC) Received: by mail-ed1-x530.google.com with SMTP id l12so2297998edt.3 for ; Wed, 24 Feb 2021 04:37:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g07oglWDP6MW/sT/0KORfHFay4I08yTBqKpnsZcOxR0=; b=JkQw5OpKBkdZyh07F+JVOE82ubO8e/yH6drILRD6olCknp04OYbWD4oNqMHuM/UjK7 +zBfNqPxRal7XD1E0ebOlxQAfduFI6Nn9+JmjgCYDPZg4HrB9UR3emBLUwvTq68oONb0 9DnsGxRqNiIwUq3wwJU0Ww3mcInwW+P7LtdMY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g07oglWDP6MW/sT/0KORfHFay4I08yTBqKpnsZcOxR0=; b=UwpkzkVZBL/leSYzQV/zcNftWORBTqgfPnTq5GlWpTH0+WqJueS7CbOEPsyaZ0mBKO r21sauvPxcLFUseJEB5MEyvo5ed1BZZRPSk834JuHhaHPV0A6d+aJ424E1shJBXdZ95M Dob7kPAD4kFwPrd0+6lgWIOdDR/u9C7LJEVIrs0qJ8qgZvkLrskwIJ/T2wKI+nNZCaAF R3HFlqDAzdvNUm0S7nMQeogYUt0Oh5fBYvXf6+c0N5BeQk6s9rfgr7aA3lnvquE2rlzc 9L+EnRTDT9t0ioqWeOre2pOq58Pz+EDOWmaKO383+UdscV8jDNOyjqJzGH4YtaJ3SIF1 DyJQ== X-Gm-Message-State: AOAM533mJz1LGUiHf7lLI8voOdS+TEj7CCsozrJSunhrZIqWOlpyKYN/ lRMdF7ogqfBk1mdqQcp0dXewKSFcyU28xrq21XzOIw== X-Google-Smtp-Source: ABdhPJyVP8jYaoGikQdL4uI2tbLxt5QZyKSbb5dZCpNiGmPPFJtjCN7iayaf+Wq/05Dty7VWud+PoyKrDNCgfqwiU/c= X-Received: by 2002:a05:6402:33a:: with SMTP id q26mr28983732edw.150.1614170275198; Wed, 24 Feb 2021 04:37:55 -0800 (PST) MIME-Version: 1.0 References: <20210214175211.105107-1-jagan@amarulasolutions.com> In-Reply-To: From: Jagan Teki Date: Wed, 24 Feb 2021 18:07:43 +0530 Message-ID: Subject: Re: [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for Chipone ICN6211 To: Laurent Pinchart X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Jernej Skrabec , Jonas Karlman , linux-amarula , Neil Armstrong , linux-kernel , dri-devel , Andrzej Hajda , Rob Herring , Sam Ravnborg Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Laurent, On Mon, Feb 15, 2021 at 5:48 PM Laurent Pinchart wrote: > > Hi Jagan, > > Thank you for the patch. > > On Sun, Feb 14, 2021 at 11:22:10PM +0530, Jagan Teki wrote: > > ICN6211 is MIPI-DSI to RGB Convertor bridge from Chipone. > > > > It has a flexible configuration of MIPI DSI signal input and > > produce RGB565, RGB666, RGB888 output format. > > > > Add dt-bingings for it. > > > > Signed-off-by: Jagan Teki > > --- > > Changes for v3: > > - updated to new dt-bindings style > > > > .../display/bridge/chipone,icn6211.yaml | 90 +++++++++++++++++++ > > 1 file changed, 90 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > new file mode 100644 > > index 000000000000..13764f13fe46 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > @@ -0,0 +1,90 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/bridge/chipone,icn6211.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Chipone ICN6211 MIPI-DSI to RGB Converter bridge > > + > > +maintainers: > > + - Jagan Teki > > + > > +description: | > > + ICN6211 is MIPI-DSI to RGB Convertor bridge from chipone. > > + > > + It has a flexible configuration of MIPI DSI signal input and > > + produce RGB565, RGB666, RGB888 output format. > > How does one select between the output formats ? Should the output > connection option be described in the device tree ? I think that is a good option to select output formats via dts. what if it makes it a generic property like data-lanes? since it is common across many other bridges. > > > + > > +properties: > > + compatible: > > + enum: > > + - chipone,icn6211 > > + > > + reg: > > + maxItems: 1 > > + description: virtual channel number of a DSI peripheral > > + > > + reset-gpios: > > + description: GPIO connected for the reset pin > > + > > + ports: > > + $ref: /schemas/graph.yaml#/properties/ports > > + > > + properties: > > + port@0: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: > > + Video port for MIPI DSI input > > + > > + port@1: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: > > + Video port for MIPI DPI output (panel or connector). > > + > > + required: > > + - port@0 > > + - port@1 > > + > > +required: > > + - compatible > > + - reg > > + - reset-gpios > > + - ports > > How about regulators ? Will add it in the next version. Jagan. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel