From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C548870 for ; Tue, 6 Jul 2021 14:26:37 +0000 (UTC) Received: by mail-ed1-f47.google.com with SMTP id ch27so1844624edb.10 for ; Tue, 06 Jul 2021 07:26:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=30ds7vcJKAk7VFHs4pjMaahxEdxLGVgCw9afrUbPEuI=; b=DmKAuTARSZD+EwAuxvfa7mXlUjGuPeWQgeIwFMNDATZF1I+HzC//z6AM8qAvBzmVpL cqn53Ir9oeP5Ia7ycbG9dFW1tr4zt+ZX9Y2PYV+AlqP+4dpDgtK8rB2KTwL9fadcbfOV 3GwxlvKWovqxwHSBGhRuljDnBYoAvIXBz9IgQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=30ds7vcJKAk7VFHs4pjMaahxEdxLGVgCw9afrUbPEuI=; b=lOxWoEcfIDXaZA0ZN310FQfqVtm5FQYe0EBunug5kMcOkcxw2YIP8/esABvco5i3yb PsGw+vHNuuyfC55zJhwE0gymIlmkPQEF9GUyWAR4kF1rw/sODWrgKFvRBfdkMAQyDD/D WkN0Sf/DRVPu2bUyWsuGn/XruYAMhHgGXjFMlC6+ybhzYBn49tGpw6S1EXBwHYBkDcp2 WvLBuixqAyXfx0oWGyHqH7+ueVGjLdG8WHMSWzNzVnPSpFOY8IjkUjkNooV3LKr9b8fO 1WjAm/BEJ+AO/Sk3abCCD7KJkhdcVFA4gsvvdKLUlUNb50DJEyfY7+3MPM97VeYkx708 qrWQ== X-Gm-Message-State: AOAM533ByKU4ckJ9iTG71cpi5iGiCkYHKjYQ69MtiLDlaeJKscDctKRG ccsoqN3nB4G/L0Feokmp7Zt2Ui6052W8p2v6DVfSug== X-Google-Smtp-Source: ABdhPJzUllSTzUEXq3+Sh5VwT5lMqOCkARNSCd93avNMK5yuHs2P4quHIkbCvJVFsCMzIyIRMnnloLD266bQEdHZZKI= X-Received: by 2002:aa7:db16:: with SMTP id t22mr23084023eds.204.1625581596078; Tue, 06 Jul 2021 07:26:36 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20210705232319.15149-1-andre.przywara@arm.com> In-Reply-To: <20210705232319.15149-1-andre.przywara@arm.com> From: Jagan Teki Date: Tue, 6 Jul 2021 19:56:24 +0530 Message-ID: Subject: Re: [PATCH] cmd: ums: Enable by default for sunxi To: Andre Przywara Cc: Simon Glass , Tom Rini , Jernej Skrabec , Samuel Holland , Maxime Ripard , U-Boot-Denx , linux-sunxi@lists.linux.dev Content-Type: text/plain; charset="UTF-8" On Tue, Jul 6, 2021 at 4:53 AM Andre Przywara wrote: > > The ums command (presenting a U-Boot block device as a USB mass storage > device) is very useful for accessing eMMC devices via USB-OTG. > > At the moment we enable USB fastboot by default for Allwinner devices, > so it makes sense to do the same with USB mass storage, which is > actually more versatile and can be accessed on any USB host easily. > > Signed-off-by: Andre Przywara > --- > cmd/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/cmd/Kconfig b/cmd/Kconfig > index a9fb4eead29..7b1c96910a8 100644 > --- a/cmd/Kconfig > +++ b/cmd/Kconfig > @@ -1347,6 +1347,7 @@ config CMD_USB_MASS_STORAGE > bool "UMS usb mass storage" > select USB_FUNCTION_MASS_STORAGE > depends on BLK && USB_GADGET > + default y if ARCH_SUNXI && USB_MUSB_GADGET UMS or any secondary-emmc accessible are considered in production u-boot config instead of mainline u-boot since we have fastboot already available for this kind of purpose. This might be one of the reason not conisidered UMS by default till now, atleast on Allwinner. Thanks, Jagan. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32F64C07E96 for ; Tue, 6 Jul 2021 14:26:42 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5D3B61C1B for ; Tue, 6 Jul 2021 14:26:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5D3B61C1B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1BE5E82C72; Tue, 6 Jul 2021 16:26:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="DmKAuTAR"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CF00C82CE2; Tue, 6 Jul 2021 16:26:38 +0200 (CEST) Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5B80382C72 for ; Tue, 6 Jul 2021 16:26:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jagan@amarulasolutions.com Received: by mail-ed1-x533.google.com with SMTP id x12so28246890eds.5 for ; Tue, 06 Jul 2021 07:26:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=30ds7vcJKAk7VFHs4pjMaahxEdxLGVgCw9afrUbPEuI=; b=DmKAuTARSZD+EwAuxvfa7mXlUjGuPeWQgeIwFMNDATZF1I+HzC//z6AM8qAvBzmVpL cqn53Ir9oeP5Ia7ycbG9dFW1tr4zt+ZX9Y2PYV+AlqP+4dpDgtK8rB2KTwL9fadcbfOV 3GwxlvKWovqxwHSBGhRuljDnBYoAvIXBz9IgQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=30ds7vcJKAk7VFHs4pjMaahxEdxLGVgCw9afrUbPEuI=; b=CQNTNhIIB8koTljgfOMS7mQ6a3VhTlG6CxUzAl+Gd+siZVCzV7M9QwbsvUTZIEI8Xs H897UaIN9Br9+Uh4rLTxNfHfVJdvx/8cMEKjXPpD0IMRjsHqsKA2xrSzH309Ci2+Grnw JeWvDRGT11E61tVLEEQfJbvd24Xlsph/v8M5wxM5L0TppC/zdfFZFDBmaCufUD874hto aepeX06tjahIA5TTqF624u8pwDWLqIky7/ogF0cGB3WzIUQ9Y51774bdYEd8fC7aZRBl dGNQFiWcnDb+KuEOYshUOV1e3DBBkPrca2aID7QyvtEFZ7XuxKhMQP3f7OAaCdDF1+QR YPXQ== X-Gm-Message-State: AOAM532VIQLllSnfeNFdglMpwH3eqTF/YBCTQavkdBWS3V2KbGSaTPcx Mfw1NnIljnb8FRXtjeXkjWesMxfwkYf9ZGqYxVbDeA== X-Google-Smtp-Source: ABdhPJzUllSTzUEXq3+Sh5VwT5lMqOCkARNSCd93avNMK5yuHs2P4quHIkbCvJVFsCMzIyIRMnnloLD266bQEdHZZKI= X-Received: by 2002:aa7:db16:: with SMTP id t22mr23084023eds.204.1625581596078; Tue, 06 Jul 2021 07:26:36 -0700 (PDT) MIME-Version: 1.0 References: <20210705232319.15149-1-andre.przywara@arm.com> In-Reply-To: <20210705232319.15149-1-andre.przywara@arm.com> From: Jagan Teki Date: Tue, 6 Jul 2021 19:56:24 +0530 Message-ID: Subject: Re: [PATCH] cmd: ums: Enable by default for sunxi To: Andre Przywara Cc: Simon Glass , Tom Rini , Jernej Skrabec , Samuel Holland , Maxime Ripard , U-Boot-Denx , linux-sunxi@lists.linux.dev Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Tue, Jul 6, 2021 at 4:53 AM Andre Przywara wrote: > > The ums command (presenting a U-Boot block device as a USB mass storage > device) is very useful for accessing eMMC devices via USB-OTG. > > At the moment we enable USB fastboot by default for Allwinner devices, > so it makes sense to do the same with USB mass storage, which is > actually more versatile and can be accessed on any USB host easily. > > Signed-off-by: Andre Przywara > --- > cmd/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/cmd/Kconfig b/cmd/Kconfig > index a9fb4eead29..7b1c96910a8 100644 > --- a/cmd/Kconfig > +++ b/cmd/Kconfig > @@ -1347,6 +1347,7 @@ config CMD_USB_MASS_STORAGE > bool "UMS usb mass storage" > select USB_FUNCTION_MASS_STORAGE > depends on BLK && USB_GADGET > + default y if ARCH_SUNXI && USB_MUSB_GADGET UMS or any secondary-emmc accessible are considered in production u-boot config instead of mainline u-boot since we have fastboot already available for this kind of purpose. This might be one of the reason not conisidered UMS by default till now, atleast on Allwinner. Thanks, Jagan.