From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,URIBL_RHS_DOB autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5090BC10F0E for ; Thu, 18 Apr 2019 12:30:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 19A832183F for ; Thu, 18 Apr 2019 12:30:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="WhXE1oQl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388700AbfDRMaj (ORCPT ); Thu, 18 Apr 2019 08:30:39 -0400 Received: from mail-it1-f193.google.com ([209.85.166.193]:53192 "EHLO mail-it1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730682AbfDRMaj (ORCPT ); Thu, 18 Apr 2019 08:30:39 -0400 Received: by mail-it1-f193.google.com with SMTP id x132so3003037itf.2 for ; Thu, 18 Apr 2019 05:30:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=o+fIGS9wz6NOXPBAIJc986U9/USK2WuNFF0ivuzohWc=; b=WhXE1oQlGKA+r/jf7iL9CyTGsYpjvwAKMl8GTcScMs/zf2py/uxbNFvH34IFUwPDVl lyedz+bTe8wIfqUnT1eO9fgAh81aiE9DeC/AnbMb8LFgazmTmxo7C6R5iiTZu+BLk7R5 tAN6pCv9wfd4QYTxGWM7aPpcyfmEI+lPcuHcA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=o+fIGS9wz6NOXPBAIJc986U9/USK2WuNFF0ivuzohWc=; b=FY2nnyDacXYM6aO0ouYOQbokQ79WIkeLaFS6k2d/EhzHQ9GbGZApqiNYJQkVHo3+8Z wYadBWKb+aJZoWBNCTXwD2ArpJILwH2eRFqKvptgmWWuSb7k+IUrsqr8rTDWiNw7g5ZI ymRC1ulgPsbJ47+WyXpok0fnYL3UiTv0JtCRO3vZn3LZZRqUueuPmH+zaO6AdhtaaA3s v2RKvnnyZdaSg2K7YlAUR5jRCSMQ4+03qCpWKJD+gNhiyL9oR16BvusfDC6WelxjGuxl 4eR+UDZ1on/2hm1fe8SBuUz7d4GW5xJN0x+YaXkQejqhiF1kwIR8LmGChnpt/+NqBwHt PTsQ== X-Gm-Message-State: APjAAAXWt/bNndg9INqAn5hJN4m0NFkovr353Ex4g1hjzGupAXKJBH3c 42ydkZ/gW39Q/tMjwcgRFfLbY3up+cPVrJ1b5LWlaw== X-Google-Smtp-Source: APXvYqy5hEk1YcnrjJYBsszJ+JpNfbke8/Mekx9YcsVJP8KsmWkSxAGuWIqNs6BKU+nfWWtfAnvuTfDg2LHXY+a/VOU= X-Received: by 2002:a02:a399:: with SMTP id y25mr8322640jak.58.1555590638603; Thu, 18 Apr 2019 05:30:38 -0700 (PDT) MIME-Version: 1.0 References: <20190418083543.11695-1-jagan@amarulasolutions.com> <20190418112357.qic227rdwordmzyh@flea> In-Reply-To: <20190418112357.qic227rdwordmzyh@flea> From: Jagan Teki Date: Thu, 18 Apr 2019 18:00:27 +0530 Message-ID: Subject: Re: [PATCH v2 1/2] arm64: dts: allwinner: a64-amarula-relic: Add GT5663 CTP node To: Maxime Ripard Cc: Chen-Yu Tsai , Rob Herring , Mark Rutland , Michael Trimarchi , devicetree , linux-arm-kernel , linux-kernel , linux-amarula@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 18, 2019 at 4:54 PM Maxime Ripard wrote: > > On Thu, Apr 18, 2019 at 02:05:42PM +0530, Jagan Teki wrote: > > Add Goodix GT5663 capacitive touch controller node on > > Amarula A64-Relic board. > > > > The CTP connected to board with, > > - SDA, SCK from i2c1 > > - GPIO-LD0 as AVDD28 supply > > - PH4 gpio as interrupt pin > > - PH8 gpio as reset pin > > - X axis is inverted > > - Y axis is inverted > > > > Signed-off-by: Jagan Teki > > --- > > Changes for v2: > > - drop i2c1, bias-pull-up > > > > .../allwinner/sun50i-a64-amarula-relic.dts | 25 +++++++++++++++++++ > > 1 file changed, 25 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts > > index 3575db216016..3819ce396073 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts > > @@ -49,6 +49,24 @@ > > bias-pull-up; > > }; > > > > +&i2c1 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&i2c1_pins>; > > That's the default already Yes, and i2c1 node in sun50i-a64.dtsi is not attaching pinctrl. So I attached here. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,URIBL_RHS_DOB autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36343C10F0E for ; Thu, 18 Apr 2019 12:30:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08D7A21479 for ; Thu, 18 Apr 2019 12:30:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="K7aMi0rq"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="WhXE1oQl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08D7A21479 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SQ3ospPy3aJdIxgP0jgAyhFMJ5B1i1vEzc5W1O5G82o=; b=K7aMi0rqltDja5 f63mztz11/GM/KT7OILXeh9AiDA10spLjGOB9mg3IVqiKsFU2NmTyVGQZoSbmsb1Y6AEz3VCyBE2z A8gATcWgIYg5UYP3y6BTArmCtz7mgy+qdIqYCabCUGcQF5+jeTq2KDJQ2Wi/s41PW7X5y37Fhhm7Q dOtmQExB9rQdFQLyc7jLAFUXe9IL0aFs5S0FZ9eL7SVpyVICdjBTT4d4axSXnJHo8kjCb+ufHd1me rdJHOPg/6Am7miNYeuFKme/RPjzTVD88bjN3AwlHkhTMgT5ezl6x+nKfBUwZhDxb5Twn/t+HQf/mu 8dglZZUuW+nJG+3PSi7w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hH6Bi-0003j8-6M; Thu, 18 Apr 2019 12:30:46 +0000 Received: from mail-it1-x142.google.com ([2607:f8b0:4864:20::142]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hH6Bb-0003iH-V5 for linux-arm-kernel@lists.infradead.org; Thu, 18 Apr 2019 12:30:44 +0000 Received: by mail-it1-x142.google.com with SMTP id v8so7914546itf.0 for ; Thu, 18 Apr 2019 05:30:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=o+fIGS9wz6NOXPBAIJc986U9/USK2WuNFF0ivuzohWc=; b=WhXE1oQlGKA+r/jf7iL9CyTGsYpjvwAKMl8GTcScMs/zf2py/uxbNFvH34IFUwPDVl lyedz+bTe8wIfqUnT1eO9fgAh81aiE9DeC/AnbMb8LFgazmTmxo7C6R5iiTZu+BLk7R5 tAN6pCv9wfd4QYTxGWM7aPpcyfmEI+lPcuHcA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=o+fIGS9wz6NOXPBAIJc986U9/USK2WuNFF0ivuzohWc=; b=hjq4dnOmmc5dbqKOm9jgvnoMybmKIvDn5ksldKX81hpr0yzNqofiPjHxqV3hQlJovk zndQkVzs5zMfwTuwbw6dZTf8Q2jbMg9T8K9H6wi/n2EZApujiKHQ6UGsqpPfvFqaXw69 kwpkLrHO/hcy4zRRoodrdFZXdYA2PdfLPPcigBERqll6DQ2rpzMuECLGqP/YJ6jAhYIj uBaZ1blKMy3yzhUaPPWgNgSW6kR/VQw8h+Hbo9fBk+/o1QYVCubP5vPMIHsqiJaq4ACN V3TJSQuv49b3RVJiqO/uL1b2Rg5iqYB5hOS9Hs1w7OSjigBueQSKk/5AcdJyLnSG7UEA Y3Rg== X-Gm-Message-State: APjAAAXd5eGEeCJ0NfOvul/8ZsRaml0r07A0Rymoynptop7DV9dSm6rC LLZDqOlBDES0ECuS+qqY7tdkZcfaBgkTYTkIe3AI2g== X-Google-Smtp-Source: APXvYqy5hEk1YcnrjJYBsszJ+JpNfbke8/Mekx9YcsVJP8KsmWkSxAGuWIqNs6BKU+nfWWtfAnvuTfDg2LHXY+a/VOU= X-Received: by 2002:a02:a399:: with SMTP id y25mr8322640jak.58.1555590638603; Thu, 18 Apr 2019 05:30:38 -0700 (PDT) MIME-Version: 1.0 References: <20190418083543.11695-1-jagan@amarulasolutions.com> <20190418112357.qic227rdwordmzyh@flea> In-Reply-To: <20190418112357.qic227rdwordmzyh@flea> From: Jagan Teki Date: Thu, 18 Apr 2019 18:00:27 +0530 Message-ID: Subject: Re: [PATCH v2 1/2] arm64: dts: allwinner: a64-amarula-relic: Add GT5663 CTP node To: Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190418_053040_953822_D04723D0 X-CRM114-Status: GOOD ( 18.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , linux-kernel , Chen-Yu Tsai , Rob Herring , Michael Trimarchi , linux-amarula@amarulasolutions.com, linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 18, 2019 at 4:54 PM Maxime Ripard wrote: > > On Thu, Apr 18, 2019 at 02:05:42PM +0530, Jagan Teki wrote: > > Add Goodix GT5663 capacitive touch controller node on > > Amarula A64-Relic board. > > > > The CTP connected to board with, > > - SDA, SCK from i2c1 > > - GPIO-LD0 as AVDD28 supply > > - PH4 gpio as interrupt pin > > - PH8 gpio as reset pin > > - X axis is inverted > > - Y axis is inverted > > > > Signed-off-by: Jagan Teki > > --- > > Changes for v2: > > - drop i2c1, bias-pull-up > > > > .../allwinner/sun50i-a64-amarula-relic.dts | 25 +++++++++++++++++++ > > 1 file changed, 25 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts > > index 3575db216016..3819ce396073 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts > > @@ -49,6 +49,24 @@ > > bias-pull-up; > > }; > > > > +&i2c1 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&i2c1_pins>; > > That's the default already Yes, and i2c1 node in sun50i-a64.dtsi is not attaching pinctrl. So I attached here. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel