From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2CB3C433DB for ; Fri, 8 Jan 2021 09:07:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 87EFE22B2E for ; Fri, 8 Jan 2021 09:07:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727906AbhAHJHo (ORCPT ); Fri, 8 Jan 2021 04:07:44 -0500 Received: from mail-ot1-f42.google.com ([209.85.210.42]:36050 "EHLO mail-ot1-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727897AbhAHJHn (ORCPT ); Fri, 8 Jan 2021 04:07:43 -0500 Received: by mail-ot1-f42.google.com with SMTP id d20so9086493otl.3 for ; Fri, 08 Jan 2021 01:07:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AQJnYqfHQDSkWh7R1VxOUZVE6Es7Gkoa0MRhajtaiPU=; b=PTAIF/7ieHe3IU7PfBJOHvXocR7yfY7BH2YJfrVrHwuEjEyvDck9yz3ZUVVIIe1z4Z hSPiCLVvG7M0Hwb0HZxJP9Spbt+wlizGThQ7g2pYlXjPHurev34FV0bl5CDSAxgMcFGO /yEMdhA5G67FCw+0hMoDIx9WywBpCTZi8bA6nrI7+Cgx/6ud2YpZ3bs/c1yw4K+ytpmM NKAvGF7ShmFWR5UUBi/L9D5/pDFfRwljXBcLZpj8lhOBS67qu4TyJn6V9l05+i1lKw9N gPJUVDp3uf67PyOnwz2XrTZqZltG4L/tI861F6XQrXr87VA0z75mO3YrG6S/UKDb4a/y u1pQ== X-Gm-Message-State: AOAM531Q212mdPFBXRRgkpD9fTLCUf4LgMXQqFIfwflv+nA0eu1isL2p w78qdUWDljkEElXZkqYubNGIzATO6DfsPMvRb7kfZ0/ZRaE= X-Google-Smtp-Source: ABdhPJw8DmxcG4LNZx17jo9TIk4OpFqV5Yp2qrP5Nb2rWRaG6qSE7b6iar6Cm3JCJsYWJwQsXkjC26oIGCojtBU6eW4= X-Received: by 2002:a9d:c01:: with SMTP id 1mr1887610otr.107.1610096822578; Fri, 08 Jan 2021 01:07:02 -0800 (PST) MIME-Version: 1.0 References: <20201227121925.8431-1-wsa+renesas@sang-engineering.com> In-Reply-To: From: Geert Uytterhoeven Date: Fri, 8 Jan 2021 10:06:51 +0100 Message-ID: Subject: Re: [RFC PATCH] arm64: dts: r8a779a0: correct reset values for GPIO To: Wolfram Sang Cc: Linux-Renesas , Phong Hoang Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Wolfram, On Tue, Jan 5, 2021 at 1:19 PM Geert Uytterhoeven wrote: > On Sun, Dec 27, 2020 at 1:19 PM Wolfram Sang > wrote: > > Because the datasheet is ambigious, copy over the reset values from the > > latest BSP. > > > > Signed-off-by: Wolfram Sang > > --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi > > @@ -110,7 +110,7 @@ gpio0: gpio@e6058180 { > > interrupts = ; > > clocks = <&cpg CPG_MOD 916>; > > power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > > - resets = <&cpg 916>; > > + resets = <&cpg 1331>; > > I doubt the reset topology differs from the clock topology... > Let's hope this will be clarified in a datasheet update soon. I wrote a small test to check which reset bits reset the GPIO blocks. I can confirm the original resets values are correct, and using the bits marked PFCx in the Software Reset Registers 12/13/14 do not have any impact on the GPIO registers. So the BSP is wrong, and this patch should be dropped. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds