From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB290C28CBC for ; Sat, 9 May 2020 07:38:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A62C124953 for ; Sat, 9 May 2020 07:38:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729028AbgEIHik (ORCPT ); Sat, 9 May 2020 03:38:40 -0400 Received: from mail-oi1-f194.google.com ([209.85.167.194]:41832 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728471AbgEIHik (ORCPT ); Sat, 9 May 2020 03:38:40 -0400 Received: by mail-oi1-f194.google.com with SMTP id 19so10585048oiy.8; Sat, 09 May 2020 00:38:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9iOCtd8hInAFwZEEy5/s6oN5yN9LbAgaBCk+Pd2Zfpk=; b=Bbw7gMGmNvBOeJy7+VCtYI+VCwrgpZXeuhgBsebMAdgQDjaCS/B0bZR0L0Qj9FcyuZ vp/yZKTrk+njsHtalSUwDV+bATtkScXQbeYiZY6yPsDm0a5X71ZclR+fWpO7wIwOwhxx HU31zIQNxRhU1QHkfVzGoTiLP6yhND51flb+sdIVulFxNzxjhB0ATjsWqO9p0VwQ5e6D TIrMQ9X3zJIKd8OQNFYfirqa9XE1H+2Q1d3qnUqh8CYkjuqTtyOG5Lq/jU3LguHi7W5i TkRK9SAG1FcHpsVoqeBvyvjGYipExAOqFkRwYRxxZ20D3swUbFEp4OEgOedyhKNahf/v QCFg== X-Gm-Message-State: AGi0PuYWAylJItUjeVd0eXdRcGS6DS9Rzpvf8ZRs4rIygaOSKpkje5Cp DvakIf5IqhyW1TbC5K/tsVFodMo9PkKPvjtUUMQ= X-Google-Smtp-Source: APiQypIhzI5S6MTE2Rw2TcjkhcBXQU/2d5QohGoiHGR4xXrGldruM5LIRhRBh3PQtIrtKIqOX4QC/wsnF6RwhSrReUE= X-Received: by 2002:aca:f541:: with SMTP id t62mr12715510oih.148.1589009919549; Sat, 09 May 2020 00:38:39 -0700 (PDT) MIME-Version: 1.0 References: <20200508223216.6611-1-f.fainelli@gmail.com> In-Reply-To: <20200508223216.6611-1-f.fainelli@gmail.com> From: Geert Uytterhoeven Date: Sat, 9 May 2020 09:38:28 +0200 Message-ID: Subject: Re: [PATCH net] net: broadcom: Imply BROADCOM_PHY for BCMGENET To: Florian Fainelli Cc: netdev , Nicolas Saenz Julienne , Stefan Wahren , Marek Szyprowski , "David S. Miller" , Thomas Gleixner , Tal Gilboa , Michael Chan , Andy Gospodarek , Randy Dunlap , open list Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Florian, Thanks for your patch! On Sat, May 9, 2020 at 12:32 AM Florian Fainelli wrote: > The GENET controller on the Raspberry Pi 4 (2711) is typically > interfaced with an external Broadcom PHY via a RGMII electrical > interface. To make sure that delays are properly configured at the PHY > side, ensure that we get a chance to have the dedicated Broadcom PHY > driver (CONFIG_BROADCOM_PHY) enabled for this to happen. I guess it can be interfaced to a different external PHY, too? > Fixes: 402482a6a78e ("net: bcmgenet: Clear ID_MODE_DIS in EXT_RGMII_OOB_CTRL when not needed") > Reported-by: Marek Szyprowski > Signed-off-by: Florian Fainelli > --- a/drivers/net/ethernet/broadcom/Kconfig > +++ b/drivers/net/ethernet/broadcom/Kconfig > @@ -69,6 +69,7 @@ config BCMGENET > select BCM7XXX_PHY > select MDIO_BCM_UNIMAC > select DIMLIB > + imply BROADCOM_PHY if ARCH_BCM2835 Which means support for the BROADCOM_PHY is always included on ARCH_BCM2835, even if a different PHY is used? > help > This driver supports the built-in Ethernet MACs found in the > Broadcom BCM7xxx Set Top Box family chipset. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds