All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	Alexandre Courbot <acourbot@nvidia.com>,
	stable <stable@vger.kernel.org>
Subject: Re: [PATCH] gpio: Fix OF build problem on UM
Date: Wed, 17 Aug 2016 11:03:02 +0200	[thread overview]
Message-ID: <CAMuHMdU3j6_sye_WqKgcReD+Nym-2=ymEh98D50nD2jEifOXRQ@mail.gmail.com> (raw)
In-Reply-To: <1471334801-2814-1-git-send-email-linus.walleij@linaro.org>

On Tue, Aug 16, 2016 at 10:06 AM, Linus Walleij
<linus.walleij@linaro.org> wrote:
> The UserMode (UM) Linux build was failing in gpiolib-of as it requires
> ioremap()/iounmap() to exist, which is absent from UM. The non-existence
> of IO memory is negatively defined as CONFIG_NO_IOMEM so put a reverse
> dependency on !NO_IOMEM for OF_GPIO to fix the build.
>
> Cc: stable@vger.kernel.org
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  drivers/gpio/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 98dd47a30fc7..a6026f2fe7f5 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -50,6 +50,7 @@ config GPIO_DEVRES
>  config OF_GPIO
>         def_bool y
>         depends on OF
> +       depends on !NO_IOMEM

depends on HAS_IOMEM?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2016-08-17  9:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-16  8:06 [PATCH] gpio: Fix OF build problem on UM Linus Walleij
2016-08-17  9:03 ` Geert Uytterhoeven [this message]
2016-08-19  8:53   ` Linus Walleij
2016-08-19  9:16     ` Geert Uytterhoeven
2016-08-19 12:53       ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdU3j6_sye_WqKgcReD+Nym-2=ymEh98D50nD2jEifOXRQ@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=acourbot@nvidia.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.