From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C500C43460 for ; Tue, 6 Apr 2021 10:32:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F1C2613A9 for ; Tue, 6 Apr 2021 10:32:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233117AbhDFKcd convert rfc822-to-8bit (ORCPT ); Tue, 6 Apr 2021 06:32:33 -0400 Received: from mail-vk1-f169.google.com ([209.85.221.169]:39891 "EHLO mail-vk1-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233025AbhDFKcc (ORCPT ); Tue, 6 Apr 2021 06:32:32 -0400 Received: by mail-vk1-f169.google.com with SMTP id c5so3067501vkm.6; Tue, 06 Apr 2021 03:32:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Ad26/T6d/ZnNr0Tc5NnJUf1s5ObiAcmgTWkpXBwrq1s=; b=YXwyiDAAm0rPSpsZg95ioR95mBA8TPbyquvhtOMdHdY6vVgh1e4CIsDPuarHmRBS3l 30fBawZq2JJK00v9NFUjXvpuk3UYcg79cEDhlT4R7bvXrVa6XgUD1jU59KI/1aTJvTIY akDa4JJWAFA7/e3id8HBJOqE2S7nzWX02f0qH4LWGhHY8zQzzkJ6InyMRP+RMO7ypkKQ bkcHQ1gvn9AvFvyx8csrgB7iGphxMXr9/8Ja703Qhu0M0pj0nFONJb2i01gZy0mMfmuF 2JEs7TBX1QeS0FVUFD2y2emiNoPygpIqSlGJfAe7zGpScrkMRw+/myEMCx0/Y2BHZ+wL A0tw== X-Gm-Message-State: AOAM530DYT9VGjGJpYHOryw+SMIon5ADWHKZz7BjcQsw+jYtIITbDDc9 x8h0lRDCt4y/BBBbWEWhYiDr5sVwbtkqkKgJhYA= X-Google-Smtp-Source: ABdhPJy1swYAK/t2TkG9rGJSNoiYM20SgQO0c4AaA+qpOekp59c92sXbMIYRR9yEXm+63bCKT7TrhAbrySdgxepVyHQ= X-Received: by 2002:ac5:ce04:: with SMTP id j4mr15807523vki.1.1617705144686; Tue, 06 Apr 2021 03:32:24 -0700 (PDT) MIME-Version: 1.0 References: <20210406093557.1073423-1-maz@kernel.org> <20210406093557.1073423-5-maz@kernel.org> In-Reply-To: <20210406093557.1073423-5-maz@kernel.org> From: Geert Uytterhoeven Date: Tue, 6 Apr 2021 12:32:13 +0200 Message-ID: Subject: Re: [PATCH 4/9] sh: intc: Drop the use of irq_create_identity_mapping() To: Marc Zyngier Cc: Linux ARM , Linux Kernel Mailing List , "open list:BROADCOM NVRAM DRIVER" , linuxppc-dev , Linux-sh list , Daniel Mack , Robert Jarzmik , Haojian Zhuang , Yoshinori Sato , Rich Felker , Thomas Bogendoerfer , Michael Ellerman , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org Hi Marc, On Tue, Apr 6, 2021 at 11:44 AM Marc Zyngier wrote: > Instead of playing games with using irq_create_identity_mapping() > and irq_domain_associate(), drop the use of the former and only > use the latter, together with the allocation of the irq_desc > as needed. > > It doesn't make the code less awful, but at least the intent > is clearer. > > Signed-off-by: Marc Zyngier Thanks for your patch! > --- a/drivers/sh/intc/core.c > +++ b/drivers/sh/intc/core.c > @@ -179,6 +179,23 @@ static unsigned int __init save_reg(struct intc_desc_int *d, > return 0; > } > > +static bool __init intc_map(struct irq_domain *domain, int irq) > +{ > + int res; warning: unused variable ‘res’ [-Wunused-variable] > + > + if (!irq_to_desc(irq) && irq_alloc_desc_at(irq, NUMA_NO_NODE) != irq) { > + pr_err("uname to allocate IRQ %d\n", irq); > + return false; > + } > + > + if (irq_domain_associate(domain, irq, irq)) { > + pr_err("domain association failure\n"); > + return false; > + } > + > + return true; > +} > + > int __init register_intc_controller(struct intc_desc *desc) > { > unsigned int i, k, smp; > @@ -316,19 +333,8 @@ int __init register_intc_controller(struct intc_desc *desc) warning: unused variable ‘res’ [-Wunused-variable] > if (!vect->enum_id) > continue; > > - res = irq_create_identity_mapping(d->domain, irq); > - if (unlikely(res)) { > - if (res == -EEXIST) { > - res = irq_domain_associate(d->domain, irq, irq); > - if (unlikely(res)) { > - pr_err("domain association failure\n"); > - continue; > - } > - } else { > - pr_err("can't identity map IRQ %d\n", irq); > - continue; > - } > - } > + if (!intc_map(d->domain, irq)) > + continue; > > intc_irq_xlate_set(irq, vect->enum_id, d); > intc_register_irq(desc, d, vect->enum_id, irq); Otherwise this seems to work fine on real hardware (landisk) and qemu (rts7751r2d). I did verify that the new function intc_map() is called. Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A56FEC433B4 for ; Tue, 6 Apr 2021 10:32:51 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 62B52613AE for ; Tue, 6 Apr 2021 10:32:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 62B52613AE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FF3km5Brkz3bt0 for ; Tue, 6 Apr 2021 20:32:48 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.221.178; helo=mail-vk1-f178.google.com; envelope-from=geert.uytterhoeven@gmail.com; receiver=) Received: from mail-vk1-f178.google.com (mail-vk1-f178.google.com [209.85.221.178]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FF3kP3TZKz301B for ; Tue, 6 Apr 2021 20:32:28 +1000 (AEST) Received: by mail-vk1-f178.google.com with SMTP id s136so3079332vks.4 for ; Tue, 06 Apr 2021 03:32:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Ad26/T6d/ZnNr0Tc5NnJUf1s5ObiAcmgTWkpXBwrq1s=; b=USMoFUm2FyNJKKkm8vG53gDBb+nVkxIw5EhWVfmLqsXl8BzStxZte6xSXZiVjuAdbF Aj/KV7ukIrYiMqAkuZqnRz4xXlK5Ll3oIdSEBbrTkpvFsjtNZmQcE1fHZyDaK1PqSg87 Eg7d7WoQOEPq/gzYfGjFmiZ1t9HxZhg3UWqxd0MpnVM5XOdMm64MhDRe5jx9zj67MIxA y9X4hm45fmFMQUmx3ANYq8rUjwEIJLkqTsLWhLy7rFMKhSMugNJNPcTTqQoDjlVAI3Za F5BKYEcOtMlx+BBekflWj8fMxfDIvWLBEbNonI3v8z5UydRdN4svtg51knpycuxs5Ej3 s5VA== X-Gm-Message-State: AOAM530VhNwhKldKwyub7nVx1rhj1LSxmGRLcZxJz0EMAIezHzxrO6U+ WGFPm10J/8Ff/UgAlQMwD8sCeES4KCQR0gRMOxg= X-Google-Smtp-Source: ABdhPJy1swYAK/t2TkG9rGJSNoiYM20SgQO0c4AaA+qpOekp59c92sXbMIYRR9yEXm+63bCKT7TrhAbrySdgxepVyHQ= X-Received: by 2002:ac5:ce04:: with SMTP id j4mr15807523vki.1.1617705144686; Tue, 06 Apr 2021 03:32:24 -0700 (PDT) MIME-Version: 1.0 References: <20210406093557.1073423-1-maz@kernel.org> <20210406093557.1073423-5-maz@kernel.org> In-Reply-To: <20210406093557.1073423-5-maz@kernel.org> From: Geert Uytterhoeven Date: Tue, 6 Apr 2021 12:32:13 +0200 Message-ID: Subject: Re: [PATCH 4/9] sh: intc: Drop the use of irq_create_identity_mapping() To: Marc Zyngier Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , Yoshinori Sato , Linux-sh list , Robert Jarzmik , Linux Kernel Mailing List , Haojian Zhuang , "open list:BROADCOM NVRAM DRIVER" , Thomas Bogendoerfer , Linux ARM , Thomas Gleixner , linuxppc-dev , Daniel Mack Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Marc, On Tue, Apr 6, 2021 at 11:44 AM Marc Zyngier wrote: > Instead of playing games with using irq_create_identity_mapping() > and irq_domain_associate(), drop the use of the former and only > use the latter, together with the allocation of the irq_desc > as needed. > > It doesn't make the code less awful, but at least the intent > is clearer. > > Signed-off-by: Marc Zyngier Thanks for your patch! > --- a/drivers/sh/intc/core.c > +++ b/drivers/sh/intc/core.c > @@ -179,6 +179,23 @@ static unsigned int __init save_reg(struct intc_desc= _int *d, > return 0; > } > > +static bool __init intc_map(struct irq_domain *domain, int irq) > +{ > + int res; warning: unused variable =E2=80=98res=E2=80=99 [-Wunused-variable] > + > + if (!irq_to_desc(irq) && irq_alloc_desc_at(irq, NUMA_NO_NODE) != =3D irq) { > + pr_err("uname to allocate IRQ %d\n", irq); > + return false; > + } > + > + if (irq_domain_associate(domain, irq, irq)) { > + pr_err("domain association failure\n"); > + return false; > + } > + > + return true; > +} > + > int __init register_intc_controller(struct intc_desc *desc) > { > unsigned int i, k, smp; > @@ -316,19 +333,8 @@ int __init register_intc_controller(struct intc_desc= *desc) warning: unused variable =E2=80=98res=E2=80=99 [-Wunused-variable] > if (!vect->enum_id) > continue; > > - res =3D irq_create_identity_mapping(d->domain, irq); > - if (unlikely(res)) { > - if (res =3D=3D -EEXIST) { > - res =3D irq_domain_associate(d->domain, i= rq, irq); > - if (unlikely(res)) { > - pr_err("domain association failur= e\n"); > - continue; > - } > - } else { > - pr_err("can't identity map IRQ %d\n", irq= ); > - continue; > - } > - } > + if (!intc_map(d->domain, irq)) > + continue; > > intc_irq_xlate_set(irq, vect->enum_id, d); > intc_register_irq(desc, d, vect->enum_id, irq); Otherwise this seems to work fine on real hardware (landisk) and qemu (rts7751r2d). I did verify that the new function intc_map() is called. Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DBF7C433B4 for ; Tue, 6 Apr 2021 10:34:15 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 857D4613C2 for ; Tue, 6 Apr 2021 10:34:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 857D4613C2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YXtSMjre4lGR+Kje4J2g+khwUh4Kpj0eIxnxf73APYQ=; b=BQauLOPwRW111sIsJnuOZEDkT 324Lh7z3MovJS/oE7hOhPTziauSB4WL6fOYtyLQoKuZ9RV9BlPaeMvs4gGCfRqoCzLGV2lCzPzCTK thTVshApu3Gjmw/s92VO0uL8UqKQW2A+UEc74DnJEnH1IfRZqJYdNQ+KvLwpAH62WRzpckWs/2t8G XYnWZ97jM8MKgsyqyjQCD6tr92F/yZD0OZoDrTvbWI1fIHFoaKxiPS7J0QEifAX3qsCS0ddsGGS+V xZKF9oZPEZpmIetn7IKFMbrExdfEKxRLSBnGaBxqi1qU2jInwmYZSAUPeUBrajlpT8n69mmddt3s4 o3eFy6DMA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lTj0Y-002CCp-7t; Tue, 06 Apr 2021 10:32:31 +0000 Received: from mail-vk1-f174.google.com ([209.85.221.174]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lTj0T-002CC5-Nx for linux-arm-kernel@lists.infradead.org; Tue, 06 Apr 2021 10:32:27 +0000 Received: by mail-vk1-f174.google.com with SMTP id r196so580196vkd.11 for ; Tue, 06 Apr 2021 03:32:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Ad26/T6d/ZnNr0Tc5NnJUf1s5ObiAcmgTWkpXBwrq1s=; b=EX7C9quA32WdeRNcGmZuMNfAyyC58CVMybg+ACGlUASbdSC3bHMAbE1r0dVYxK9a3b vL5WmQCm7X3rGUjMqe2xkLJwDPM3xP+YI7FY5v/OpCorn575kQCTifKwU2jVonQdBYL3 HCCavZbU2QL7TMmcqJVPu7t9m08YC2lkJDIGFgK5+B/e0PpPwzVnRWhrqVokriJHp7oG bhLpCfXWJOj3NHE81aIP1eh3GUxGak9AF19xNB0D9+Ci4c2y0fnmc2/rtyF9cGho1Nt+ ccrYHz2v0vFEIssyuY30QD00Sntz3zPpotcEnW4qgAuHsMFPAux9JOr8W5ex4/JHepmd diFA== X-Gm-Message-State: AOAM530IK3pZiNcJToZhBHjDc7V0yyJnbI/HS47T9OcRFhOFSvtmJ9v4 bG0LNX4JL0bxTGbq06t8FgdxPaD+uFgR/PhvtdNh/c0Hj/c= X-Google-Smtp-Source: ABdhPJy1swYAK/t2TkG9rGJSNoiYM20SgQO0c4AaA+qpOekp59c92sXbMIYRR9yEXm+63bCKT7TrhAbrySdgxepVyHQ= X-Received: by 2002:ac5:ce04:: with SMTP id j4mr15807523vki.1.1617705144686; Tue, 06 Apr 2021 03:32:24 -0700 (PDT) MIME-Version: 1.0 References: <20210406093557.1073423-1-maz@kernel.org> <20210406093557.1073423-5-maz@kernel.org> In-Reply-To: <20210406093557.1073423-5-maz@kernel.org> From: Geert Uytterhoeven Date: Tue, 6 Apr 2021 12:32:13 +0200 Message-ID: Subject: Re: [PATCH 4/9] sh: intc: Drop the use of irq_create_identity_mapping() To: Marc Zyngier Cc: Linux ARM , Linux Kernel Mailing List , "open list:BROADCOM NVRAM DRIVER" , linuxppc-dev , Linux-sh list , Daniel Mack , Robert Jarzmik , Haojian Zhuang , Yoshinori Sato , Rich Felker , Thomas Bogendoerfer , Michael Ellerman , Thomas Gleixner X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210406_113225_847674_CCDA74AB X-CRM114-Status: GOOD ( 24.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTWFyYywKCk9uIFR1ZSwgQXByIDYsIDIwMjEgYXQgMTE6NDQgQU0gTWFyYyBaeW5naWVyIDxt YXpAa2VybmVsLm9yZz4gd3JvdGU6Cj4gSW5zdGVhZCBvZiBwbGF5aW5nIGdhbWVzIHdpdGggdXNp bmcgaXJxX2NyZWF0ZV9pZGVudGl0eV9tYXBwaW5nKCkKPiBhbmQgaXJxX2RvbWFpbl9hc3NvY2lh dGUoKSwgZHJvcCB0aGUgdXNlIG9mIHRoZSBmb3JtZXIgYW5kIG9ubHkKPiB1c2UgdGhlIGxhdHRl ciwgdG9nZXRoZXIgd2l0aCB0aGUgYWxsb2NhdGlvbiBvZiB0aGUgaXJxX2Rlc2MKPiBhcyBuZWVk ZWQuCj4KPiBJdCBkb2Vzbid0IG1ha2UgdGhlIGNvZGUgbGVzcyBhd2Z1bCwgYnV0IGF0IGxlYXN0 IHRoZSBpbnRlbnQKPiBpcyBjbGVhcmVyLgo+Cj4gU2lnbmVkLW9mZi1ieTogTWFyYyBaeW5naWVy IDxtYXpAa2VybmVsLm9yZz4KClRoYW5rcyBmb3IgeW91ciBwYXRjaCEKCj4gLS0tIGEvZHJpdmVy cy9zaC9pbnRjL2NvcmUuYwo+ICsrKyBiL2RyaXZlcnMvc2gvaW50Yy9jb3JlLmMKPiBAQCAtMTc5 LDYgKzE3OSwyMyBAQCBzdGF0aWMgdW5zaWduZWQgaW50IF9faW5pdCBzYXZlX3JlZyhzdHJ1Y3Qg aW50Y19kZXNjX2ludCAqZCwKPiAgICAgICAgIHJldHVybiAwOwo+ICB9Cj4KPiArc3RhdGljIGJv b2wgX19pbml0IGludGNfbWFwKHN0cnVjdCBpcnFfZG9tYWluICpkb21haW4sIGludCBpcnEpCj4g K3sKPiArICAgICAgIGludCByZXM7Cgp3YXJuaW5nOiB1bnVzZWQgdmFyaWFibGUg4oCYcmVz4oCZ IFstV3VudXNlZC12YXJpYWJsZV0KCj4gKwo+ICsgICAgICAgaWYgKCFpcnFfdG9fZGVzYyhpcnEp ICYmIGlycV9hbGxvY19kZXNjX2F0KGlycSwgTlVNQV9OT19OT0RFKSAhPSBpcnEpIHsKPiArICAg ICAgICAgICAgICAgcHJfZXJyKCJ1bmFtZSB0byBhbGxvY2F0ZSBJUlEgJWRcbiIsIGlycSk7Cj4g KyAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKPiArICAgICAgIH0KPiArCj4gKyAgICAgICBp ZiAoaXJxX2RvbWFpbl9hc3NvY2lhdGUoZG9tYWluLCBpcnEsIGlycSkpIHsKPiArICAgICAgICAg ICAgICAgcHJfZXJyKCJkb21haW4gYXNzb2NpYXRpb24gZmFpbHVyZVxuIik7Cj4gKyAgICAgICAg ICAgICAgIHJldHVybiBmYWxzZTsKPiArICAgICAgIH0KPiArCj4gKyAgICAgICByZXR1cm4gdHJ1 ZTsKPiArfQo+ICsKPiAgaW50IF9faW5pdCByZWdpc3Rlcl9pbnRjX2NvbnRyb2xsZXIoc3RydWN0 IGludGNfZGVzYyAqZGVzYykKPiAgewo+ICAgICAgICAgdW5zaWduZWQgaW50IGksIGssIHNtcDsK PiBAQCAtMzE2LDE5ICszMzMsOCBAQCBpbnQgX19pbml0IHJlZ2lzdGVyX2ludGNfY29udHJvbGxl cihzdHJ1Y3QgaW50Y19kZXNjICpkZXNjKQoKd2FybmluZzogdW51c2VkIHZhcmlhYmxlIOKAmHJl c+KAmSBbLVd1bnVzZWQtdmFyaWFibGVdCgo+ICAgICAgICAgICAgICAgICBpZiAoIXZlY3QtPmVu dW1faWQpCj4gICAgICAgICAgICAgICAgICAgICAgICAgY29udGludWU7Cj4KPiAtICAgICAgICAg ICAgICAgcmVzID0gaXJxX2NyZWF0ZV9pZGVudGl0eV9tYXBwaW5nKGQtPmRvbWFpbiwgaXJxKTsK Cgo+IC0gICAgICAgICAgICAgICBpZiAodW5saWtlbHkocmVzKSkgewo+IC0gICAgICAgICAgICAg ICAgICAgICAgIGlmIChyZXMgPT0gLUVFWElTVCkgewo+IC0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgcmVzID0gaXJxX2RvbWFpbl9hc3NvY2lhdGUoZC0+ZG9tYWluLCBpcnEsIGlycSk7 Cj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpZiAodW5saWtlbHkocmVzKSkgewo+ IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwcl9lcnIoImRvbWFpbiBh c3NvY2lhdGlvbiBmYWlsdXJlXG4iKTsKPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgY29udGludWU7Cj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB9Cj4g LSAgICAgICAgICAgICAgICAgICAgICAgfSBlbHNlIHsKPiAtICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHByX2VycigiY2FuJ3QgaWRlbnRpdHkgbWFwIElSUSAlZFxuIiwgaXJxKTsKPiAt ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwo+IC0gICAgICAgICAgICAg ICAgICAgICAgIH0KPiAtICAgICAgICAgICAgICAgfQo+ICsgICAgICAgICAgICAgICBpZiAoIWlu dGNfbWFwKGQtPmRvbWFpbiwgaXJxKSkKPiArICAgICAgICAgICAgICAgICAgICAgICBjb250aW51 ZTsKPgo+ICAgICAgICAgICAgICAgICBpbnRjX2lycV94bGF0ZV9zZXQoaXJxLCB2ZWN0LT5lbnVt X2lkLCBkKTsKPiAgICAgICAgICAgICAgICAgaW50Y19yZWdpc3Rlcl9pcnEoZGVzYywgZCwgdmVj dC0+ZW51bV9pZCwgaXJxKTsKCk90aGVyd2lzZSB0aGlzIHNlZW1zIHRvIHdvcmsgZmluZSBvbiBy ZWFsIGhhcmR3YXJlIChsYW5kaXNrKSBhbmQgcWVtdQoocnRzNzc1MXIyZCkuICBJIGRpZCB2ZXJp ZnkgdGhhdCB0aGUgbmV3IGZ1bmN0aW9uIGludGNfbWFwKCkgaXMgY2FsbGVkLgoKVGVzdGVkLWJ5 OiBHZWVydCBVeXR0ZXJob2V2ZW4gPGdlZXJ0K3JlbmVzYXNAZ2xpZGVyLmJlPgoKR3J7b2V0amUs ZWV0aW5nfXMsCgogICAgICAgICAgICAgICAgICAgICAgICBHZWVydAoKLS0gCkdlZXJ0IFV5dHRl cmhvZXZlbiAtLSBUaGVyZSdzIGxvdHMgb2YgTGludXggYmV5b25kIGlhMzIgLS0gZ2VlcnRAbGlu dXgtbTY4ay5vcmcKCkluIHBlcnNvbmFsIGNvbnZlcnNhdGlvbnMgd2l0aCB0ZWNobmljYWwgcGVv cGxlLCBJIGNhbGwgbXlzZWxmIGEgaGFja2VyLiBCdXQKd2hlbiBJJ20gdGFsa2luZyB0byBqb3Vy bmFsaXN0cyBJIGp1c3Qgc2F5ICJwcm9ncmFtbWVyIiBvciBzb21ldGhpbmcgbGlrZSB0aGF0Lgog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC0tIExpbnVzIFRvcnZhbGRzCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVs IG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==