From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19AA2C47254 for ; Sat, 9 May 2020 10:38:19 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D8FF324954 for ; Sat, 9 May 2020 10:38:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8FF324954 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 47A561190036F; Sat, 9 May 2020 03:36:08 -0700 (PDT) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.167.194; helo=mail-oi1-f194.google.com; envelope-from=geert.uytterhoeven@gmail.com; receiver= Received: from mail-oi1-f194.google.com (mail-oi1-f194.google.com [209.85.167.194]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F19A71183DF2C for ; Sat, 9 May 2020 03:36:05 -0700 (PDT) Received: by mail-oi1-f194.google.com with SMTP id i13so10818641oie.9 for ; Sat, 09 May 2020 03:38:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nBe+65cgrmufPqKgCO/WJS9rGOrSoS9DaeQpyO6VPQY=; b=QxcwTtX2B0WUfHtlkrs4oKQabqEVaPAqZRZLGpAjLYSaFA+5bGBL6H4BFF9XnvY3J6 dRm7h5beH2fNL4txcqCG6gjOGiZmGXakVs1FuGyY1Luyq2vAF5wN0bwbcHmonoi6FdYS 3tBP82L02qs4awMCy2b6WYuSyKo5YwroV3laPmnw9PNkeideS3wubeoRdhAquWOczmO3 +C+0+at/SBj1cicIknHxQ+X1o3IEtAE+y5L/SAitelXPuQYfgl4ffAX8vl5EgnCesIgn fkJDN1w7lIfVkMTEmzd6Qi8835MrH5gK8R3vVtYpDH6K6rJwKG8pdEYjUpc/9IoGps4s G6bg== X-Gm-Message-State: AGi0PubbttFKR7zuVLVwdl/k3zijtOygqiqLxU7y/OsuxAHxo51MFDbc ion4IHloSxpmx4rSumxTfENhyRlBN6oiw/KY8jA= X-Google-Smtp-Source: APiQypJViR7zf1BxfE4fSiEMumUvdAfdspNngdk/6s5fr4R3Q+whgmTLapvbuOPEuAwW4U0ZD7JgMnKsLrBjVv9lPKw= X-Received: by 2002:aca:d50f:: with SMTP id m15mr13605566oig.54.1589020691722; Sat, 09 May 2020 03:38:11 -0700 (PDT) MIME-Version: 1.0 References: <20200508161517.252308-1-hch@lst.de> <20200508161517.252308-2-hch@lst.de> In-Reply-To: <20200508161517.252308-2-hch@lst.de> From: Geert Uytterhoeven Date: Sat, 9 May 2020 12:38:00 +0200 Message-ID: Subject: Re: [PATCH 01/15] nfblock: use gendisk private_data To: Christoph Hellwig Message-ID-Hash: NND6TEMQV67VODGP5BIF7OS6X46SBWA3 X-Message-ID-Hash: NND6TEMQV67VODGP5BIF7OS6X46SBWA3 X-MailFrom: geert.uytterhoeven@gmail.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: Jens Axboe , Jim Paris , Geoff Levand , Joshua Morris , Philip Kelleher , Minchan Kim , Nitin Gupta , Sergey Senozhatsky , linux-m68k , Linux Kernel Mailing List , "open list:TENSILICA XTENSA PORT (xtensa)" , Lars Ellenberg , linux-block@vger.kernel.org, linuxppc-dev , linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, "linux-nvdimm@lists.01.org" X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi Christoph, On Fri, May 8, 2020 at 6:16 PM Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig Thanks for your patch! > --- a/arch/m68k/emu/nfblock.c > +++ b/arch/m68k/emu/nfblock.c > @@ -61,7 +61,7 @@ struct nfhd_device { > > static blk_qc_t nfhd_make_request(struct request_queue *queue, struct bio *bio) > { > - struct nfhd_device *dev = queue->queuedata; > + struct nfhd_device *dev = bio->bi_disk->private_data; > struct bio_vec bvec; > struct bvec_iter iter; > int dir, len, shift; > @@ -122,7 +122,6 @@ static int __init nfhd_init_one(int id, u32 blocks, u32 bsize) > if (dev->queue == NULL) > goto free_dev; > > - dev->queue->queuedata = dev; > blk_queue_logical_block_size(dev->queue, bsize); > > dev->disk = alloc_disk(16); > @@ -136,6 +135,7 @@ static int __init nfhd_init_one(int id, u32 blocks, u32 bsize) > sprintf(dev->disk->disk_name, "nfhd%u", dev_id); > set_capacity(dev->disk, (sector_t)blocks * (bsize / 512)); > dev->disk->queue = dev->queue; > + dev->disk->private_data = dev; This is already set above, just before the quoted sprintf() call. > > add_disk(dev->disk); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH 01/15] nfblock: use gendisk private_data Date: Sat, 9 May 2020 12:38:00 +0200 Message-ID: References: <20200508161517.252308-1-hch@lst.de> <20200508161517.252308-2-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20200508161517.252308-2-hch@lst.de> Sender: linux-bcache-owner@vger.kernel.org To: Christoph Hellwig Cc: Jens Axboe , Jim Paris , Geoff Levand , Joshua Morris , Philip Kelleher , Minchan Kim , Nitin Gupta , Sergey Senozhatsky , linux-m68k , Linux Kernel Mailing List , "open list:TENSILICA XTENSA PORT (xtensa)" , Lars Ellenberg , linux-block@vger.kernel.org, linuxppc-dev , linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, "linux-nvdimm@lists.01.org" List-Id: linux-raid.ids Hi Christoph, On Fri, May 8, 2020 at 6:16 PM Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig Thanks for your patch! > --- a/arch/m68k/emu/nfblock.c > +++ b/arch/m68k/emu/nfblock.c > @@ -61,7 +61,7 @@ struct nfhd_device { > > static blk_qc_t nfhd_make_request(struct request_queue *queue, struct bio *bio) > { > - struct nfhd_device *dev = queue->queuedata; > + struct nfhd_device *dev = bio->bi_disk->private_data; > struct bio_vec bvec; > struct bvec_iter iter; > int dir, len, shift; > @@ -122,7 +122,6 @@ static int __init nfhd_init_one(int id, u32 blocks, u32 bsize) > if (dev->queue == NULL) > goto free_dev; > > - dev->queue->queuedata = dev; > blk_queue_logical_block_size(dev->queue, bsize); > > dev->disk = alloc_disk(16); > @@ -136,6 +135,7 @@ static int __init nfhd_init_one(int id, u32 blocks, u32 bsize) > sprintf(dev->disk->disk_name, "nfhd%u", dev_id); > set_capacity(dev->disk, (sector_t)blocks * (bsize / 512)); > dev->disk->queue = dev->queue; > + dev->disk->private_data = dev; This is already set above, just before the quoted sprintf() call. > > add_disk(dev->disk); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E75D8C54E49 for ; Sat, 9 May 2020 10:38:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D0A2420735 for ; Sat, 9 May 2020 10:38:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728154AbgEIKiQ (ORCPT ); Sat, 9 May 2020 06:38:16 -0400 Received: from mail-oi1-f193.google.com ([209.85.167.193]:33997 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726877AbgEIKiQ (ORCPT ); Sat, 9 May 2020 06:38:16 -0400 Received: by mail-oi1-f193.google.com with SMTP id c12so9819670oic.1; Sat, 09 May 2020 03:38:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nBe+65cgrmufPqKgCO/WJS9rGOrSoS9DaeQpyO6VPQY=; b=HUXFfZqyQiXplVrHeI/ZPD7fgTu/OyQS1uWandQ6GfholZUozpDA92RXqRtP3552+4 QU3UraKKkKBepmI4MM8VVIPVwoKSVc58fm+nR18vHiQTUD114S+ZJ7Z1yqclKOvDyfDw /LAg8vYGyAmWIpSXcfPoxA14/QbxzjQIGrNCcLfV+j4vNoubQ5Lw6Kej6XiDjnDtr/Sm mSjL8ioibecpSpdditmliAoTdksLU0kI/e8QDnJL6gNrAGiDVY9bhRs8tKRKoMOM/4yM fBklMHZ/F0j1KhJwDEC/SGcPxpWd4DK81p+RBhisjz5CIqhRrrNXgUi0x5GI2ktEKXzZ IZ3w== X-Gm-Message-State: AGi0Pua8mblCFI4UeA4h/Ojs+ZTIWSRPGsnxdFCxXlARacpXuuCfjEAj oYctl3NkzFVkGH2Q6GDOKkrfZ7dULzyemEM0/O0= X-Google-Smtp-Source: APiQypJViR7zf1BxfE4fSiEMumUvdAfdspNngdk/6s5fr4R3Q+whgmTLapvbuOPEuAwW4U0ZD7JgMnKsLrBjVv9lPKw= X-Received: by 2002:aca:d50f:: with SMTP id m15mr13605566oig.54.1589020691722; Sat, 09 May 2020 03:38:11 -0700 (PDT) MIME-Version: 1.0 References: <20200508161517.252308-1-hch@lst.de> <20200508161517.252308-2-hch@lst.de> In-Reply-To: <20200508161517.252308-2-hch@lst.de> From: Geert Uytterhoeven Date: Sat, 9 May 2020 12:38:00 +0200 Message-ID: Subject: Re: [PATCH 01/15] nfblock: use gendisk private_data To: Christoph Hellwig Cc: Jens Axboe , Jim Paris , Geoff Levand , Joshua Morris , Philip Kelleher , Minchan Kim , Nitin Gupta , Sergey Senozhatsky , linux-m68k , Linux Kernel Mailing List , "open list:TENSILICA XTENSA PORT (xtensa)" , Lars Ellenberg , linux-block@vger.kernel.org, linuxppc-dev , linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, "linux-nvdimm@lists.01.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Hi Christoph, On Fri, May 8, 2020 at 6:16 PM Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig Thanks for your patch! > --- a/arch/m68k/emu/nfblock.c > +++ b/arch/m68k/emu/nfblock.c > @@ -61,7 +61,7 @@ struct nfhd_device { > > static blk_qc_t nfhd_make_request(struct request_queue *queue, struct bio *bio) > { > - struct nfhd_device *dev = queue->queuedata; > + struct nfhd_device *dev = bio->bi_disk->private_data; > struct bio_vec bvec; > struct bvec_iter iter; > int dir, len, shift; > @@ -122,7 +122,6 @@ static int __init nfhd_init_one(int id, u32 blocks, u32 bsize) > if (dev->queue == NULL) > goto free_dev; > > - dev->queue->queuedata = dev; > blk_queue_logical_block_size(dev->queue, bsize); > > dev->disk = alloc_disk(16); > @@ -136,6 +135,7 @@ static int __init nfhd_init_one(int id, u32 blocks, u32 bsize) > sprintf(dev->disk->disk_name, "nfhd%u", dev_id); > set_capacity(dev->disk, (sector_t)blocks * (bsize / 512)); > dev->disk->queue = dev->queue; > + dev->disk->private_data = dev; This is already set above, just before the quoted sprintf() call. > > add_disk(dev->disk); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D579C28CBC for ; Sat, 9 May 2020 10:39:55 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E3B67214D8 for ; Sat, 9 May 2020 10:39:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E3B67214D8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49K3c83TL9zDrCX for ; Sat, 9 May 2020 20:39:52 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.167.193; helo=mail-oi1-f193.google.com; envelope-from=geert.uytterhoeven@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Received: from mail-oi1-f193.google.com (mail-oi1-f193.google.com [209.85.167.193]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49K3ZN6m7kzDr6t for ; Sat, 9 May 2020 20:38:17 +1000 (AEST) Received: by mail-oi1-f193.google.com with SMTP id t199so10845088oif.7 for ; Sat, 09 May 2020 03:38:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nBe+65cgrmufPqKgCO/WJS9rGOrSoS9DaeQpyO6VPQY=; b=UCgyRkP1xv7ALC2qq55HYmb2KYn61ZKOqhn9XbEJTZYXKPPwmp3NZeya1uMcN9joOa zEDkoQBQH3sP58jSOxDvdFPeqHqjO+YIQ8evPeduz01YAopsAoSkWB7E7gtHomLKyB7K kan7BZVSeyFxBAkzWmRlwGC+RiiezHigIyDLzAoySC4nR07OLiVVuaiE3cTj97UxiEFI +LuMWQRSWVANS3x9pMFk8oDuVFEZirb7p7wZSmylQt0iPUjVQJSb+Lu7fZij5LkhGtyO 53accaYJIUIljAIz7FzjRFGCh2szcML9SZq0U+9OvicPYu2MIAC4Z6K2yGH1apAN3npm /hFg== X-Gm-Message-State: AGi0PuZw2wdFgfoP9emumYES8OPwncvxVbZj9RWMY9CSHE7HL0/8hphT VeANaMl+Cc6a69k2VmfzYfFCZ6cqDmEYrvoMvYo= X-Google-Smtp-Source: APiQypJViR7zf1BxfE4fSiEMumUvdAfdspNngdk/6s5fr4R3Q+whgmTLapvbuOPEuAwW4U0ZD7JgMnKsLrBjVv9lPKw= X-Received: by 2002:aca:d50f:: with SMTP id m15mr13605566oig.54.1589020691722; Sat, 09 May 2020 03:38:11 -0700 (PDT) MIME-Version: 1.0 References: <20200508161517.252308-1-hch@lst.de> <20200508161517.252308-2-hch@lst.de> In-Reply-To: <20200508161517.252308-2-hch@lst.de> From: Geert Uytterhoeven Date: Sat, 9 May 2020 12:38:00 +0200 Message-ID: Subject: Re: [PATCH 01/15] nfblock: use gendisk private_data To: Christoph Hellwig Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , "open list:TENSILICA XTENSA PORT \(xtensa\)" , linux-raid@vger.kernel.org, Sergey Senozhatsky , "linux-nvdimm@lists.01.org" , Geoff Levand , Linux Kernel Mailing List , Jim Paris , linux-block@vger.kernel.org, Minchan Kim , linux-m68k , Philip Kelleher , linux-bcache@vger.kernel.org, linuxppc-dev , Joshua Morris , Nitin Gupta , Lars Ellenberg Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Christoph, On Fri, May 8, 2020 at 6:16 PM Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig Thanks for your patch! > --- a/arch/m68k/emu/nfblock.c > +++ b/arch/m68k/emu/nfblock.c > @@ -61,7 +61,7 @@ struct nfhd_device { > > static blk_qc_t nfhd_make_request(struct request_queue *queue, struct bio *bio) > { > - struct nfhd_device *dev = queue->queuedata; > + struct nfhd_device *dev = bio->bi_disk->private_data; > struct bio_vec bvec; > struct bvec_iter iter; > int dir, len, shift; > @@ -122,7 +122,6 @@ static int __init nfhd_init_one(int id, u32 blocks, u32 bsize) > if (dev->queue == NULL) > goto free_dev; > > - dev->queue->queuedata = dev; > blk_queue_logical_block_size(dev->queue, bsize); > > dev->disk = alloc_disk(16); > @@ -136,6 +135,7 @@ static int __init nfhd_init_one(int id, u32 blocks, u32 bsize) > sprintf(dev->disk->disk_name, "nfhd%u", dev_id); > set_capacity(dev->disk, (sector_t)blocks * (bsize / 512)); > dev->disk->queue = dev->queue; > + dev->disk->private_data = dev; This is already set above, just before the quoted sprintf() call. > > add_disk(dev->disk); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds