From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E961C10F28 for ; Mon, 9 Mar 2020 08:01:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7F29B20728 for ; Mon, 9 Mar 2020 08:01:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726415AbgCIIBO (ORCPT ); Mon, 9 Mar 2020 04:01:14 -0400 Received: from mail-ot1-f68.google.com ([209.85.210.68]:44557 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725796AbgCIIBN (ORCPT ); Mon, 9 Mar 2020 04:01:13 -0400 Received: by mail-ot1-f68.google.com with SMTP id v22so8624001otq.11; Mon, 09 Mar 2020 01:01:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5KNQrDe0l6oCFPtPg6ftsB3rjrTR1HyU2LsJupipGE8=; b=QMBcEx6xHAL00m9ofm9CCbYJYgdp+E0JA7ZDV//TxPyQk7kV7wNZRt/BUNyOIF/Cx8 /A2ifIqGoapZ5mZcC+4Zf0fI7Z/KQkvSQbWDDU60pp1WTSzmDWEDR9bV0BfgeX4Zrxn6 Db8M7TEc2UGD7BHScMjWWSsFkxvx8z4Q5K3hMjmBuFcup8nMldv5pjKouy1CuEIqe2ng 7mwLgC4RT1iHhOLF7oVGHMhT2tF9FKNI8eFwvodLDTALrmFtCve92ERwKyVzimoBHxqX qNmHBjnmiSp680vOSs0U7Rh/WeVKtEJrMDB1tk9BwaQ8uqnk0l/Q5wXWnmUzpihk/BjD cmWw== X-Gm-Message-State: ANhLgQ0Ps40Fe10oKeBXSrzNB3AQZ/rnkr+D0nfNkxadALnZL2tYrB61 +nQ5jx5k8tb9z/FIDR57gzxijDwRzQZsKsorhks= X-Google-Smtp-Source: ADFU+vsDTCa3jjZ1zeDrCbvPHrDJy5j6vGE23gbOBny//ko/4PRaNwTR9xHABVzOcF6wEE35AvzQODCVrLJwiijRM9I= X-Received: by 2002:a9d:5c0c:: with SMTP id o12mr12090100otk.145.1583740871801; Mon, 09 Mar 2020 01:01:11 -0700 (PDT) MIME-Version: 1.0 References: <20200305103228.9686-1-zhang.lyra@gmail.com> <20200305103228.9686-2-zhang.lyra@gmail.com> In-Reply-To: From: Geert Uytterhoeven Date: Mon, 9 Mar 2020 09:01:00 +0100 Message-ID: Subject: Re: [PATCH 2/2] tty: serial: make SERIAL_SPRD not depend on ARCH_SPRD To: Chunyan Zhang Cc: Greg Kroah-Hartman , Catalin Marinas , Will Deacon , Jiri Slaby , Linux Kernel Mailing List , Chunyan Zhang , "open list:SERIAL DRIVERS" , Baolin Wang , Orson Zhai , Linux ARM Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chunyan, On Mon, Mar 9, 2020 at 2:18 AM Chunyan Zhang wrote: > On Fri, 6 Mar 2020 at 20:41, Geert Uytterhoeven wrote: > > On Thu, Mar 5, 2020 at 11:33 AM Chunyan Zhang wrote: > > > From: Chunyan Zhang > > > > > > Remove the dependency with ARCH_SPRD from sprd serial/console Kconfig-s, > > > since we want them can be built-in when ARCH_SPRD is set as 'm'. > > > > Why would you want a serial driver for a specific platform to be builtin, > > while all other platform support is modular? > > Oh, that's not this patch means. > > We just want serial driver can be builtin for any platform, so it What would be the benefit of the user to be able to have the SPRD serial driver built-in on any platform? AFAIU, it supports only Spreadtrum platforms. > should not depend on a config which can be set as 'm' (i.e. ARCH_SPRD) > , otherwise if the config was set as 'm', the serial driver can't be > selected as 'y' then. I ask about that as a reply to PATCH 1/2. > That's what I mean. > > > --- a/drivers/tty/serial/Kconfig > > > +++ b/drivers/tty/serial/Kconfig > > > @@ -1452,7 +1452,6 @@ config SERIAL_MEN_Z135 > > > > > > config SERIAL_SPRD > > > tristate "Support for Spreadtrum serial" > > > - depends on ARCH_SPRD > > > select SERIAL_CORE > > > help > > > This enables the driver for the Spreadtrum's serial. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2726BC10F27 for ; Mon, 9 Mar 2020 08:01:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F04FA20728 for ; Mon, 9 Mar 2020 08:01:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KrHOb/uo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F04FA20728 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Dk1UNDw0rSmIdyBSGEMBOZnXCkZTpYbZQOTgYRJpZIw=; b=KrHOb/uoma6bxI hwddhmE+fPYQqtxjeT5n6a6Ep9alENzLSJ7vSpfhzaxPhPoAvLjzCK93jl7snmVXp/Qg81ImE8n1/ xJy42y3d4kP0/yI4/O4SQDoljo4Ul3xXQe7fb1QaCq8JfBwWR4yE8a6C+95oG/sjuVsYrdr3fKbTz kRFCF3JGPxuBwW3DCkh+leCjfYz6SWp1siqeU9bfHRYwihaGWZX7xwEmIhuDoA0u357al7vfQPMBk mCmnFLaBYyPuQJrwlNK82smzUAdgfYNKiK9cegofKtB8PqnYwpDyHvOfZDOwxgB1ADRLxAfVqN+op 01ohE97r9v2+UnzmA7/A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBDLh-0006wj-At; Mon, 09 Mar 2020 08:01:17 +0000 Received: from mail-ot1-f67.google.com ([209.85.210.67]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBDLe-0006vy-0Z for linux-arm-kernel@lists.infradead.org; Mon, 09 Mar 2020 08:01:15 +0000 Received: by mail-ot1-f67.google.com with SMTP id 66so8635865otd.9 for ; Mon, 09 Mar 2020 01:01:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5KNQrDe0l6oCFPtPg6ftsB3rjrTR1HyU2LsJupipGE8=; b=NfXj5DhAXr90wsOiBoHBtOihPFk8hXD5BUlyx23uinVf1AbauRkuSvVD/7mfZ1Wb3U A+fNohrQTF63Fitx/MHJrMz/J7sGh20SLY+9EjttiE/JHHXcedVzMIzXf5i69yRTARK3 io2VAPbKPqx4ezwGFzYgvIHd7jWEsJjEglUYwtayqrDMrt/CwxXjgWk3dp/PwKezW9Wo gSv/TdfZ/itTrFEGJKP3frA/Z89ofMf612xNWU/1bV1CAsdNgBq9sEnWaYDoDrDz+1Gt ad5ndmDQWi6ohNPPpQ8VzSCsNwW5QWo9m0sEM+MeTY/hRjBp+D1BJjBayF6eF+AJK+o+ CDug== X-Gm-Message-State: ANhLgQ0UHeBVcrK6d6kIo8FtxQED8WW4V+2BQRa6zWSkkfW4CEMnlLsV PWIU43T5mAhZ4o51Y0eW5H/83gIQZyzVrxrgGqw= X-Google-Smtp-Source: ADFU+vsDTCa3jjZ1zeDrCbvPHrDJy5j6vGE23gbOBny//ko/4PRaNwTR9xHABVzOcF6wEE35AvzQODCVrLJwiijRM9I= X-Received: by 2002:a9d:5c0c:: with SMTP id o12mr12090100otk.145.1583740871801; Mon, 09 Mar 2020 01:01:11 -0700 (PDT) MIME-Version: 1.0 References: <20200305103228.9686-1-zhang.lyra@gmail.com> <20200305103228.9686-2-zhang.lyra@gmail.com> In-Reply-To: From: Geert Uytterhoeven Date: Mon, 9 Mar 2020 09:01:00 +0100 Message-ID: Subject: Re: [PATCH 2/2] tty: serial: make SERIAL_SPRD not depend on ARCH_SPRD To: Chunyan Zhang X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200309_010114_058693_48346922 X-CRM114-Status: GOOD ( 19.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Greg Kroah-Hartman , Linux Kernel Mailing List , Chunyan Zhang , "open list:SERIAL DRIVERS" , Jiri Slaby , Baolin Wang , Orson Zhai , Will Deacon , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Chunyan, On Mon, Mar 9, 2020 at 2:18 AM Chunyan Zhang wrote: > On Fri, 6 Mar 2020 at 20:41, Geert Uytterhoeven wrote: > > On Thu, Mar 5, 2020 at 11:33 AM Chunyan Zhang wrote: > > > From: Chunyan Zhang > > > > > > Remove the dependency with ARCH_SPRD from sprd serial/console Kconfig-s, > > > since we want them can be built-in when ARCH_SPRD is set as 'm'. > > > > Why would you want a serial driver for a specific platform to be builtin, > > while all other platform support is modular? > > Oh, that's not this patch means. > > We just want serial driver can be builtin for any platform, so it What would be the benefit of the user to be able to have the SPRD serial driver built-in on any platform? AFAIU, it supports only Spreadtrum platforms. > should not depend on a config which can be set as 'm' (i.e. ARCH_SPRD) > , otherwise if the config was set as 'm', the serial driver can't be > selected as 'y' then. I ask about that as a reply to PATCH 1/2. > That's what I mean. > > > --- a/drivers/tty/serial/Kconfig > > > +++ b/drivers/tty/serial/Kconfig > > > @@ -1452,7 +1452,6 @@ config SERIAL_MEN_Z135 > > > > > > config SERIAL_SPRD > > > tristate "Support for Spreadtrum serial" > > > - depends on ARCH_SPRD > > > select SERIAL_CORE > > > help > > > This enables the driver for the Spreadtrum's serial. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel