From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH] gpu: drm: msm: Replace type of paddr to uint32_t. Date: Thu, 5 Jun 2014 09:24:02 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Clark Cc: linux-arm-msm@vger.kernel.org, Linux Kernel Mailing List , "dri-devel@lists.freedesktop.org" , "Matwey V. Kornilov" , Bryan Huntsman , matwey.kornilov@gmail.com, Daniel Walker , David Brown List-Id: linux-arm-msm@vger.kernel.org On Thu, Jun 5, 2014 at 2:05 AM, Rob Clark wrote: > On Wed, Jun 4, 2014 at 6:54 AM, Matwey V. Kornilov wrote: >> From e7147352639fd8f92b1cc85cff9bc5046c7a2130 Mon Sep 17 00:00:00 2001 >> From: "Matwey V. Kornilov" >> Date: Mon, 2 Jun 2014 20:17:29 +0400 >> Subject: [PATCH] Replace type of paddr to uint32_t. >> >> This patch helps to avoid the following build issue: >> >> drivers/gpu/drm/msm/msm_fbdev.c:108:2: error: passing argument 3 of >> 'msm_gem_get_iova_locked' from incompatible pointer type [-Werror] >> msm_gem_get_iova_locked(fbdev->bo, 0, &paddr); >> ^ >> In file included from drivers/gpu/drm/msm/msm_fbdev.c:18:0: >> drivers/gpu/drm/msm/msm_drv.h:153:5: note: expected 'uint32_t *' but >> argument is of type 'dma_addr_t *' >> int msm_gem_get_iova_locked(struct drm_gem_object *obj, int id, >> ^ >> >> Signed-off-by: Matwey V. Kornilov > > Reviewed-by: Rob Clark Perhaps the uint32_t should become dma_addr_t instead? drivers/gpu/drm/msm/msm_gem.h has: struct { // XXX uint32_t iova; } domain[NUM_DOMAINS]; (note the "XXX"). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751624AbaFEHYG (ORCPT ); Thu, 5 Jun 2014 03:24:06 -0400 Received: from mail-ig0-f174.google.com ([209.85.213.174]:50074 "EHLO mail-ig0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750853AbaFEHYE (ORCPT ); Thu, 5 Jun 2014 03:24:04 -0400 MIME-Version: 1.0 In-Reply-To: References: Date: Thu, 5 Jun 2014 09:24:02 +0200 X-Google-Sender-Auth: KBCSWLl35EV5cz9PH7gmFQcYgYk Message-ID: Subject: Re: [PATCH] gpu: drm: msm: Replace type of paddr to uint32_t. From: Geert Uytterhoeven To: Rob Clark Cc: "Matwey V. Kornilov" , David Brown , Daniel Walker , Bryan Huntsman , David Airlie , linux-arm-msm@vger.kernel.org, "dri-devel@lists.freedesktop.org" , matwey.kornilov@gmail.com, Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 5, 2014 at 2:05 AM, Rob Clark wrote: > On Wed, Jun 4, 2014 at 6:54 AM, Matwey V. Kornilov wrote: >> From e7147352639fd8f92b1cc85cff9bc5046c7a2130 Mon Sep 17 00:00:00 2001 >> From: "Matwey V. Kornilov" >> Date: Mon, 2 Jun 2014 20:17:29 +0400 >> Subject: [PATCH] Replace type of paddr to uint32_t. >> >> This patch helps to avoid the following build issue: >> >> drivers/gpu/drm/msm/msm_fbdev.c:108:2: error: passing argument 3 of >> 'msm_gem_get_iova_locked' from incompatible pointer type [-Werror] >> msm_gem_get_iova_locked(fbdev->bo, 0, &paddr); >> ^ >> In file included from drivers/gpu/drm/msm/msm_fbdev.c:18:0: >> drivers/gpu/drm/msm/msm_drv.h:153:5: note: expected 'uint32_t *' but >> argument is of type 'dma_addr_t *' >> int msm_gem_get_iova_locked(struct drm_gem_object *obj, int id, >> ^ >> >> Signed-off-by: Matwey V. Kornilov > > Reviewed-by: Rob Clark Perhaps the uint32_t should become dma_addr_t instead? drivers/gpu/drm/msm/msm_gem.h has: struct { // XXX uint32_t iova; } domain[NUM_DOMAINS]; (note the "XXX"). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds