From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755560AbcETHeK (ORCPT ); Fri, 20 May 2016 03:34:10 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:32771 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755409AbcETHeI (ORCPT ); Fri, 20 May 2016 03:34:08 -0400 MIME-Version: 1.0 In-Reply-To: <1463087038-2522527-1-git-send-email-arnd@arndb.de> References: <1463087038-2522527-1-git-send-email-arnd@arndb.de> Date: Fri, 20 May 2016 09:34:06 +0200 X-Google-Sender-Auth: wHbhAKAruCi0-JX0gvwrJhY1DA4 Message-ID: Subject: Re: [PATCH] irqchip: nps: add 64BIT dependency From: Geert Uytterhoeven To: Arnd Bergmann Cc: Jason Cooper , Noam Camus , Vineet Gupta , arcml , Thomas Gleixner , Marc Zyngier , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On Thu, May 12, 2016 at 11:03 PM, Arnd Bergmann wrote: > The newly added nps irqchip driver causes build warnings on ARM64. > > include/soc/nps/common.h: In function 'nps_host_reg_non_cl': > include/soc/nps/common.h:148:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > > As the driver is only used on ARC, we don't need to see it without > COMPILE_TEST elsewhere, and we can avoid the warnings by only > building on 32-bit architectures even with CONFIG_COMPILE_TEST. > > Signed-off-by: Arnd Bergmann > --- > drivers/irqchip/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig > index 83775f148158..37289cf6b449 100644 > --- a/drivers/irqchip/Kconfig > +++ b/drivers/irqchip/Kconfig > @@ -253,6 +253,7 @@ config MVEBU_ODMI > > config EZNPS_GIC > bool "NPS400 Global Interrupt Manager (GIM)" > + depends on ARC || (COMPILE_TEST && !64BIT) > select IRQ_DOMAIN > help > Support the EZchip NPS400 global interrupt controller As ARC_PLAT_EZNPS already selects EZNPS_GIC, I'd like to suggest the slight simpler (whitespace-damaged): --- a/drivers/irqchip/Kconfig +++ b/drivers/irqchip/Kconfig @@ -255,7 +255,8 @@ config PARTITION_PERCPU bool config EZNPS_GIC - bool "NPS400 Global Interrupt Manager (GIM)" + bool "NPS400 Global Interrupt Manager (GIM)" if COMPILE_TEST + depends on !64BIT select IRQ_DOMAIN help Support the EZchip NPS400 global interrupt controller Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 From: geert@linux-m68k.org (Geert Uytterhoeven) Date: Fri, 20 May 2016 09:34:06 +0200 Subject: [PATCH] irqchip: nps: add 64BIT dependency In-Reply-To: <1463087038-2522527-1-git-send-email-arnd@arndb.de> References: <1463087038-2522527-1-git-send-email-arnd@arndb.de> List-ID: Message-ID: To: linux-snps-arc@lists.infradead.org Hi Arnd, On Thu, May 12, 2016@11:03 PM, Arnd Bergmann wrote: > The newly added nps irqchip driver causes build warnings on ARM64. > > include/soc/nps/common.h: In function 'nps_host_reg_non_cl': > include/soc/nps/common.h:148:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > > As the driver is only used on ARC, we don't need to see it without > COMPILE_TEST elsewhere, and we can avoid the warnings by only > building on 32-bit architectures even with CONFIG_COMPILE_TEST. > > Signed-off-by: Arnd Bergmann > --- > drivers/irqchip/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig > index 83775f148158..37289cf6b449 100644 > --- a/drivers/irqchip/Kconfig > +++ b/drivers/irqchip/Kconfig > @@ -253,6 +253,7 @@ config MVEBU_ODMI > > config EZNPS_GIC > bool "NPS400 Global Interrupt Manager (GIM)" > + depends on ARC || (COMPILE_TEST && !64BIT) > select IRQ_DOMAIN > help > Support the EZchip NPS400 global interrupt controller As ARC_PLAT_EZNPS already selects EZNPS_GIC, I'd like to suggest the slight simpler (whitespace-damaged): --- a/drivers/irqchip/Kconfig +++ b/drivers/irqchip/Kconfig @@ -255,7 +255,8 @@ config PARTITION_PERCPU bool config EZNPS_GIC - bool "NPS400 Global Interrupt Manager (GIM)" + bool "NPS400 Global Interrupt Manager (GIM)" if COMPILE_TEST + depends on !64BIT select IRQ_DOMAIN help Support the EZchip NPS400 global interrupt controller Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds