From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAAE8C433B4 for ; Sun, 16 May 2021 09:04:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 99667610A6 for ; Sun, 16 May 2021 09:04:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234387AbhEPJFq (ORCPT ); Sun, 16 May 2021 05:05:46 -0400 Received: from mail-ua1-f50.google.com ([209.85.222.50]:38882 "EHLO mail-ua1-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229445AbhEPJFn (ORCPT ); Sun, 16 May 2021 05:05:43 -0400 Received: by mail-ua1-f50.google.com with SMTP id k45so1141726uag.5; Sun, 16 May 2021 02:04:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PtdmExuunL6I47GcuCl9lENSjo5yazFWO+xZYZLpNig=; b=L/0IGamP5Ugf/Fcuob7CjzBixnjiGZe1aa1cPh6Zp3y05ZIZh23SS/vqIIhvmK+DCd W7HhtmSExT83+f2qWsJ+WeA/PShrbIUqlYYQ2bzSPATaMX0/CdTjU+kcuCvsJ5mWgnsU EBHfv5/uc6+SfixPQJbriV6QL2X9qVTFjXTytHEGZoKuYbSnY3nA+UpAg4Mdse39ad/S nrYT/ALfXLT95awkIAIVZGUe7eufemG7AvyyK3KcLafPD+OitVm/JnhoWoDbEJNoNc9T F9R8SAQjU1xZ5szdkCxOUYhLne56gEgeXw61CX2gDneokqFBT2+BOCkPQF9cAt9HBEkx R79A== X-Gm-Message-State: AOAM530fPXWATlQo4RiawGS3g0YFnHxrvBQhWORTpiLu05yELPWqXSZR ur3hYRaUtw4nu/uPVKGrTPRkaTy9E6t2/Kn+F1U= X-Google-Smtp-Source: ABdhPJxK3DYeQePlVbgeO7XqyfC5AFgcTM5ME/HtjYcIrDn+/XqI6pl1zvwgxXwih7+7VjttcAar2n0DEz3jwq/QyUE= X-Received: by 2002:ab0:7705:: with SMTP id z5mr8869408uaq.2.1621155867307; Sun, 16 May 2021 02:04:27 -0700 (PDT) MIME-Version: 1.0 References: <20210515221320.1255291-1-arnd@kernel.org> <20210515221320.1255291-14-arnd@kernel.org> In-Reply-To: From: Geert Uytterhoeven Date: Sun, 16 May 2021 11:04:15 +0200 Message-ID: Subject: Re: [RFC 13/13] [net-next] 8390: xsurf100: avoid including lib8390.c To: Finn Thain Cc: Arnd Bergmann , netdev , "Linux/m68k" , Arnd Bergmann , Paul Gortmaker , "Maciej W. Rozycki" , "David S. Miller" , Jakub Kicinski , Doug Berger , Florian Fainelli , Sam Creasey , Christophe JAILLET , Andrew Lunn , Alexei Starovoitov , Eric Dumazet , Andrii Nakryiko , Bartosz Golaszewski , Linux Kernel Mailing List , bcm-kernel-feedback-list , Michael Schmitz Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 16, 2021 at 6:24 AM Finn Thain wrote: > On Sun, 16 May 2021, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > This driver always warns about unused functions because it includes > > an file that it doesn't actually need: > > I don't think you can omit #include "lib8390.c" here without changing > driver behaviour, because of the macros in effect. > > I think this change would need some actual testing unless you can show > that the module binary does not change. Michael posted a similar but different patch a while ago, involving calling ax_NS8390_reinit(): https://lore.kernel.org/linux-m68k/1528604559-972-3-git-send-email-schmitzmic@gmail.com/ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds