From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E20D0C433EF for ; Wed, 22 Sep 2021 17:40:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C353F61284 for ; Wed, 22 Sep 2021 17:40:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236944AbhIVRmZ (ORCPT ); Wed, 22 Sep 2021 13:42:25 -0400 Received: from mail-ua1-f49.google.com ([209.85.222.49]:35695 "EHLO mail-ua1-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236815AbhIVRmX (ORCPT ); Wed, 22 Sep 2021 13:42:23 -0400 Received: by mail-ua1-f49.google.com with SMTP id d4so2398801uak.2; Wed, 22 Sep 2021 10:40:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tvtYY0msHjnoC+I/Lu672obi3mQrOmz8sSMZ/dhCgcM=; b=FCj3Efls9Q8dLA0QxErM9Xb0i8ZbUqG4jBD8i+gelfJds8YrhELeqZI0ykoHZ7v1/S Oozm5Fdg11HkPOogmdkgt/DSmslqSHtKY1pgKPo/llEAANBkFk13MarrmPTuuR7SKthK AuTk+V9SUwOAB/ppRxu50guRUgE1NoQBlyX8Edzi93O55+3yTb9IzvL1MuI09wZ1EUR4 YYwynGoA3KqySXSunwEkeFxWeYIL+8jvVUyym8SBS6i23gbvK8ymqwGDOVXdqIiCshN3 tik9C6ietbyaqBHEP2ff6NYTITYdQlTgcj0bFPso/WR4bfpgDkYlDQyVh6yLbkBwFia4 Cvew== X-Gm-Message-State: AOAM533+WbE0M04biw5o9JBC5PSeK59DBSTCVKcKlcDGqNOcPqi+KPZF 1TnfFWgzWGXsWlplSlT8DtFqhbj5KVMKiHeJ1WQ= X-Google-Smtp-Source: ABdhPJzd6iDf31R8aoIZCqnSwnmWaUJ7hUGbaC3Wu5rohHlUdjjVsD/K6aFxIKOAYsQD2BBiS+LwneCYtSPWWyKiJjw= X-Received: by 2002:ab0:311a:: with SMTP id e26mr635558ual.122.1632332452990; Wed, 22 Sep 2021 10:40:52 -0700 (PDT) MIME-Version: 1.0 References: <20210623135639.17125-1-laurent.pinchart+renesas@ideasonboard.com> In-Reply-To: From: Geert Uytterhoeven Date: Wed, 22 Sep 2021 19:40:41 +0200 Message-ID: Subject: Re: [RESEND] [PATCH v2 1/2] dt-bindings: display: bridge: Add binding for R-Car MIPI DSI/CSI-2 TX To: Laurent Pinchart Cc: DRI Development , Linux-Renesas , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Laurent, On Wed, Sep 22, 2021 at 10:08 AM Laurent Pinchart wrote: > On Wed, Sep 22, 2021 at 08:43:57AM +0200, Geert Uytterhoeven wrote: > > On Wed, Sep 22, 2021 at 3:27 AM Laurent Pinchart wrote: > > > On Tue, Sep 21, 2021 at 05:53:52PM +0200, Geert Uytterhoeven wrote: > > > > On Wed, Jul 28, 2021 at 6:26 PM Laurent Pinchart wrote: > > > > > The R-Car MIPI DSI/CSI-2 TX is embedded in the Renesas R-Car V3U SoC. It > > > > > can operate in either DSI or CSI-2 mode, with up to four data lanes. > > > > > > > > > > Signed-off-by: Laurent Pinchart > > > > > Reviewed-by: Kieran Bingham > > > > > > > > Thanks for your patch! > > > > > > > > > --- /dev/null > > > > > +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.yaml > > > > > @@ -0,0 +1,118 @@ > > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > > > +%YAML 1.2 > > > > > +--- > > > > > +$id: http://devicetree.org/schemas/display/bridge/renesas,dsi-csi2-tx.yaml# > > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > > + > > > > > +title: Renesas R-Car MIPI DSI/CSI-2 Encoder > > > > > + > > > > > +maintainers: > > > > > + - Laurent Pinchart > > > > > + > > > > > +description: | > > > > > + This binding describes the MIPI DSI/CSI-2 encoder embedded in the Renesas > > > > > + R-Car V3U SoC. The encoder can operate in either DSI or CSI-2 mode, with up > > > > > + to four data lanes. > > > > > + > > > > > +properties: > > > > > + compatible: > > > > > + enum: > > > > > + - renesas,r8a779a0-dsi-csi2-tx # for V3U > > > > > + > > > > > + reg: > > > > > + maxItems: 1 > > > > > + > > > > > + clocks: > > > > > + items: > > > > > + - description: Functional clock > > > > > + - description: DSI (and CSI-2) functional clock > > > > > + - description: PLL reference clock > > > > > + > > > > > + clock-names: > > > > > + items: > > > > > + - const: fck > > > > > + - const: dsi > > > > > + - const: pll > > > > > > > > No interrupts? > > > > The hardware manual says there are 9 interrupts. > > > > > > Who comes up with such insanely high numbers of interrupts ? :-) > > > > > > What the hardware manual doesn't document is how interrupts are mapped. > > > There's indeed 9 of them, and there are 9 interrupt sources, but that's > > > all we know. I can easily add a > > > > > > interrupts: > > > maxItems: 9 > > > > > > but I can add interrupt names without additional information. It may be > > > possible to deduce some of the interrupt mappings from experiments, but > > > not all of them. What do you think would be a good way forward ? Leave > > > the interrupts out for now as we don't have the information ? Only list > > > the interrupts but not their names ? Something else ? > > > > I think what we did in the past is not list the interrupts at all. > > They can be added once we receive more documentation. > > Sounds good to me, as that's what this patch does already ;-) A R-b or > A-b tag is welcome. Your wish is my command... Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59AC3C433F5 for ; Wed, 22 Sep 2021 17:40:56 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B2CF46120E for ; Wed, 22 Sep 2021 17:40:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B2CF46120E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9A4BD6E02E; Wed, 22 Sep 2021 17:40:54 +0000 (UTC) Received: from mail-ua1-f53.google.com (mail-ua1-f53.google.com [209.85.222.53]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0E0846E02E for ; Wed, 22 Sep 2021 17:40:54 +0000 (UTC) Received: by mail-ua1-f53.google.com with SMTP id 42so2389216uar.5 for ; Wed, 22 Sep 2021 10:40:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tvtYY0msHjnoC+I/Lu672obi3mQrOmz8sSMZ/dhCgcM=; b=dd49QXHyCdrQn8DXB7Cuk9r5otCke8rPGMOOo8daESQF7dKedj9LYgoDbtgmIZ9/Kl nXu/+Czl/CqIdTlbN+uhdiX9N+/zY3qeApBguE2CZxa6O1QST0371aYPIR98wT+KEhx6 z3+faHWitgLcKcYMa52Djh2vL669MLn+5ZiXq2qqS4AZ7+ElxDONbIvSJ4FSN2ck9TEu zBjJxNIwD2G03L3q13BeKqwARfqtgeCFAZ4u6tDjuw9wC4+dgs+MfZC3WbzV5kEj/iwD ZOIKZYur+UxW5308VeVP08aEDm1odbCuZjAovKU88vNdeJW5clWRGq/87GSm5SlsM6ZL 5jsA== X-Gm-Message-State: AOAM533eN9g4MKkhsIZ7skiSLQCKz+D1TgaLqL5OCdje3Gf8S11jAjHu 0vRVgBPHn8MYlSNYeguBc7HnIs1YSiuHhpPsyk9JSFRF87w= X-Google-Smtp-Source: ABdhPJzd6iDf31R8aoIZCqnSwnmWaUJ7hUGbaC3Wu5rohHlUdjjVsD/K6aFxIKOAYsQD2BBiS+LwneCYtSPWWyKiJjw= X-Received: by 2002:ab0:311a:: with SMTP id e26mr635558ual.122.1632332452990; Wed, 22 Sep 2021 10:40:52 -0700 (PDT) MIME-Version: 1.0 References: <20210623135639.17125-1-laurent.pinchart+renesas@ideasonboard.com> In-Reply-To: From: Geert Uytterhoeven Date: Wed, 22 Sep 2021 19:40:41 +0200 Message-ID: Subject: Re: [RESEND] [PATCH v2 1/2] dt-bindings: display: bridge: Add binding for R-Car MIPI DSI/CSI-2 TX To: Laurent Pinchart Cc: DRI Development , Linux-Renesas , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Laurent, On Wed, Sep 22, 2021 at 10:08 AM Laurent Pinchart wrote: > On Wed, Sep 22, 2021 at 08:43:57AM +0200, Geert Uytterhoeven wrote: > > On Wed, Sep 22, 2021 at 3:27 AM Laurent Pinchart wrote: > > > On Tue, Sep 21, 2021 at 05:53:52PM +0200, Geert Uytterhoeven wrote: > > > > On Wed, Jul 28, 2021 at 6:26 PM Laurent Pinchart wrote: > > > > > The R-Car MIPI DSI/CSI-2 TX is embedded in the Renesas R-Car V3U SoC. It > > > > > can operate in either DSI or CSI-2 mode, with up to four data lanes. > > > > > > > > > > Signed-off-by: Laurent Pinchart > > > > > Reviewed-by: Kieran Bingham > > > > > > > > Thanks for your patch! > > > > > > > > > --- /dev/null > > > > > +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.yaml > > > > > @@ -0,0 +1,118 @@ > > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > > > +%YAML 1.2 > > > > > +--- > > > > > +$id: http://devicetree.org/schemas/display/bridge/renesas,dsi-csi2-tx.yaml# > > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > > + > > > > > +title: Renesas R-Car MIPI DSI/CSI-2 Encoder > > > > > + > > > > > +maintainers: > > > > > + - Laurent Pinchart > > > > > + > > > > > +description: | > > > > > + This binding describes the MIPI DSI/CSI-2 encoder embedded in the Renesas > > > > > + R-Car V3U SoC. The encoder can operate in either DSI or CSI-2 mode, with up > > > > > + to four data lanes. > > > > > + > > > > > +properties: > > > > > + compatible: > > > > > + enum: > > > > > + - renesas,r8a779a0-dsi-csi2-tx # for V3U > > > > > + > > > > > + reg: > > > > > + maxItems: 1 > > > > > + > > > > > + clocks: > > > > > + items: > > > > > + - description: Functional clock > > > > > + - description: DSI (and CSI-2) functional clock > > > > > + - description: PLL reference clock > > > > > + > > > > > + clock-names: > > > > > + items: > > > > > + - const: fck > > > > > + - const: dsi > > > > > + - const: pll > > > > > > > > No interrupts? > > > > The hardware manual says there are 9 interrupts. > > > > > > Who comes up with such insanely high numbers of interrupts ? :-) > > > > > > What the hardware manual doesn't document is how interrupts are mapped. > > > There's indeed 9 of them, and there are 9 interrupt sources, but that's > > > all we know. I can easily add a > > > > > > interrupts: > > > maxItems: 9 > > > > > > but I can add interrupt names without additional information. It may be > > > possible to deduce some of the interrupt mappings from experiments, but > > > not all of them. What do you think would be a good way forward ? Leave > > > the interrupts out for now as we don't have the information ? Only list > > > the interrupts but not their names ? Something else ? > > > > I think what we did in the past is not list the interrupts at all. > > They can be added once we receive more documentation. > > Sounds good to me, as that's what this patch does already ;-) A R-b or > A-b tag is welcome. Your wish is my command... Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds