From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6C8EC433B4 for ; Wed, 5 May 2021 09:25:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB322613F0 for ; Wed, 5 May 2021 09:25:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232034AbhEEJ0L (ORCPT ); Wed, 5 May 2021 05:26:11 -0400 Received: from mail-ua1-f43.google.com ([209.85.222.43]:36564 "EHLO mail-ua1-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231265AbhEEJ0J (ORCPT ); Wed, 5 May 2021 05:26:09 -0400 Received: by mail-ua1-f43.google.com with SMTP id x9so362785uao.3; Wed, 05 May 2021 02:25:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=h28TidAZCMYz7/IMmF+70mfHIZsQ1/vtB6OI3uOO2+0=; b=glZgqwlBfAH3f2OpZoRW+JdRVO381/Dwh6+HNKo37fgMQRsriPMgD2hQG0VuN37mWb 1jiGpD0qWZnnaHBf9WDssD7AUHanQVi2HwPK4LhgE39hSeOl+A6qFWG9HDWFtnqPPRdX /uvBCq+kDZzaJTkkhurYVsFAeRlsHZdNTFAtc0P6rL2SDoCl/0IWxWsz19nxQEASE7+v fZx9a//h8BjNgxz8dCjXW8yTg60e7WyF2fbOw8zavueOWTkOW0Q4HLXAED8gFT5p+IYo GwuScIU/UD3zNSH2hZl53g6YKb/mDBTql7oRuu7uaK9kbiEHby7nKMz7+RPivhMGeci3 7nXw== X-Gm-Message-State: AOAM531JzCGUCgIlM2M70g2V0KPjFlQqq0rFnl8P8GwmNRNgw/cwVMjK 0Iy1TE094960bdmFHnnfsDB+Aej+9nYQBhGcK8o= X-Google-Smtp-Source: ABdhPJziI2TokqO5wfUMj1aBrqFZbT5GIdeIbXee3lqYPdWJeryzTcqf3ZpRLXGKV+ye4J+F2TNI8NfsZfSQjqgVtK8= X-Received: by 2002:ab0:45e8:: with SMTP id u95mr376835uau.106.1620206712908; Wed, 05 May 2021 02:25:12 -0700 (PDT) MIME-Version: 1.0 References: <20210505091928.22010-1-jslaby@suse.cz> <20210505091928.22010-23-jslaby@suse.cz> In-Reply-To: <20210505091928.22010-23-jslaby@suse.cz> From: Geert Uytterhoeven Date: Wed, 5 May 2021 11:25:01 +0200 Message-ID: Subject: Re: [PATCH 22/35] tty: make tty_operations::write_room return uint To: Jiri Slaby Cc: Greg KH , "open list:SERIAL DRIVERS" , linux-kernel@vger.kernel.org, Richard Henderson , Ivan Kokshaysky , Matt Turner , "James E.J. Bottomley" , Helge Deller , Jeff Dike , Richard Weinberger , Anton Ivanov , Chris Zankel , Max Filippov , Arnd Bergmann , Samuel Iglesias Gonsalvez , Jens Taprogge , Karsten Keil , Scott Branden , Ulf Hansson , "David S. Miller" , Jakub Kicinski , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , David Lin , Johan Hovold , Alex Elder , Laurentiu Tudor , Jiri Kosina , David Sterba , Shawn Guo , Sascha Hauer , Oliver Neukum , Felipe Balbi , Mathias Nyman , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 5, 2021 at 11:19 AM Jiri Slaby wrote: > Line disciplines expect a positive value or zero returned from > tty->ops->write_room (invoked by tty_write_room). So make this > assumption explicit by using unsigned int as a return value. Both of > tty->ops->write_room and tty_write_room. > > Signed-off-by: Jiri Slaby > arch/m68k/emu/nfcon.c | 2 +- > drivers/tty/amiserial.c | 2 +- Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds