From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH v2 2/3] arm64: dts: renesas: salvator-common: Configure PMIC for DDR Backup Power Date: Fri, 16 Mar 2018 13:00:12 +0100 Message-ID: References: <1521029386-29975-1-git-send-email-geert+renesas@glider.be> <1521029386-29975-3-git-send-email-geert+renesas@glider.be> <9c6289e4-23dd-c79b-bd1f-058d843739d2@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <9c6289e4-23dd-c79b-bd1f-058d843739d2@cogentembedded.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Sergei Shtylyov Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Geert Uytterhoeven , Magnus Damm , Linux-Renesas , Simon Horman , Linux ARM , Marek Vasut List-Id: devicetree@vger.kernel.org Hi Sergei, On Wed, Mar 14, 2018 at 4:17 PM, Sergei Shtylyov wrote: > On 03/14/2018 03:09 PM, Geert Uytterhoeven wrote: >> On Salvator-X(S), all of the DDR0, DDR1, DDR0C, and DDR1C power rails >> need to be kept powered when backup mode is enabled. Reflect this in >> the "rohm,ddr-backup-power" property for the BD9571MWV PMIC node. >> >> The accessory power switch (SW23) is a toggle switch, hense specify >> "rohm,rstbmode-level". >> >> Signed-off-by: Geert Uytterhoeven >> --- >> v2: >> - Add rohm,rstbmode-level. >> --- >> arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi >> index 2a7f36abd2dd85c6..80794c38c2669d75 100644 >> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi >> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi >> @@ -376,6 +376,8 @@ >> #interrupt-cells = <2>; >> gpio-controller; >> #gpio-cells = <2>; >> + rohm,ddr-backup-power = <15>; > > Why not 0xf if those are all bit flags? Because it's a small number? Does it matter? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f194.google.com ([209.85.220.194]:42502 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751405AbeCPMAS (ORCPT ); Fri, 16 Mar 2018 08:00:18 -0400 MIME-Version: 1.0 In-Reply-To: <9c6289e4-23dd-c79b-bd1f-058d843739d2@cogentembedded.com> References: <1521029386-29975-1-git-send-email-geert+renesas@glider.be> <1521029386-29975-3-git-send-email-geert+renesas@glider.be> <9c6289e4-23dd-c79b-bd1f-058d843739d2@cogentembedded.com> From: Geert Uytterhoeven Date: Fri, 16 Mar 2018 13:00:12 +0100 Message-ID: Subject: Re: [PATCH v2 2/3] arm64: dts: renesas: salvator-common: Configure PMIC for DDR Backup Power To: Sergei Shtylyov Cc: Geert Uytterhoeven , Simon Horman , Magnus Damm , Marek Vasut , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM Content-Type: text/plain; charset="UTF-8" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Sergei, On Wed, Mar 14, 2018 at 4:17 PM, Sergei Shtylyov wrote: > On 03/14/2018 03:09 PM, Geert Uytterhoeven wrote: >> On Salvator-X(S), all of the DDR0, DDR1, DDR0C, and DDR1C power rails >> need to be kept powered when backup mode is enabled. Reflect this in >> the "rohm,ddr-backup-power" property for the BD9571MWV PMIC node. >> >> The accessory power switch (SW23) is a toggle switch, hense specify >> "rohm,rstbmode-level". >> >> Signed-off-by: Geert Uytterhoeven >> --- >> v2: >> - Add rohm,rstbmode-level. >> --- >> arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi >> index 2a7f36abd2dd85c6..80794c38c2669d75 100644 >> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi >> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi >> @@ -376,6 +376,8 @@ >> #interrupt-cells = <2>; >> gpio-controller; >> #gpio-cells = <2>; >> + rohm,ddr-backup-power = <15>; > > Why not 0xf if those are all bit flags? Because it's a small number? Does it matter? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 From: geert@linux-m68k.org (Geert Uytterhoeven) Date: Fri, 16 Mar 2018 13:00:12 +0100 Subject: [PATCH v2 2/3] arm64: dts: renesas: salvator-common: Configure PMIC for DDR Backup Power In-Reply-To: <9c6289e4-23dd-c79b-bd1f-058d843739d2@cogentembedded.com> References: <1521029386-29975-1-git-send-email-geert+renesas@glider.be> <1521029386-29975-3-git-send-email-geert+renesas@glider.be> <9c6289e4-23dd-c79b-bd1f-058d843739d2@cogentembedded.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Sergei, On Wed, Mar 14, 2018 at 4:17 PM, Sergei Shtylyov wrote: > On 03/14/2018 03:09 PM, Geert Uytterhoeven wrote: >> On Salvator-X(S), all of the DDR0, DDR1, DDR0C, and DDR1C power rails >> need to be kept powered when backup mode is enabled. Reflect this in >> the "rohm,ddr-backup-power" property for the BD9571MWV PMIC node. >> >> The accessory power switch (SW23) is a toggle switch, hense specify >> "rohm,rstbmode-level". >> >> Signed-off-by: Geert Uytterhoeven >> --- >> v2: >> - Add rohm,rstbmode-level. >> --- >> arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi >> index 2a7f36abd2dd85c6..80794c38c2669d75 100644 >> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi >> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi >> @@ -376,6 +376,8 @@ >> #interrupt-cells = <2>; >> gpio-controller; >> #gpio-cells = <2>; >> + rohm,ddr-backup-power = <15>; > > Why not 0xf if those are all bit flags? Because it's a small number? Does it matter? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds