From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Date: Fri, 01 Jul 2016 08:57:00 +0000 Subject: Re: [PATCH v4 14/22] sh: SH7751 core dtsi Message-Id: List-Id: References: <1467207667-15768-1-git-send-email-ysato@users.sourceforge.jp> <1467207667-15768-15-git-send-email-ysato@users.sourceforge.jp> In-Reply-To: <1467207667-15768-15-git-send-email-ysato@users.sourceforge.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Yoshinori Sato Cc: "devicetree@vger.kernel.org" , Linux-sh list , "linux-kernel@vger.kernel.org" Hi Sato-san, On Wed, Jun 29, 2016 at 3:40 PM, Yoshinori Sato wrote: > SH7751 core and internal peripheral define. Thanks for your patch! > Changes v4 > - remove unneeded #address-cells and #size-cells > - add missing dt-binding link Please move changelog information below the three dashes... > > Signed-off-by: Yoshinori Sato > --- ... i.e. here. > --- /dev/null > +++ b/arch/sh/boot/dts/include/dt-bindings > @@ -0,0 +1 @@ > +../../../../../include/dt-bindings > \ No newline at end of file Missing newline. > --- /dev/null > +++ b/arch/sh/boot/dts/sh7751.dtsi > + oclk: oscillator { > + #clock-cells = <0>; > + compatible = "fixed-clock"; > + clock-frequency = <0>; > + }; > + cpg: cpg@ffc00000 { clock-controller@ffc00000 > \ No newline at end of file Missing newline. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752556AbcGAI5G (ORCPT ); Fri, 1 Jul 2016 04:57:06 -0400 Received: from mail-it0-f66.google.com ([209.85.214.66]:36022 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752470AbcGAI5C (ORCPT ); Fri, 1 Jul 2016 04:57:02 -0400 MIME-Version: 1.0 In-Reply-To: <1467207667-15768-15-git-send-email-ysato@users.sourceforge.jp> References: <1467207667-15768-1-git-send-email-ysato@users.sourceforge.jp> <1467207667-15768-15-git-send-email-ysato@users.sourceforge.jp> From: Geert Uytterhoeven Date: Fri, 1 Jul 2016 10:57:00 +0200 X-Google-Sender-Auth: khshIdCDJDikqsPtT64yt4gFx58 Message-ID: Subject: Re: [PATCH v4 14/22] sh: SH7751 core dtsi To: Yoshinori Sato Cc: "devicetree@vger.kernel.org" , Linux-sh list , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sato-san, On Wed, Jun 29, 2016 at 3:40 PM, Yoshinori Sato wrote: > SH7751 core and internal peripheral define. Thanks for your patch! > Changes v4 > - remove unneeded #address-cells and #size-cells > - add missing dt-binding link Please move changelog information below the three dashes... > > Signed-off-by: Yoshinori Sato > --- ... i.e. here. > --- /dev/null > +++ b/arch/sh/boot/dts/include/dt-bindings > @@ -0,0 +1 @@ > +../../../../../include/dt-bindings > \ No newline at end of file Missing newline. > --- /dev/null > +++ b/arch/sh/boot/dts/sh7751.dtsi > + oclk: oscillator { > + #clock-cells = <0>; > + compatible = "fixed-clock"; > + clock-frequency = <0>; > + }; > + cpg: cpg@ffc00000 { clock-controller@ffc00000 > \ No newline at end of file Missing newline. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds