All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/3] dt-bindings: timer: renesas,cmt: Add r8a779f0 and generic Gen4 CMT support
Date: Tue, 19 Jul 2022 14:19:12 +0200	[thread overview]
Message-ID: <CAMuHMdUO_nR_b_+76LVEeTU87APW9GiMPhoMOV6KDQrtwCaaSw@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdUYwTLehX8Q-Qk8rar7K2Ag4oN369+9X7pzvreGdRoZag@mail.gmail.com>

Hi Wolfram,

On Tue, Jul 19, 2022 at 9:57 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Wed, Jul 13, 2022 at 12:06 PM Wolfram Sang
> <wsa+renesas@sang-engineering.com> wrote:
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> Thanks for your patch!
>
> > --- a/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
> > +++ b/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
> > @@ -83,6 +83,11 @@ properties:
> >                - renesas,r8a779a0-cmt0     # 32-bit CMT0 on R-Car V3U
> >            - const: renesas,rcar-gen3-cmt0 # 32-bit CMT0 on R-Car Gen3 and RZ/G2
> >
> > +      - items:
> > +          - enum:
> > +              - renesas,r8a779f0-cmt0     # 32-bit CMT0 on R-Car S4-8
> > +          - const: renesas,rcar-gen4-cmt0 # 32-bit CMT0 on R-Car Gen4
> > +
> >        - items:
> >            - enum:
> >                - renesas,r8a774a1-cmt1     # 48-bit CMT on RZ/G2M
> > @@ -100,6 +105,11 @@ properties:
> >                - renesas,r8a779a0-cmt1     # 48-bit CMT on R-Car V3U
> >            - const: renesas,rcar-gen3-cmt1 # 48-bit CMT on R-Car Gen3 and RZ/G2
> >
> > +      - items:
> > +          - enum:
> > +              - renesas,r8a779f0-cmt1     # 48-bit CMT on R-Car S4-8
> > +          - const: renesas,rcar-gen4-cmt1 # 48-bit CMT on R-Car Gen4
> > +
> >    reg:
> >      maxItems: 1
>
> The above is correct, but you forgot to update the conditional sections
> specifying the number of interrupts.

However, it would have been nice to adhere to the existing sort order
in the file... I will prepare a patch for both issues...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2022-07-19 12:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-13 10:06 [PATCH 0/3] clocksource: sh_cmt: add Gen4 and r8a779f0 support Wolfram Sang
2022-07-13 10:06 ` [PATCH 1/3] dt-bindings: timer: renesas,cmt: Add r8a779f0 and generic Gen4 CMT support Wolfram Sang
2022-07-15 22:35   ` Daniel Lezcano
2022-07-19  8:51     ` Krzysztof Kozlowski
2022-07-18 20:50   ` Rob Herring
2022-07-19  7:57   ` Geert Uytterhoeven
2022-07-19 12:19     ` Geert Uytterhoeven [this message]
2022-07-28 10:44   ` [tip: timers/core] " tip-bot2 for Wolfram Sang
2022-07-13 10:06 ` [PATCH 2/3] dt-bindings: timer: renesas,cmt: R-Car V3U is R-Car Gen4 Wolfram Sang
2022-07-18 20:51   ` Rob Herring
2022-07-19  7:58   ` Geert Uytterhoeven
2022-07-28 10:44   ` [tip: timers/core] " tip-bot2 for Wolfram Sang
2022-07-13 10:06 ` [PATCH 3/3] clocksource/drivers/sh_cmt: Add R-Car Gen4 support Wolfram Sang
2022-07-19  8:04   ` Geert Uytterhoeven
2022-07-28 10:44   ` [tip: timers/core] " tip-bot2 for Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdUO_nR_b_+76LVEeTU87APW9GiMPhoMOV6KDQrtwCaaSw@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.