All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] media: i2c: imx219: Drop <linux/clk-provider.h> and <linux/clkdev.h>
@ 2020-05-06 12:03 Geert Uytterhoeven
  2020-05-12 21:13 ` Stephen Boyd
  2020-05-14 13:12 ` Dave Stevenson
  0 siblings, 2 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2020-05-06 12:03 UTC (permalink / raw)
  To: Dave Stevenson, Mauro Carvalho Chehab
  Cc: linux-media, linux-clk, Geert Uytterhoeven

The IMX219 camera driver is not a clock provider, but merely a clock
consumer, and thus does not need to include <linux/clk-provider.h> and
<linux/clkdev.h>.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/media/i2c/imx219.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
index cb03bdec1f9c8954..078f2093d881d7c2 100644
--- a/drivers/media/i2c/imx219.c
+++ b/drivers/media/i2c/imx219.c
@@ -15,8 +15,6 @@
  */
 
 #include <linux/clk.h>
-#include <linux/clk-provider.h>
-#include <linux/clkdev.h>
 #include <linux/delay.h>
 #include <linux/gpio/consumer.h>
 #include <linux/i2c.h>
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] media: i2c: imx219: Drop <linux/clk-provider.h> and <linux/clkdev.h>
  2020-05-06 12:03 [PATCH] media: i2c: imx219: Drop <linux/clk-provider.h> and <linux/clkdev.h> Geert Uytterhoeven
@ 2020-05-12 21:13 ` Stephen Boyd
  2020-05-14 13:12 ` Dave Stevenson
  1 sibling, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2020-05-12 21:13 UTC (permalink / raw)
  To: Dave Stevenson, Geert Uytterhoeven, Mauro Carvalho Chehab
  Cc: linux-media, linux-clk, Geert Uytterhoeven

Quoting Geert Uytterhoeven (2020-05-06 05:03:04)
> The IMX219 camera driver is not a clock provider, but merely a clock
> consumer, and thus does not need to include <linux/clk-provider.h> and
> <linux/clkdev.h>.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---

Reviewed-by: Stephen Boyd <sboyd@kernel.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] media: i2c: imx219: Drop <linux/clk-provider.h> and <linux/clkdev.h>
  2020-05-06 12:03 [PATCH] media: i2c: imx219: Drop <linux/clk-provider.h> and <linux/clkdev.h> Geert Uytterhoeven
  2020-05-12 21:13 ` Stephen Boyd
@ 2020-05-14 13:12 ` Dave Stevenson
  2020-05-14 13:23   ` Geert Uytterhoeven
  1 sibling, 1 reply; 4+ messages in thread
From: Dave Stevenson @ 2020-05-14 13:12 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Mauro Carvalho Chehab, Linux Media Mailing List, linux-clk

On Wed, 6 May 2020 at 13:03, Geert Uytterhoeven <geert+renesas@glider.be> wrote:
>
> The IMX219 camera driver is not a clock provider, but merely a clock
> consumer, and thus does not need to include <linux/clk-provider.h> and
> <linux/clkdev.h>.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

I'm no expert on the clock frameworks, but that seems logical.
Acked-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

The same appears to be true for drivers/media/i2c/ov5640.c unless it's
been fixed since 5.7-rc5.

> ---
>  drivers/media/i2c/imx219.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
> index cb03bdec1f9c8954..078f2093d881d7c2 100644
> --- a/drivers/media/i2c/imx219.c
> +++ b/drivers/media/i2c/imx219.c
> @@ -15,8 +15,6 @@
>   */
>
>  #include <linux/clk.h>
> -#include <linux/clk-provider.h>
> -#include <linux/clkdev.h>
>  #include <linux/delay.h>
>  #include <linux/gpio/consumer.h>
>  #include <linux/i2c.h>
> --
> 2.17.1
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] media: i2c: imx219: Drop <linux/clk-provider.h> and <linux/clkdev.h>
  2020-05-14 13:12 ` Dave Stevenson
@ 2020-05-14 13:23   ` Geert Uytterhoeven
  0 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2020-05-14 13:23 UTC (permalink / raw)
  To: Dave Stevenson; +Cc: Mauro Carvalho Chehab, Linux Media Mailing List, linux-clk

Hi Dave

On Thu, May 14, 2020 at 3:12 PM Dave Stevenson
<dave.stevenson@raspberrypi.com> wrote:
> On Wed, 6 May 2020 at 13:03, Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> > The IMX219 camera driver is not a clock provider, but merely a clock
> > consumer, and thus does not need to include <linux/clk-provider.h> and
> > <linux/clkdev.h>.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> I'm no expert on the clock frameworks, but that seems logical.
> Acked-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

Thank you.

> The same appears to be true for drivers/media/i2c/ov5640.c unless it's
> been fixed since 5.7-rc5.

Quite possible: I did a sweep a while ago, and looked at recently introduced
offenders, but I may have missed some.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-05-14 13:24 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-06 12:03 [PATCH] media: i2c: imx219: Drop <linux/clk-provider.h> and <linux/clkdev.h> Geert Uytterhoeven
2020-05-12 21:13 ` Stephen Boyd
2020-05-14 13:12 ` Dave Stevenson
2020-05-14 13:23   ` Geert Uytterhoeven

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.