From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EC21C43381 for ; Thu, 21 Mar 2019 09:52:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7655120850 for ; Thu, 21 Mar 2019 09:52:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728251AbfCUJwH (ORCPT ); Thu, 21 Mar 2019 05:52:07 -0400 Received: from mail-vk1-f196.google.com ([209.85.221.196]:46628 "EHLO mail-vk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728185AbfCUJwH (ORCPT ); Thu, 21 Mar 2019 05:52:07 -0400 Received: by mail-vk1-f196.google.com with SMTP id x2so1213473vkx.13; Thu, 21 Mar 2019 02:52:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YfXC97scgE5/WSTfWZCZ+LptrPYQs6I5IlaeA1QxGo8=; b=oX1qc5OjsGpMhLd2NtSo1Ah7rziqnQ2uyrb7McfmfqMsA0NeByf6TatvmS3u0PIpwU mQV/DpfMkH+xizUYdFCt4W34g4wd0lSHARMlAs+yCWO/rRNnka01q7HyywLnSd3hhi+q 4OF774UEooVfh4brDy1BV5OMCyaRuhKqnEsIsKB5GtqP/MTFm5SvwS5lW6+Cjy8OHklF ID1Od1NcPV8uAadLgJ+/v00WYqbXvV76st65xYhtS75BnuohhL0Uqnx6AAceFHjEW+br EA0xH70zskcttG2Btgw89GV0e52/mrn9SZ9PobGIsbCWpYAa0+YHH3mQ4qP1Yin+CzLS wbkg== X-Gm-Message-State: APjAAAUBTDujwMCBE9WPL2TQlbcBBGKdZLjbUar8hn9ZNYQ/j0QmTPFD pujk1nmbke/QgXEkDkTV+CPMtMAugco0WpT6V5lM5i6j X-Google-Smtp-Source: APXvYqypV501n3ej3LaNzKxFwflLxYx3Q5/ghUEw9KgiFawhSPEAT21owLSVpTTHjJ9ULyOdC43FIPeUwPKzUMMkxPk= X-Received: by 2002:a1f:a5d3:: with SMTP id o202mr1573355vke.40.1553161925699; Thu, 21 Mar 2019 02:52:05 -0700 (PDT) MIME-Version: 1.0 References: <20190320113010.8955-1-alexandre.belloni@bootlin.com> <20190320113010.8955-2-alexandre.belloni@bootlin.com> In-Reply-To: <20190320113010.8955-2-alexandre.belloni@bootlin.com> From: Geert Uytterhoeven Date: Thu, 21 Mar 2019 10:51:53 +0100 Message-ID: Subject: Re: [PATCH 2/3] rtc: sh: fix possible race condition To: Alexandre Belloni Cc: linux-rtc@vger.kernel.org, Linux ARM , Geert Uytterhoeven , Chris Brandt , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On Wed, Mar 20, 2019 at 12:30 PM Alexandre Belloni wrote: > The IRQ is requested before the struct rtc is allocated and registered, but > this struct is used in the IRQ handler. This may lead to a NULL pointer > dereference. > > Switch to devm_rtc_allocate_device/rtc_register_device to allocate the rtc > struct before requesting the IRQ. > > Signed-off-by: Alexandre Belloni Reviewed-by: Geert Uytterhoeven Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A051C43381 for ; Thu, 21 Mar 2019 09:52:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD94720850 for ; Thu, 21 Mar 2019 09:52:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QDkZO7PW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD94720850 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=whmhEZKWjGYUJty9/YTjEAeDBuGf+yBP2W0lz3Z4jbo=; b=QDkZO7PW6a6kCX xrmBIp8vpLpnR+ZJxL7C97/hJ+80v6PPmWSu+qlGyYu5nlsRpCip6sMAwCo1wFG1SlKnu++PhczAz u71ZpnJG2EhOBM//+TtjZECwQUYAudTxQqHFOtQguUDH63Md+h70/kDvxg+JUw/obtDSd8rkgTtdk l6RRkOr/pQATr/xPne9aPYHF/XYnhmQu7pwcfUVOn7mui/Mhs3DRxp4/4BUCvI5MLdEmFKhMp1nty qS7vRTCVjTZD9fU/g3lCm2Xc6+v+zBXYpFd+efUJ0IlCvKQgKU7RjPel63YGgtgqEtbkekD/ceYTB IScz0G+UKTW+py3pdWGA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6uMu-0001qz-BX; Thu, 21 Mar 2019 09:52:12 +0000 Received: from mail-vk1-f196.google.com ([209.85.221.196]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6uMo-0001ph-MV for linux-arm-kernel@lists.infradead.org; Thu, 21 Mar 2019 09:52:10 +0000 Received: by mail-vk1-f196.google.com with SMTP id i68so1217546vke.6 for ; Thu, 21 Mar 2019 02:52:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YfXC97scgE5/WSTfWZCZ+LptrPYQs6I5IlaeA1QxGo8=; b=I7ouBYaZmyELCS8nXZyxn2gP7Nduc+OlG48oFH6Kp3moa5Y5XOK7KZmQ81UVvChSnY cd4QUXJaed9YUunylFyME21Mvz6LgDg7pChuOvZs0MazTk5DxBdIkEhu1U8sT7MSksZC cS81bJ3Q/T/V8zQTXJgAiKmVjePdwfSIfxX8Z483NM0TJy7qmBSmfBl3htemejzbQb0e 18jSiVs4QNzOYqyQKP0eGFhTwTsbESHNfQJYbySQf3sJGb9UvlBjHlBWW/CqlldF0DDM 9VjR+Hyl4uyakMVMIqeSBQqqtkPdDojnynzDS89vv3AkZDUU0+cXlDFW5fqsSMjpnoyR Kb5g== X-Gm-Message-State: APjAAAXDvsPJehoim/UkD3SjWzBcWo2meg5soV1ZtQ/f0PG6vsGG7ll6 NKVE//KJogRirEXXU9PXImm57F1aoTt0Uy0hNvU= X-Google-Smtp-Source: APXvYqypV501n3ej3LaNzKxFwflLxYx3Q5/ghUEw9KgiFawhSPEAT21owLSVpTTHjJ9ULyOdC43FIPeUwPKzUMMkxPk= X-Received: by 2002:a1f:a5d3:: with SMTP id o202mr1573355vke.40.1553161925699; Thu, 21 Mar 2019 02:52:05 -0700 (PDT) MIME-Version: 1.0 References: <20190320113010.8955-1-alexandre.belloni@bootlin.com> <20190320113010.8955-2-alexandre.belloni@bootlin.com> In-Reply-To: <20190320113010.8955-2-alexandre.belloni@bootlin.com> From: Geert Uytterhoeven Date: Thu, 21 Mar 2019 10:51:53 +0100 Message-ID: Subject: Re: [PATCH 2/3] rtc: sh: fix possible race condition To: Alexandre Belloni X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190321_025206_817664_3429D5A2 X-CRM114-Status: GOOD ( 10.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, Linux-Renesas , Chris Brandt , Geert Uytterhoeven , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 20, 2019 at 12:30 PM Alexandre Belloni wrote: > The IRQ is requested before the struct rtc is allocated and registered, but > this struct is used in the IRQ handler. This may lead to a NULL pointer > dereference. > > Switch to devm_rtc_allocate_device/rtc_register_device to allocate the rtc > struct before requesting the IRQ. > > Signed-off-by: Alexandre Belloni Reviewed-by: Geert Uytterhoeven Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel