From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f194.google.com ([209.85.223.194]:35089 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751422AbcEKIle (ORCPT ); Wed, 11 May 2016 04:41:34 -0400 Received: by mail-io0-f194.google.com with SMTP id i75so4340933ioa.2 for ; Wed, 11 May 2016 01:41:33 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <40fe97f4-43e4-6a4a-6c26-d76d6f44138f@de.bosch.com> References: <1462944578-1220-1-git-send-email-dirk.behme@de.bosch.com> <1462944578-1220-2-git-send-email-dirk.behme@de.bosch.com> <40fe97f4-43e4-6a4a-6c26-d76d6f44138f@de.bosch.com> Date: Wed, 11 May 2016 10:41:32 +0200 Message-ID: Subject: Re: [PATCH v2 01/10] boot-mode-reg: Add core From: Geert Uytterhoeven To: Dirk Behme Cc: Geert Uytterhoeven , Simon Horman , linux-renesas-soc@vger.kernel.org, Dirk Behme Content-Type: text/plain; charset=UTF-8 Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Dirk, On Wed, May 11, 2016 at 10:39 AM, Dirk Behme wrote: > On 11.05.2016 09:54, Geert Uytterhoeven wrote: >> On Wed, May 11, 2016 at 7:29 AM, Dirk Behme >> wrote: >>> >>> --- /dev/null >>> +++ b/drivers/misc/boot-mode-reg/core.c >> >>> +/** >>> + * boot_mode_reg_set() - record boot mode register value >>> + * @mode: implementation-dependent boot mode register value >>> + * >>> + * Records the boot mode register value which may subsequently >>> + * be retrieved using boot_mode_reg_get(). >>> + * >>> + * return: 0 on success >>> + */ >>> +int boot_mode_reg_set(u32 mode) >>> +{ >>> + int err = -EBUSY; >>> + >>> + mutex_lock(&boot_mode_mutex); >>> + if (!boot_mode_is_set) { >> >> You've dropped the check for calling this function a subsequent time with >> a different value of mode? > > Sometimes inverting 'complex' if statements is not that easy ;) > > You mean > > if (!boot_mode_is_set || boot_mode != mode) No, De Morgan says if (!boot_mode_is_set || boot_mode == mode) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds