From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH 1/2] dt-bindings: GPIO: Add generic serializer binding Date: Thu, 17 Dec 2015 09:28:09 +0100 Message-ID: References: <1449863184-29668-1-git-send-email-afd@ti.com> <1449863184-29668-2-git-send-email-afd@ti.com> <566EF12C.4060509@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-ob0-f194.google.com ([209.85.214.194]:36052 "EHLO mail-ob0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754718AbbLQI2K (ORCPT ); Thu, 17 Dec 2015 03:28:10 -0500 In-Reply-To: <566EF12C.4060509@ti.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: "Andrew F. Davis" Cc: Linus Walleij , "linux-spi@vger.kernel.org" , Mark Brown , Alexandre Courbot , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" On Mon, Dec 14, 2015 at 5:41 PM, Andrew F. Davis wrote: > What I'm worried about looks to have happened with the gpio-74x164 > driver, this is kind of the companion device to mine (74164 / 74165) > and should work with any 74164 compatible shift register (possibly 100s > of versions of them), but the compatible string that was added is > "fairchild,74hc595", a relatively new device by a single manufacturer. In hindsight, that probably should have been "motorola,mc74hc595" instead. Recently I read that Motorola invented the 74hc59x for their "new" SPI bus as that time, as the 74164 is not 100% SPI-compatible. Given the limitations of the '164 for SPI, is the same true for '165, and should it be "[...]74[...]597" instead? > The problem this has is then that boards will use this compatible string > even if the parts are not actually the Fairchild version, just to get > the match, when they should be using a generic string. They're all supposed to be "compatible". Personally, I wouldn't object to just "74595", cfr. "ns16550a". Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds