From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH/RFC v3 02/22] soc: renesas: Add R-Car RST driver Date: Fri, 10 Jun 2016 09:54:22 +0200 Message-ID: References: <1464808880-343-1-git-send-email-geert+renesas@glider.be> <1464808880-343-3-git-send-email-geert+renesas@glider.be> <6849015.bJCuAeaMgZ@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <6849015.bJCuAeaMgZ@avalon> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Laurent Pinchart Cc: Geert Uytterhoeven , Simon Horman , Magnus Damm , Laurent Pinchart , Philipp Zabel , Michael Turquette , Stephen Boyd , Dirk Behme , linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org Hi Laurent, On Thu, Jun 2, 2016 at 11:58 PM, Laurent Pinchart wrote: >> --- /dev/null >> +++ b/drivers/soc/renesas/rcar-rst.c >> +static int __init rcar_rst_init(void) >> +{ [...] >> +} >> +arch_initcall(rcar_rst_init); > > Given that rcar_rst_init() is only used as a support function for > rcar_rst_read_mode_pins(), how about removing the initcall ? Thanks, good idea! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f194.google.com ([209.85.223.194]:35447 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751339AbcFJHyY (ORCPT ); Fri, 10 Jun 2016 03:54:24 -0400 MIME-Version: 1.0 In-Reply-To: <6849015.bJCuAeaMgZ@avalon> References: <1464808880-343-1-git-send-email-geert+renesas@glider.be> <1464808880-343-3-git-send-email-geert+renesas@glider.be> <6849015.bJCuAeaMgZ@avalon> From: Geert Uytterhoeven Date: Fri, 10 Jun 2016 09:54:22 +0200 Message-ID: Subject: Re: [PATCH/RFC v3 02/22] soc: renesas: Add R-Car RST driver To: Laurent Pinchart Cc: Geert Uytterhoeven , Simon Horman , Magnus Damm , Laurent Pinchart , Philipp Zabel , Michael Turquette , Stephen Boyd , Dirk Behme , linux-renesas-soc@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Laurent, On Thu, Jun 2, 2016 at 11:58 PM, Laurent Pinchart wrote: >> --- /dev/null >> +++ b/drivers/soc/renesas/rcar-rst.c >> +static int __init rcar_rst_init(void) >> +{ [...] >> +} >> +arch_initcall(rcar_rst_init); > > Given that rcar_rst_init() is only used as a support function for > rcar_rst_read_mode_pins(), how about removing the initcall ? Thanks, good idea! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 From: geert@linux-m68k.org (Geert Uytterhoeven) Date: Fri, 10 Jun 2016 09:54:22 +0200 Subject: [PATCH/RFC v3 02/22] soc: renesas: Add R-Car RST driver In-Reply-To: <6849015.bJCuAeaMgZ@avalon> References: <1464808880-343-1-git-send-email-geert+renesas@glider.be> <1464808880-343-3-git-send-email-geert+renesas@glider.be> <6849015.bJCuAeaMgZ@avalon> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Laurent, On Thu, Jun 2, 2016 at 11:58 PM, Laurent Pinchart wrote: >> --- /dev/null >> +++ b/drivers/soc/renesas/rcar-rst.c >> +static int __init rcar_rst_init(void) >> +{ [...] >> +} >> +arch_initcall(rcar_rst_init); > > Given that rcar_rst_init() is only used as a support function for > rcar_rst_read_mode_pins(), how about removing the initcall ? Thanks, good idea! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds