From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3B1FC47095 for ; Mon, 7 Jun 2021 14:36:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9BE8E6105A for ; Mon, 7 Jun 2021 14:36:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230314AbhFGOi2 (ORCPT ); Mon, 7 Jun 2021 10:38:28 -0400 Received: from mail-vs1-f43.google.com ([209.85.217.43]:42977 "EHLO mail-vs1-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230211AbhFGOiZ (ORCPT ); Mon, 7 Jun 2021 10:38:25 -0400 Received: by mail-vs1-f43.google.com with SMTP id l25so9014179vsb.9; Mon, 07 Jun 2021 07:36:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pIEuZnR+0pmXVTw7szVUo35cG2jdA3wDrXhvKfhXtfw=; b=MYWo4n5/V0cE9jW9vhsOU3soporjzpABamtmErooD//Rm9pABY9QRuI7ccOvF64cFF l6qWRUOBCP9w50lrRSdVzH6S4in16tWiAs4IE6OCXiXs2dydkE0pp39OeW0VclJTB27p A8Zf8ZMbSg2OMmhX7p1/NN58feXXnmlD2vEK3xjxGAINKrlVUKEnImIKDm67I1U0qRK7 aXv3O41NsLKhicogVYeK9STnYCsIUCe7P+XeqRA273/lpJ9oWsaGsiGqIGnDA7kdxfjt jS+Ayds4+U4UDaGcjw5k4chDIjk+SqIFKbrzzEM0Kdn/iWuiIEEN3Id0V+p9V3rQOxZk Y4Cw== X-Gm-Message-State: AOAM532AJK2Pq/F2cm3E4/eT8y3zqBbeVRCVy6NzAKFY7th5PPv1u3Ki 4L35muQMYkE9zuK2a2SbC80aqAIJvTQ7Zzs6y3g= X-Google-Smtp-Source: ABdhPJyAB7LObhZVr6DP0FIXQJk11mzn8e1kVEmnHMYa9jjp3/mzqxniD/pQfzoaiVG47ccHD0gA31WHIrO2gUawgA8= X-Received: by 2002:a05:6102:c4c:: with SMTP id y12mr4961726vss.18.1623076594247; Mon, 07 Jun 2021 07:36:34 -0700 (PDT) MIME-Version: 1.0 References: <20210527001251.8529-1-rdunlap@infradead.org> In-Reply-To: From: Geert Uytterhoeven Date: Mon, 7 Jun 2021 16:36:23 +0200 Message-ID: Subject: Re: [PATCH v2] MOUSE_ATARI: fix kconfig unmet dependency warning To: Dmitry Torokhov Cc: Randy Dunlap , Linux Kernel Mailing List , Michael Schmitz , Roman Zippel , linux-input , linux-m68k , Michael Schmitz Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dmitry, On Wed, Jun 2, 2021 at 6:15 AM Dmitry Torokhov wrote: > On Thu, May 27, 2021 at 08:56:30AM +0200, Geert Uytterhoeven wrote: > > On Thu, May 27, 2021 at 2:12 AM Randy Dunlap wrote: > > > Since the code for ATARI_KBD_CORE does not use drivers/input/keyboard/ > > > code, just move ATARI_KBD_CORE to arch/m68k/Kconfig.machine to remove > > > this dependency. > > > > > > Removes this kconfig warning: > > > > > > WARNING: unmet direct dependencies detected for ATARI_KBD_CORE > > > Depends on [n]: !UML && INPUT [=y] && INPUT_KEYBOARD [=n] > > > Selected by [y]: > > > - MOUSE_ATARI [=y] && !UML && INPUT [=y] && INPUT_MOUSE [=y] && ATARI [=y] > > > > > > Fixes: c04cb856e20a ("m68k: Atari keyboard and mouse support.") > > > Signed-off-by: Randy Dunlap > > > Cc: Michael Schmitz > > > Cc: Roman Zippel > > > Cc: Geert Uytterhoeven > > > Cc: Dmitry Torokhov > > > Cc: linux-input@vger.kernel.org > > > Cc: linux-m68k@lists.linux-m68k.org > > > Suggested-by: Geert Uytterhoeven > > > Suggested-by: Michael Schmitz > > > > > --- > > > v2: move the symbol outside of INPUT_KEYBOARD (Geert) -- all the way > > > to Kconfig.machine (Michael). Thanks. > > > > Acked-by: Geert Uytterhoeven > > > > I'm willing to queue this in the m68k for-v5.14 branch, if Dmitry agrees. > > Sure, works for me. > > Acked-by: Dmitry Torokhov Thanks, queue in the m68k for-v5.14 branch. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds