From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FC4DC63797 for ; Mon, 16 Jan 2023 11:24:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229753AbjAPLYO (ORCPT ); Mon, 16 Jan 2023 06:24:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229725AbjAPLYN (ORCPT ); Mon, 16 Jan 2023 06:24:13 -0500 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 386CE1DB99; Mon, 16 Jan 2023 03:24:12 -0800 (PST) Received: by mail-qt1-f181.google.com with SMTP id a25so17169593qto.10; Mon, 16 Jan 2023 03:24:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CC4suAhGO9ZHb6FRYObqt22bnmss3lWiFC78zfUA2eM=; b=mTOWoxz7ofZIOyrzMCaoJ/HqTKY7yAtpCE1TBBaSG2EtAxdCpJfSHs1ATwFU17i/td wLaO8kEAjynVJoSgt6ksTYM/YSCaEcjUQV2kCTdXh88CoSxB/3q0eyfTFHYiziB36UsS uHCl8bR2Q37TbCANGzsxmB6DNtsmZexfO+Ef+LzD9o7Wlj+l+JFR4YmDw9x67E15x5Y3 GcqcNtsn6DwkHdcburUpUP5i0GJnGPAw/oe/a/kaodFXb5qPLFhv1GuJ+MiEaHcte0dg 37ql1pAM2X7prkxDGBojjhscPLbXs4I4boYrbvsrMoQpuKMXhvoLUVUNnLmZ+4FVUsK/ I7dA== X-Gm-Message-State: AFqh2kofp8xWVefulEV9LKX2M9kcjP5u301HQNu+SDSM9aVpH3wY9cwW ZpeeS1HbgdJlPI20lh43jLlAiBAxmVxcrA== X-Google-Smtp-Source: AMrXdXvdKCW1wbPSwJTc7wusNhZ1ifzOTrnmMSqaWrNlKe61nAkhdk1ACCEtU65usp7hZHjwcY7XkA== X-Received: by 2002:ac8:5401:0:b0:39c:da20:616 with SMTP id b1-20020ac85401000000b0039cda200616mr30272908qtq.32.1673868251120; Mon, 16 Jan 2023 03:24:11 -0800 (PST) Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com. [209.85.128.180]) by smtp.gmail.com with ESMTPSA id he34-20020a05622a602200b00399fe4aac3esm9854772qtb.50.2023.01.16.03.24.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Jan 2023 03:24:10 -0800 (PST) Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-4a2f8ad29d5so375866657b3.8; Mon, 16 Jan 2023 03:24:09 -0800 (PST) X-Received: by 2002:a81:578e:0:b0:4d9:3858:392 with SMTP id l136-20020a81578e000000b004d938580392mr1318541ywb.502.1673868249495; Mon, 16 Jan 2023 03:24:09 -0800 (PST) MIME-Version: 1.0 References: <20220615221410.27459-1-laurent.pinchart@ideasonboard.com> <20220615221410.27459-6-laurent.pinchart@ideasonboard.com> In-Reply-To: From: Geert Uytterhoeven Date: Mon, 16 Jan 2023 12:23:58 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros To: Laurent Pinchart Cc: devicetree@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, Rob Herring , Sakari Ailus , Jacopo Mondi , Eugen Hristev , Hugues Fruchet , Maxime Coquelin , Alexandre Torgue , Lad Prabhakar , Fabio Estevam , Shawn Guo , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Laurent, On Mon, Jan 16, 2023 at 11:49 AM Laurent Pinchart wrote: > On Mon, Jan 16, 2023 at 11:44:13AM +0100, Geert Uytterhoeven wrote: > > On Mon, Jan 16, 2023 at 11:38 AM Laurent Pinchart wrote: > > > On Mon, Jan 16, 2023 at 11:24:10AM +0100, Geert Uytterhoeven wrote: > > > > On Sat, Jan 14, 2023 at 4:26 PM Laurent Pinchart wrote: > > > > > Geert, could you please take this in your tree for v6.3 ? The two > > > > > patches that the DT changes depend on have been merged in v6.2. > > > > > > > > Thank you, I had missed these. > > > > > > > > > On Thu, Jun 16, 2022 at 01:14:09AM +0300, Laurent Pinchart wrote: > > > > > > Now that a header exists with macros for the media interface bus-type > > > > > > values, replace hardcoding numerical constants with the corresponding > > > > > > macros in the DT sources. > > > > > > > > > > > > Signed-off-by: Laurent Pinchart > > > > > > > > Reviewed-by: Geert Uytterhoeven > > > > > > > > > > --- > > > > > > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 11 +++++++---- > > > > > > .../dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi | 4 +++- > > > > > > .../dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi | 4 +++- > > > > > > 3 files changed, 13 insertions(+), 6 deletions(-) > > > > > > > > > > > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts > > > > > > index 4e58c54cde17..33ac4bd1e63b 100644 > > > > > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts > > > > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts > > > > > > @@ -7,6 +7,9 @@ > > > > > > */ > > > > > > > > > > > > /dts-v1/; > > > > > > + > > > > > > +#include > > > > > > + > > > > > > #include "r8a7742-iwg21d-q7.dts" > > > > > > > > > > > > / { > > > > > > @@ -242,7 +245,7 @@ port { > > > > > > vin0ep: endpoint { > > > > > > remote-endpoint = <&cam0ep>; > > > > > > bus-width = <8>; > > > > > > - bus-type = <6>; > > > > > > + bus-type = ; > > > > > > }; > > > > > > }; > > > > > > }; > > > > > > @@ -273,7 +276,7 @@ port { > > > > > > vin1ep: endpoint { > > > > > > remote-endpoint = <&cam1ep>; > > > > > > bus-width = <8>; > > > > > > - bus-type = <6>; > > > > > > + bus-type = ; > > > > > > }; > > > > > > }; > > > > > > }; > > > > > > @@ -305,7 +308,7 @@ vin2ep: endpoint { > > > > > > remote-endpoint = <&cam2ep>; > > > > > > bus-width = <8>; > > > > > > data-shift = <8>; > > > > > > - bus-type = <6>; > > > > > > + bus-type = ; > > > > > > }; > > > > > > }; > > > > > > }; > > > > > > @@ -335,7 +338,7 @@ port { > > > > > > vin3ep: endpoint { > > > > > > remote-endpoint = <&cam3ep>; > > > > > > bus-width = <8>; > > > > > > - bus-type = <6>; > > > > > > + bus-type = ; > > > > > > }; > > > > > > }; > > > > > > }; > > > > > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi > > > > > > index 40cef0b1d1e6..c73160df619d 100644 > > > > > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi > > > > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi > > > > > > @@ -7,6 +7,8 @@ > > > > > > * Copyright (C) 2020 Renesas Electronics Corp. > > > > > > */ > > > > > > > > > > > > +#include > > > > > > > > This .dtsi file is only intended to be included by > > > > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts, which already has > > > > the include. Hence if you don't mind, I would like to drop this part > > > > while applying and queuing in renesas-devel for v6.3. > > > > > > Isn't it better to include headers as needed to avoid depending on > > > indirect includes ? > > > > In general, I agree. > > In this particular case, (the multiple inclusions of) the > > r8a7742-iwg21d-q7-dbcm-ov*-single.dtsi files are tied very intimately > > to r8a7742-iwg21d-q7-dbcm-ca.dts. > > I'd still prefer keeping the #include here, but you're the maintainer > :-) OK, will keep them. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B37BC54EBE for ; Mon, 16 Jan 2023 11:24:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 111BF10E3CD; Mon, 16 Jan 2023 11:24:13 +0000 (UTC) Received: from mail-qv1-f50.google.com (mail-qv1-f50.google.com [209.85.219.50]) by gabe.freedesktop.org (Postfix) with ESMTPS id 69DD010E3CD for ; Mon, 16 Jan 2023 11:24:11 +0000 (UTC) Received: by mail-qv1-f50.google.com with SMTP id y8so19331969qvn.11 for ; Mon, 16 Jan 2023 03:24:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CC4suAhGO9ZHb6FRYObqt22bnmss3lWiFC78zfUA2eM=; b=lsctg8TFUjQPR9Rpz5Ke+QDLKZZ0Yc/eMPWfR4aeRgzj7pJVFaLl2U1sLgs4lIAb6s 3kV69634qX4YC2uFRmn3rrpvO/CKH2BoJ6ZCWeXU5uqIMeZdwuNOuaIhJ+3tKoSwpfU6 4rBTawzdcGuGGAhoD5RII6Vy4W0RjZl2mzw2j8J6ivTBueLrQZoLGX3gTNXe6z51PTST jTfvfVIE7m+Qk7D+7zXn2W7ng3+TTx4/eObeHeokOMvZdYhwyAHw2pK2OL0uWtWZT7O1 G2dEnfkaL2w66m+6pWok+jiyatirEs4eD7vatTv6miGX2Qt0TDMj1xg1LX22+exA1kSa Vqcw== X-Gm-Message-State: AFqh2kpugptIqkPRgEmoDGZ/6pYrTw1kTKPHb7FnwDkgeLZMPfCONqKn iFss5Jb+vYSZcoa/9GARToqQNo/jjT4+sQ== X-Google-Smtp-Source: AMrXdXvf+Jqs+L2njz02SFL/p5GkfFQT2XiszDqHq1+km9xTjcveNJEwAzhxV37xZKt1Z6K29eoFXA== X-Received: by 2002:ad4:5426:0:b0:532:2409:2eec with SMTP id g6-20020ad45426000000b0053224092eecmr25971805qvt.18.1673868250261; Mon, 16 Jan 2023 03:24:10 -0800 (PST) Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com. [209.85.128.180]) by smtp.gmail.com with ESMTPSA id q30-20020a05620a025e00b006fc40dafaa2sm17859680qkn.8.2023.01.16.03.24.09 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Jan 2023 03:24:10 -0800 (PST) Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-4a263c4ddbaso376866307b3.0 for ; Mon, 16 Jan 2023 03:24:09 -0800 (PST) X-Received: by 2002:a81:578e:0:b0:4d9:3858:392 with SMTP id l136-20020a81578e000000b004d938580392mr1318541ywb.502.1673868249495; Mon, 16 Jan 2023 03:24:09 -0800 (PST) MIME-Version: 1.0 References: <20220615221410.27459-1-laurent.pinchart@ideasonboard.com> <20220615221410.27459-6-laurent.pinchart@ideasonboard.com> In-Reply-To: From: Geert Uytterhoeven Date: Mon, 16 Jan 2023 12:23:58 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros To: Laurent Pinchart Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Jacopo Mondi , Maxime Coquelin , Hugues Fruchet , Alexandre Torgue , dri-devel@lists.freedesktop.org, Lad Prabhakar , Linux-Renesas , Rob Herring , Sakari Ailus , Eugen Hristev , Shawn Guo , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Laurent, On Mon, Jan 16, 2023 at 11:49 AM Laurent Pinchart wrote: > On Mon, Jan 16, 2023 at 11:44:13AM +0100, Geert Uytterhoeven wrote: > > On Mon, Jan 16, 2023 at 11:38 AM Laurent Pinchart wrote: > > > On Mon, Jan 16, 2023 at 11:24:10AM +0100, Geert Uytterhoeven wrote: > > > > On Sat, Jan 14, 2023 at 4:26 PM Laurent Pinchart wrote: > > > > > Geert, could you please take this in your tree for v6.3 ? The two > > > > > patches that the DT changes depend on have been merged in v6.2. > > > > > > > > Thank you, I had missed these. > > > > > > > > > On Thu, Jun 16, 2022 at 01:14:09AM +0300, Laurent Pinchart wrote: > > > > > > Now that a header exists with macros for the media interface bus-type > > > > > > values, replace hardcoding numerical constants with the corresponding > > > > > > macros in the DT sources. > > > > > > > > > > > > Signed-off-by: Laurent Pinchart > > > > > > > > Reviewed-by: Geert Uytterhoeven > > > > > > > > > > --- > > > > > > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 11 +++++++---- > > > > > > .../dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi | 4 +++- > > > > > > .../dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi | 4 +++- > > > > > > 3 files changed, 13 insertions(+), 6 deletions(-) > > > > > > > > > > > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts > > > > > > index 4e58c54cde17..33ac4bd1e63b 100644 > > > > > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts > > > > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts > > > > > > @@ -7,6 +7,9 @@ > > > > > > */ > > > > > > > > > > > > /dts-v1/; > > > > > > + > > > > > > +#include > > > > > > + > > > > > > #include "r8a7742-iwg21d-q7.dts" > > > > > > > > > > > > / { > > > > > > @@ -242,7 +245,7 @@ port { > > > > > > vin0ep: endpoint { > > > > > > remote-endpoint = <&cam0ep>; > > > > > > bus-width = <8>; > > > > > > - bus-type = <6>; > > > > > > + bus-type = ; > > > > > > }; > > > > > > }; > > > > > > }; > > > > > > @@ -273,7 +276,7 @@ port { > > > > > > vin1ep: endpoint { > > > > > > remote-endpoint = <&cam1ep>; > > > > > > bus-width = <8>; > > > > > > - bus-type = <6>; > > > > > > + bus-type = ; > > > > > > }; > > > > > > }; > > > > > > }; > > > > > > @@ -305,7 +308,7 @@ vin2ep: endpoint { > > > > > > remote-endpoint = <&cam2ep>; > > > > > > bus-width = <8>; > > > > > > data-shift = <8>; > > > > > > - bus-type = <6>; > > > > > > + bus-type = ; > > > > > > }; > > > > > > }; > > > > > > }; > > > > > > @@ -335,7 +338,7 @@ port { > > > > > > vin3ep: endpoint { > > > > > > remote-endpoint = <&cam3ep>; > > > > > > bus-width = <8>; > > > > > > - bus-type = <6>; > > > > > > + bus-type = ; > > > > > > }; > > > > > > }; > > > > > > }; > > > > > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi > > > > > > index 40cef0b1d1e6..c73160df619d 100644 > > > > > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi > > > > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi > > > > > > @@ -7,6 +7,8 @@ > > > > > > * Copyright (C) 2020 Renesas Electronics Corp. > > > > > > */ > > > > > > > > > > > > +#include > > > > > > > > This .dtsi file is only intended to be included by > > > > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts, which already has > > > > the include. Hence if you don't mind, I would like to drop this part > > > > while applying and queuing in renesas-devel for v6.3. > > > > > > Isn't it better to include headers as needed to avoid depending on > > > indirect includes ? > > > > In general, I agree. > > In this particular case, (the multiple inclusions of) the > > r8a7742-iwg21d-q7-dbcm-ov*-single.dtsi files are tied very intimately > > to r8a7742-iwg21d-q7-dbcm-ca.dts. > > I'd still prefer keeping the #include here, but you're the maintainer > :-) OK, will keep them. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C1B1C46467 for ; Mon, 16 Jan 2023 11:25:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qAuDEZDiAe8XE4COtQN5fjUzJgshgjWXwUzoaO/rjE4=; b=qQ7jkohmqe8GRC 3xvoNsFsOwZ1StcwlVIC5jlMI9KP2ALISMd44B7TqtytcngOtlXJhXzXy+3OhR/8mWtUumsTQ7XcE Vvi+AdCEXZ+l0WUiXXzZLp08NYm2Q7IwQwmTzwkY/Gcp1RILVcxgSPo0Nth6IBQlrZW1L66pcJxT/ Eb8cWa8aY0Sko5rj5QzC9/GXfywELA5fKaCbx87nm7oCN3UqEqg75DvZDvt40txYbhle8q0vjZzfK NWsqNSLhUUEaE7T/k9sBvLH90suzcxTRY3EAH+HaiRzFIbHA20L4jruKG23DZzelXhls+EPiUB6xs N1AZvBGumgt5Xf8Vwm2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHNb5-009u3h-PU; Mon, 16 Jan 2023 11:24:15 +0000 Received: from mail-qt1-f175.google.com ([209.85.160.175]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHNb2-009u34-4v for linux-arm-kernel@lists.infradead.org; Mon, 16 Jan 2023 11:24:13 +0000 Received: by mail-qt1-f175.google.com with SMTP id a25so17169574qto.10 for ; Mon, 16 Jan 2023 03:24:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CC4suAhGO9ZHb6FRYObqt22bnmss3lWiFC78zfUA2eM=; b=vT2litPoLdWBUdRzcLtXXlEaMxtqo51GoooMkzK2niRNiUII2hz0fmB17mgKmC37rg HstGTmEJPwgE+82xpC+/yfshsrE5mNKL2jk1N7ljli+GK1wzRRe0akgwKl6bXFgAIwdR HXbizN1k5F9BLHKJUZ/kJXjzgLkbabhW4k7sDLKVBj2qNLxGMTzNr40+0IqoG4jrygJO T5dtLUtsCr/3lKO6WxCeZwDHvbvJagR7g/e0JBnwC9+vtQQeCiPHfpeuY6tACvcWhKD3 VvmF9xpqv5PqS1CKiOcMEpNFwDMSjUWMflRXPj9xZB7ErxllwGuzXQvFpbVJ+rpNOJur sbzg== X-Gm-Message-State: AFqh2kpBWmWCXNQit5WGajZm6KHkHOlyVqKrG/qDD+ds04IcGPpy4HOP G8b/Vd1YPFhI9mIlMHy9cbLWq4I842yGlQ== X-Google-Smtp-Source: AMrXdXsOuVJDQRMBgKYU5ZeW2kgPVP1s3FzmIg7//cqvmwI8jcQFiD2iP3GfOAE/K0JysveEC2x7Rg== X-Received: by 2002:ac8:51d2:0:b0:3b5:7c0a:5968 with SMTP id d18-20020ac851d2000000b003b57c0a5968mr9718563qtn.68.1673868250521; Mon, 16 Jan 2023 03:24:10 -0800 (PST) Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com. [209.85.128.171]) by smtp.gmail.com with ESMTPSA id e124-20020a37b582000000b0070495934152sm17732439qkf.48.2023.01.16.03.24.09 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Jan 2023 03:24:10 -0800 (PST) Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-4d13cb4bbffso255859117b3.3 for ; Mon, 16 Jan 2023 03:24:09 -0800 (PST) X-Received: by 2002:a81:578e:0:b0:4d9:3858:392 with SMTP id l136-20020a81578e000000b004d938580392mr1318541ywb.502.1673868249495; Mon, 16 Jan 2023 03:24:09 -0800 (PST) MIME-Version: 1.0 References: <20220615221410.27459-1-laurent.pinchart@ideasonboard.com> <20220615221410.27459-6-laurent.pinchart@ideasonboard.com> In-Reply-To: From: Geert Uytterhoeven Date: Mon, 16 Jan 2023 12:23:58 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros To: Laurent Pinchart Cc: devicetree@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, Rob Herring , Sakari Ailus , Jacopo Mondi , Eugen Hristev , Hugues Fruchet , Maxime Coquelin , Alexandre Torgue , Lad Prabhakar , Fabio Estevam , Shawn Guo , Linux-Renesas X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230116_032412_211629_C2D60F02 X-CRM114-Status: GOOD ( 40.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Laurent, On Mon, Jan 16, 2023 at 11:49 AM Laurent Pinchart wrote: > On Mon, Jan 16, 2023 at 11:44:13AM +0100, Geert Uytterhoeven wrote: > > On Mon, Jan 16, 2023 at 11:38 AM Laurent Pinchart wrote: > > > On Mon, Jan 16, 2023 at 11:24:10AM +0100, Geert Uytterhoeven wrote: > > > > On Sat, Jan 14, 2023 at 4:26 PM Laurent Pinchart wrote: > > > > > Geert, could you please take this in your tree for v6.3 ? The two > > > > > patches that the DT changes depend on have been merged in v6.2. > > > > > > > > Thank you, I had missed these. > > > > > > > > > On Thu, Jun 16, 2022 at 01:14:09AM +0300, Laurent Pinchart wrote: > > > > > > Now that a header exists with macros for the media interface bus-type > > > > > > values, replace hardcoding numerical constants with the corresponding > > > > > > macros in the DT sources. > > > > > > > > > > > > Signed-off-by: Laurent Pinchart > > > > > > > > Reviewed-by: Geert Uytterhoeven > > > > > > > > > > --- > > > > > > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 11 +++++++---- > > > > > > .../dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi | 4 +++- > > > > > > .../dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi | 4 +++- > > > > > > 3 files changed, 13 insertions(+), 6 deletions(-) > > > > > > > > > > > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts > > > > > > index 4e58c54cde17..33ac4bd1e63b 100644 > > > > > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts > > > > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts > > > > > > @@ -7,6 +7,9 @@ > > > > > > */ > > > > > > > > > > > > /dts-v1/; > > > > > > + > > > > > > +#include > > > > > > + > > > > > > #include "r8a7742-iwg21d-q7.dts" > > > > > > > > > > > > / { > > > > > > @@ -242,7 +245,7 @@ port { > > > > > > vin0ep: endpoint { > > > > > > remote-endpoint = <&cam0ep>; > > > > > > bus-width = <8>; > > > > > > - bus-type = <6>; > > > > > > + bus-type = ; > > > > > > }; > > > > > > }; > > > > > > }; > > > > > > @@ -273,7 +276,7 @@ port { > > > > > > vin1ep: endpoint { > > > > > > remote-endpoint = <&cam1ep>; > > > > > > bus-width = <8>; > > > > > > - bus-type = <6>; > > > > > > + bus-type = ; > > > > > > }; > > > > > > }; > > > > > > }; > > > > > > @@ -305,7 +308,7 @@ vin2ep: endpoint { > > > > > > remote-endpoint = <&cam2ep>; > > > > > > bus-width = <8>; > > > > > > data-shift = <8>; > > > > > > - bus-type = <6>; > > > > > > + bus-type = ; > > > > > > }; > > > > > > }; > > > > > > }; > > > > > > @@ -335,7 +338,7 @@ port { > > > > > > vin3ep: endpoint { > > > > > > remote-endpoint = <&cam3ep>; > > > > > > bus-width = <8>; > > > > > > - bus-type = <6>; > > > > > > + bus-type = ; > > > > > > }; > > > > > > }; > > > > > > }; > > > > > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi > > > > > > index 40cef0b1d1e6..c73160df619d 100644 > > > > > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi > > > > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi > > > > > > @@ -7,6 +7,8 @@ > > > > > > * Copyright (C) 2020 Renesas Electronics Corp. > > > > > > */ > > > > > > > > > > > > +#include > > > > > > > > This .dtsi file is only intended to be included by > > > > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts, which already has > > > > the include. Hence if you don't mind, I would like to drop this part > > > > while applying and queuing in renesas-devel for v6.3. > > > > > > Isn't it better to include headers as needed to avoid depending on > > > indirect includes ? > > > > In general, I agree. > > In this particular case, (the multiple inclusions of) the > > r8a7742-iwg21d-q7-dbcm-ov*-single.dtsi files are tied very intimately > > to r8a7742-iwg21d-q7-dbcm-ca.dts. > > I'd still prefer keeping the #include here, but you're the maintainer > :-) OK, will keep them. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel