Re: [PATCH 06/15] h8300: convert to setup_initial_init_mm()

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	"moderated list:H8/300 ARCHITECTURE" 
	<uclinux-h8-devel@lists.sourceforge.jp>
Subject: Re: [PATCH 06/15] h8300: convert to setup_initial_init_mm()
Date: Mon, 31 May 2021 09:48:50 +0200	[thread overview]
Message-ID: <CAMuHMdU_y5g86owbK4J1gP6xntxCCmNGT_MCXZkVfosTjYdEqg@mail.gmail.com> (raw)
In-Reply-To: <20210529105504.180544-7-wangkefeng.wang@huawei.com>

Hi Kefeng,

On Sat, May 29, 2021 at 12:47 PM Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
> Use setup_initial_init_mm() helper to simplify code.
>
> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
> Cc: uclinux-h8-devel@lists.sourceforge.jp
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>

Thanks for your patch!

> --- a/arch/h8300/kernel/setup.c
> +++ b/arch/h8300/kernel/setup.c
> @@ -97,10 +97,7 @@ void __init setup_arch(char **cmdline_p)
>  {
>         unflatten_and_copy_device_tree();
>
> -       init_mm.start_code = (unsigned long) _stext;
> -       init_mm.end_code = (unsigned long) _etext;
> -       init_mm.end_data = (unsigned long) _edata;
> -       init_mm.brk = (unsigned long) 0;
> +       setup_initial_init_mm(_stext, _etext, _edata, (void *)0);

Please use NULL instead of (void *)0.

>
>         pr_notice("\r\n\nuClinux " CPU "\n");
>         pr_notice("Flat model support (C) 1998,1999 Kenneth Albanowski, D. Jeff Dionne\n");

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds