From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5522C4338F for ; Fri, 23 Jul 2021 15:18:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A82B860F21 for ; Fri, 23 Jul 2021 15:18:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235531AbhGWOhb (ORCPT ); Fri, 23 Jul 2021 10:37:31 -0400 Received: from mail-ua1-f44.google.com ([209.85.222.44]:43657 "EHLO mail-ua1-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235486AbhGWOgs (ORCPT ); Fri, 23 Jul 2021 10:36:48 -0400 Received: by mail-ua1-f44.google.com with SMTP id j7so630100uaj.10; Fri, 23 Jul 2021 08:17:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Sie/IxwBmILJtt5CfCHMRTqh7diZyseV1fFMGEm6yOk=; b=jG9SlZxIK86OiLf8r0t4+8AL7Dk/UjURdCBdfQwLKoD9bRvI8B+7T17A0evZ1P133Y hLb/9vYPMAX4IHlS9xWUCnJc2cRPKeAiS05LPjkUvsbNDVJL9SlVla5hIJ0w/GVmxpPm JCFIhSLOFgDLt5Q6Y5Clx6pQMwQP8t20rYTMsrIYxRXw5Ok9AgVCvJRlhGNkIi7clO3e zFyHjgmqOOpkzn6x+AJRJvxRBHYX/o9ux2GyQMirhOa3SaGkFeDISWU2DO6a1ECcJqr1 mtah0lJtj66ctsHozaxhs/0hmC90K4eAaSsAzEa1eRi1WcvsjhbGmG8Y22sCuRRPMREq C0xw== X-Gm-Message-State: AOAM533jwx5k+xexiVUvE9J5tyYwZo0Xx5nB7/mEjn5Om9Zd17rae3cU xGiPIIpJbhBNtTQuDKzYgNQIpNGrLFeYIP/HBd4= X-Google-Smtp-Source: ABdhPJwjie6QeabkOjY7IEyTELcNhWlJ1IBBcsCliDIJ6B3GHGV6iAk2cW/JLMoH9H/oEu8zcHMlVqite6WQsRrTwGc= X-Received: by 2002:ab0:2554:: with SMTP id l20mr5059882uan.58.1627053440203; Fri, 23 Jul 2021 08:17:20 -0700 (PDT) MIME-Version: 1.0 References: <170e7daa55aced148b8e57827f7c8fc65a0a8c7a.1626266516.git.geert+renesas@glider.be> In-Reply-To: From: Geert Uytterhoeven Date: Fri, 23 Jul 2021 17:17:08 +0200 Message-ID: Subject: Re: [PATCH v4 06/10] riscv: Remove non-standard linux,elfcorehdr handling To: Palmer Dabbelt Cc: Rob Herring , Russell King , Nicolas Pitre , Ard Biesheuvel , Linus Walleij , Catalin Marinas , Will Deacon , Nick Kossifidis , Paul Walmsley , Albert Ou , Frank Rowand , Dave Young , Mike Rapoport , Baoquan He , Vivek Goyal , Andrew Morton , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , linux-riscv , kexec@lists.infradead.org, Linux MM , Linux-Renesas , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Palmer, On Tue, Jul 20, 2021 at 5:43 PM Palmer Dabbelt wrote: > On Wed, 14 Jul 2021 05:50:16 PDT (-0700), geert+renesas@glider.be wrote: > > RISC-V uses platform-specific code to locate the elf core header in > > memory. However, this does not conform to the standard > > "linux,elfcorehdr" DT bindings, as it relies on a reserved memory node > > with the "linux,elfcorehdr" compatible value, instead of on a > > "linux,elfcorehdr" property under the "/chosen" node. > > > > The non-compliant code can just be removed, as the standard behavior is > > already implemented by platform-agnostic handling in the FDT core code. > > > > Fixes: 5640975003d0234d ("RISC-V: Add crash kernel support") > > Signed-off-by: Geert Uytterhoeven > > --- > > v4: > > - No changes. > > --- > > arch/riscv/mm/init.c | 20 -------------------- > > 1 file changed, 20 deletions(-) > > > > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c > > index 269fc648ef3d84b2..4aa4b6a034086df6 100644 > > --- a/arch/riscv/mm/init.c > > +++ b/arch/riscv/mm/init.c > > @@ -829,26 +829,6 @@ static void __init reserve_crashkernel(void) > > } > > #endif /* CONFIG_KEXEC_CORE */ > > > > -#ifdef CONFIG_CRASH_DUMP > > -/* > > - * We keep track of the ELF core header of the crashed > > - * kernel with a reserved-memory region with compatible > > - * string "linux,elfcorehdr". Here we register a callback > > - * to populate elfcorehdr_addr/size when this region is > > - * present. Note that this region will be marked as > > - * reserved once we call early_init_fdt_scan_reserved_mem() > > - * later on. > > - */ > > -static int __init elfcore_hdr_setup(struct reserved_mem *rmem) > > -{ > > - elfcorehdr_addr = rmem->base; > > - elfcorehdr_size = rmem->size; > > - return 0; > > -} > > - > > -RESERVEDMEM_OF_DECLARE(elfcorehdr, "linux,elfcorehdr", elfcore_hdr_setup); > > -#endif > > - > > void __init paging_init(void) > > { > > setup_bootmem(); > > Reviewed-by: Palmer Dabbelt > Acked-by: Palmer Dabbelt > > LMK if you wanted me to take this series, otherwise I'm going to assume > it's going in via some other tree. There will be a v5 of the series in response to the review comments. But I think this patch can already be applied. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9598DC4338F for ; Fri, 23 Jul 2021 15:17:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0EDDC60F02 for ; Fri, 23 Jul 2021 15:17:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0EDDC60F02 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z9qBWX3bd6wGRlssqXfcxh6xoaml2beapE2sfjc8fUo=; b=hNx36hxUOoR+hE caxWgehEG2ERTJCCOHTFxChxLpq+WWNBXFB90l/gFehMUkjBZuOq8SZKA3bZMeAW27c3cQclETYKL GIfmfQJqsRlWcbN0J2keFw/mICqZyzcC0MmQ/bdQelDAFsMzzhpjV/ivOc06oAwpPmGiArg4EarNR iX227hCNNG8KTy1GJV7xE42XcfhHYMpseDIgsTjUFB23mCCLcJhkrEn6PkaSBzH6OmMkt67nZWzR7 BPVPQioS9x1uLx13YHdApPlhDPXAuoEIP2ogyQSW6k+WnBUOY0/zF/0G7PRlLvLKysrjgcmxxIVVk B6Eej7LuQKzkGJ3hOpXg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6wvf-0057AQ-T2; Fri, 23 Jul 2021 15:17:35 +0000 Received: from mail-ua1-f42.google.com ([209.85.222.42]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6wvS-00579D-DQ; Fri, 23 Jul 2021 15:17:24 +0000 Received: by mail-ua1-f42.google.com with SMTP id t26so626137uao.12; Fri, 23 Jul 2021 08:17:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Sie/IxwBmILJtt5CfCHMRTqh7diZyseV1fFMGEm6yOk=; b=HXz0FglM0UqXDvNDt7zLsg2MLrO7KTha52H6Bw13l/ZR/JQ84yF3RRrgWzRLU2ocKv cFaPuluXYkMmJaRhSwSmgsjZotHM/rvwnmgoV5kxMt538Dxpzc988YwK+ILVCSYIpjoc zi7beyAyzPFhORKGAf7h8ri7rKncYxocm0Jx1xvuyPMv3CBV/SjOxt9fTUHH7FA+Bti0 oSDGMaQspkhKfx+wCAK/jiIokRluBvzupG0w6UJyLeAB7aBGY3Y6ucjTpM3ryPA8PTxS JKaUVmyS9sm2MDUEIkS0aV43Wgxr/f69LFRgqModOKjhKXoPtHUS3APhynwwuCT0JiCw Y13g== X-Gm-Message-State: AOAM532luFRg3uarN63+gb/1PhYm65NmkUw8YYF40LQ+lWPnLnfS7+dd DZfBgikhRZmX8iVEaeng3XKIW3whKu6GnCwhmwc= X-Google-Smtp-Source: ABdhPJwjie6QeabkOjY7IEyTELcNhWlJ1IBBcsCliDIJ6B3GHGV6iAk2cW/JLMoH9H/oEu8zcHMlVqite6WQsRrTwGc= X-Received: by 2002:ab0:2554:: with SMTP id l20mr5059882uan.58.1627053440203; Fri, 23 Jul 2021 08:17:20 -0700 (PDT) MIME-Version: 1.0 References: <170e7daa55aced148b8e57827f7c8fc65a0a8c7a.1626266516.git.geert+renesas@glider.be> In-Reply-To: From: Geert Uytterhoeven Date: Fri, 23 Jul 2021 17:17:08 +0200 Message-ID: Subject: Re: [PATCH v4 06/10] riscv: Remove non-standard linux, elfcorehdr handling To: Palmer Dabbelt Cc: Rob Herring , Russell King , Nicolas Pitre , Ard Biesheuvel , Linus Walleij , Catalin Marinas , Will Deacon , Nick Kossifidis , Paul Walmsley , Albert Ou , Frank Rowand , Dave Young , Mike Rapoport , Baoquan He , Vivek Goyal , Andrew Morton , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , linux-riscv , kexec@lists.infradead.org, Linux MM , Linux-Renesas , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210723_081722_498751_DDA2C856 X-CRM114-Status: GOOD ( 35.63 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Hi Palmer, On Tue, Jul 20, 2021 at 5:43 PM Palmer Dabbelt wrote: > On Wed, 14 Jul 2021 05:50:16 PDT (-0700), geert+renesas@glider.be wrote: > > RISC-V uses platform-specific code to locate the elf core header in > > memory. However, this does not conform to the standard > > "linux,elfcorehdr" DT bindings, as it relies on a reserved memory node > > with the "linux,elfcorehdr" compatible value, instead of on a > > "linux,elfcorehdr" property under the "/chosen" node. > > > > The non-compliant code can just be removed, as the standard behavior is > > already implemented by platform-agnostic handling in the FDT core code. > > > > Fixes: 5640975003d0234d ("RISC-V: Add crash kernel support") > > Signed-off-by: Geert Uytterhoeven > > --- > > v4: > > - No changes. > > --- > > arch/riscv/mm/init.c | 20 -------------------- > > 1 file changed, 20 deletions(-) > > > > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c > > index 269fc648ef3d84b2..4aa4b6a034086df6 100644 > > --- a/arch/riscv/mm/init.c > > +++ b/arch/riscv/mm/init.c > > @@ -829,26 +829,6 @@ static void __init reserve_crashkernel(void) > > } > > #endif /* CONFIG_KEXEC_CORE */ > > > > -#ifdef CONFIG_CRASH_DUMP > > -/* > > - * We keep track of the ELF core header of the crashed > > - * kernel with a reserved-memory region with compatible > > - * string "linux,elfcorehdr". Here we register a callback > > - * to populate elfcorehdr_addr/size when this region is > > - * present. Note that this region will be marked as > > - * reserved once we call early_init_fdt_scan_reserved_mem() > > - * later on. > > - */ > > -static int __init elfcore_hdr_setup(struct reserved_mem *rmem) > > -{ > > - elfcorehdr_addr = rmem->base; > > - elfcorehdr_size = rmem->size; > > - return 0; > > -} > > - > > -RESERVEDMEM_OF_DECLARE(elfcorehdr, "linux,elfcorehdr", elfcore_hdr_setup); > > -#endif > > - > > void __init paging_init(void) > > { > > setup_bootmem(); > > Reviewed-by: Palmer Dabbelt > Acked-by: Palmer Dabbelt > > LMK if you wanted me to take this series, otherwise I'm going to assume > it's going in via some other tree. There will be a v5 of the series in response to the review comments. But I think this patch can already be applied. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 296D2C4338F for ; Fri, 23 Jul 2021 15:17:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7166160F02 for ; Fri, 23 Jul 2021 15:17:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7166160F02 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id BFA286B0033; Fri, 23 Jul 2021 11:17:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BABDD6B005D; Fri, 23 Jul 2021 11:17:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A98A66B006C; Fri, 23 Jul 2021 11:17:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0025.hostedemail.com [216.40.44.25]) by kanga.kvack.org (Postfix) with ESMTP id 8E92E6B0033 for ; Fri, 23 Jul 2021 11:17:21 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3D28D202EE for ; Fri, 23 Jul 2021 15:17:21 +0000 (UTC) X-FDA: 78394206282.13.5EF4239 Received: from mail-ua1-f48.google.com (mail-ua1-f48.google.com [209.85.222.48]) by imf25.hostedemail.com (Postfix) with ESMTP id E063CB007D56 for ; Fri, 23 Jul 2021 15:17:20 +0000 (UTC) Received: by mail-ua1-f48.google.com with SMTP id n15so637773uao.6 for ; Fri, 23 Jul 2021 08:17:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Sie/IxwBmILJtt5CfCHMRTqh7diZyseV1fFMGEm6yOk=; b=Z54B/50A8ER79in826x9vah80ebWnbcLKl4Hq/MKQEpmDr5nV7/rulPPGJryRfqr41 c15w+/kkcf6TKCUn3YSTaMp0a4sMxJHwltHXfoC5sjtOdFrpnyxPRIJq9Kf+kD+tyzrV jrI0YnfSenYwCdX2E6e3Ptzbdh38tANzNvvYjNj0uuhWqhG7VmyO6BY9xMLFChCYbjnN lXc57s4HpLnfEIRiDMANNWvXOVjkMo9G/fuUB3uncUPajg2pAE/71atGjg0M+0ZnQZDo Qhf3OL2bv+SYMHQ0KBKRZnlGkdCCAJb3Pb0AvbeqZNP+VZpyb+fLv4p4jaRaxU/9Ew2s 4i7Q== X-Gm-Message-State: AOAM533JnE9tuI38az1d4uX2Y5jA2IQGVsDuxWUnExBmAiXSbIODBx/O n8LqS4LwUBvRuSc+SCA63kd+eAECGxX7gYFPimE= X-Google-Smtp-Source: ABdhPJwjie6QeabkOjY7IEyTELcNhWlJ1IBBcsCliDIJ6B3GHGV6iAk2cW/JLMoH9H/oEu8zcHMlVqite6WQsRrTwGc= X-Received: by 2002:ab0:2554:: with SMTP id l20mr5059882uan.58.1627053440203; Fri, 23 Jul 2021 08:17:20 -0700 (PDT) MIME-Version: 1.0 References: <170e7daa55aced148b8e57827f7c8fc65a0a8c7a.1626266516.git.geert+renesas@glider.be> In-Reply-To: From: Geert Uytterhoeven Date: Fri, 23 Jul 2021 17:17:08 +0200 Message-ID: Subject: Re: [PATCH v4 06/10] riscv: Remove non-standard linux,elfcorehdr handling To: Palmer Dabbelt Cc: Rob Herring , Russell King , Nicolas Pitre , Ard Biesheuvel , Linus Walleij , Catalin Marinas , Will Deacon , Nick Kossifidis , Paul Walmsley , Albert Ou , Frank Rowand , Dave Young , Mike Rapoport , Baoquan He , Vivek Goyal , Andrew Morton , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , linux-riscv , kexec@lists.infradead.org, Linux MM , Linux-Renesas , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E063CB007D56 Authentication-Results: imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of geertuytterhoeven@gmail.com designates 209.85.222.48 as permitted sender) smtp.mailfrom=geertuytterhoeven@gmail.com; dmarc=none X-Stat-Signature: tgymis8scisybb3if1hb14zcdnwt3bqk X-HE-Tag: 1627053440-15348 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Palmer, On Tue, Jul 20, 2021 at 5:43 PM Palmer Dabbelt wrote: > On Wed, 14 Jul 2021 05:50:16 PDT (-0700), geert+renesas@glider.be wrote: > > RISC-V uses platform-specific code to locate the elf core header in > > memory. However, this does not conform to the standard > > "linux,elfcorehdr" DT bindings, as it relies on a reserved memory node > > with the "linux,elfcorehdr" compatible value, instead of on a > > "linux,elfcorehdr" property under the "/chosen" node. > > > > The non-compliant code can just be removed, as the standard behavior is > > already implemented by platform-agnostic handling in the FDT core code. > > > > Fixes: 5640975003d0234d ("RISC-V: Add crash kernel support") > > Signed-off-by: Geert Uytterhoeven > > --- > > v4: > > - No changes. > > --- > > arch/riscv/mm/init.c | 20 -------------------- > > 1 file changed, 20 deletions(-) > > > > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c > > index 269fc648ef3d84b2..4aa4b6a034086df6 100644 > > --- a/arch/riscv/mm/init.c > > +++ b/arch/riscv/mm/init.c > > @@ -829,26 +829,6 @@ static void __init reserve_crashkernel(void) > > } > > #endif /* CONFIG_KEXEC_CORE */ > > > > -#ifdef CONFIG_CRASH_DUMP > > -/* > > - * We keep track of the ELF core header of the crashed > > - * kernel with a reserved-memory region with compatible > > - * string "linux,elfcorehdr". Here we register a callback > > - * to populate elfcorehdr_addr/size when this region is > > - * present. Note that this region will be marked as > > - * reserved once we call early_init_fdt_scan_reserved_mem() > > - * later on. > > - */ > > -static int __init elfcore_hdr_setup(struct reserved_mem *rmem) > > -{ > > - elfcorehdr_addr = rmem->base; > > - elfcorehdr_size = rmem->size; > > - return 0; > > -} > > - > > -RESERVEDMEM_OF_DECLARE(elfcorehdr, "linux,elfcorehdr", elfcore_hdr_setup); > > -#endif > > - > > void __init paging_init(void) > > { > > setup_bootmem(); > > Reviewed-by: Palmer Dabbelt > Acked-by: Palmer Dabbelt > > LMK if you wanted me to take this series, otherwise I'm going to assume > it's going in via some other tree. There will be a v5 of the series in response to the review comments. But I think this patch can already be applied. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5C24C432BE for ; Fri, 23 Jul 2021 15:19:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E07460F02 for ; Fri, 23 Jul 2021 15:19:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7E07460F02 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vjKg3wTNPHb0rnsnhXJf9tosB3fAA8ETQ4yDcZ1Zp7I=; b=IR1Yv62BDtXE0S bFj1y2emj7y4LRk8i61oviCBPFudCDRqGXdYtOEs+JtoqUIEl7eAqJyD2kiQB+iJjSBONaoMDLz5P MpMlfyC4jO8jg5z4P5j0PJJo87KY041PNnr9BteHutYpOqPVrim6WSJ3ziAo5ODpW19D4NlL+x3bS QfjAVWKhDt0hvkE/2vTO+qFOnJmIa6gKioUJpT4pS3+fqm4WYJmQ5DaUkhVoHQ3CThGhE1laRxt6S x36eQ8ZKVU/lJWAmCRGPKSohwI76SxblH5JpotTGLDTeTW0r+Ly1Ie1ywmyCnWZQ8d+qwS0sOwXhD JYcFnXVzxaiO1Ho07r+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6wvW-00579y-H7; Fri, 23 Jul 2021 15:17:26 +0000 Received: from mail-ua1-f42.google.com ([209.85.222.42]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6wvS-00579D-DQ; Fri, 23 Jul 2021 15:17:24 +0000 Received: by mail-ua1-f42.google.com with SMTP id t26so626137uao.12; Fri, 23 Jul 2021 08:17:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Sie/IxwBmILJtt5CfCHMRTqh7diZyseV1fFMGEm6yOk=; b=HXz0FglM0UqXDvNDt7zLsg2MLrO7KTha52H6Bw13l/ZR/JQ84yF3RRrgWzRLU2ocKv cFaPuluXYkMmJaRhSwSmgsjZotHM/rvwnmgoV5kxMt538Dxpzc988YwK+ILVCSYIpjoc zi7beyAyzPFhORKGAf7h8ri7rKncYxocm0Jx1xvuyPMv3CBV/SjOxt9fTUHH7FA+Bti0 oSDGMaQspkhKfx+wCAK/jiIokRluBvzupG0w6UJyLeAB7aBGY3Y6ucjTpM3ryPA8PTxS JKaUVmyS9sm2MDUEIkS0aV43Wgxr/f69LFRgqModOKjhKXoPtHUS3APhynwwuCT0JiCw Y13g== X-Gm-Message-State: AOAM532luFRg3uarN63+gb/1PhYm65NmkUw8YYF40LQ+lWPnLnfS7+dd DZfBgikhRZmX8iVEaeng3XKIW3whKu6GnCwhmwc= X-Google-Smtp-Source: ABdhPJwjie6QeabkOjY7IEyTELcNhWlJ1IBBcsCliDIJ6B3GHGV6iAk2cW/JLMoH9H/oEu8zcHMlVqite6WQsRrTwGc= X-Received: by 2002:ab0:2554:: with SMTP id l20mr5059882uan.58.1627053440203; Fri, 23 Jul 2021 08:17:20 -0700 (PDT) MIME-Version: 1.0 References: <170e7daa55aced148b8e57827f7c8fc65a0a8c7a.1626266516.git.geert+renesas@glider.be> In-Reply-To: From: Geert Uytterhoeven Date: Fri, 23 Jul 2021 17:17:08 +0200 Message-ID: Subject: Re: [PATCH v4 06/10] riscv: Remove non-standard linux, elfcorehdr handling To: Palmer Dabbelt Cc: Rob Herring , Russell King , Nicolas Pitre , Ard Biesheuvel , Linus Walleij , Catalin Marinas , Will Deacon , Nick Kossifidis , Paul Walmsley , Albert Ou , Frank Rowand , Dave Young , Mike Rapoport , Baoquan He , Vivek Goyal , Andrew Morton , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , linux-riscv , kexec@lists.infradead.org, Linux MM , Linux-Renesas , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210723_081722_498751_DDA2C856 X-CRM114-Status: GOOD ( 35.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Palmer, On Tue, Jul 20, 2021 at 5:43 PM Palmer Dabbelt wrote: > On Wed, 14 Jul 2021 05:50:16 PDT (-0700), geert+renesas@glider.be wrote: > > RISC-V uses platform-specific code to locate the elf core header in > > memory. However, this does not conform to the standard > > "linux,elfcorehdr" DT bindings, as it relies on a reserved memory node > > with the "linux,elfcorehdr" compatible value, instead of on a > > "linux,elfcorehdr" property under the "/chosen" node. > > > > The non-compliant code can just be removed, as the standard behavior is > > already implemented by platform-agnostic handling in the FDT core code. > > > > Fixes: 5640975003d0234d ("RISC-V: Add crash kernel support") > > Signed-off-by: Geert Uytterhoeven > > --- > > v4: > > - No changes. > > --- > > arch/riscv/mm/init.c | 20 -------------------- > > 1 file changed, 20 deletions(-) > > > > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c > > index 269fc648ef3d84b2..4aa4b6a034086df6 100644 > > --- a/arch/riscv/mm/init.c > > +++ b/arch/riscv/mm/init.c > > @@ -829,26 +829,6 @@ static void __init reserve_crashkernel(void) > > } > > #endif /* CONFIG_KEXEC_CORE */ > > > > -#ifdef CONFIG_CRASH_DUMP > > -/* > > - * We keep track of the ELF core header of the crashed > > - * kernel with a reserved-memory region with compatible > > - * string "linux,elfcorehdr". Here we register a callback > > - * to populate elfcorehdr_addr/size when this region is > > - * present. Note that this region will be marked as > > - * reserved once we call early_init_fdt_scan_reserved_mem() > > - * later on. > > - */ > > -static int __init elfcore_hdr_setup(struct reserved_mem *rmem) > > -{ > > - elfcorehdr_addr = rmem->base; > > - elfcorehdr_size = rmem->size; > > - return 0; > > -} > > - > > -RESERVEDMEM_OF_DECLARE(elfcorehdr, "linux,elfcorehdr", elfcore_hdr_setup); > > -#endif > > - > > void __init paging_init(void) > > { > > setup_bootmem(); > > Reviewed-by: Palmer Dabbelt > Acked-by: Palmer Dabbelt > > LMK if you wanted me to take this series, otherwise I'm going to assume > it's going in via some other tree. There will be a v5 of the series in response to the review comments. But I think this patch can already be applied. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: MIME-Version: 1.0 References: <170e7daa55aced148b8e57827f7c8fc65a0a8c7a.1626266516.git.geert+renesas@glider.be> In-Reply-To: From: Geert Uytterhoeven Date: Fri, 23 Jul 2021 17:17:08 +0200 Message-ID: Subject: Re: [PATCH v4 06/10] riscv: Remove non-standard linux, elfcorehdr handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Palmer Dabbelt Cc: Rob Herring , Russell King , Nicolas Pitre , Ard Biesheuvel , Linus Walleij , Catalin Marinas , Will Deacon , Nick Kossifidis , Paul Walmsley , Albert Ou , Frank Rowand , Dave Young , Mike Rapoport , Baoquan He , Vivek Goyal , Andrew Morton , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , linux-riscv , kexec@lists.infradead.org, Linux MM , Linux-Renesas , Linux Kernel Mailing List Hi Palmer, On Tue, Jul 20, 2021 at 5:43 PM Palmer Dabbelt wrote: > On Wed, 14 Jul 2021 05:50:16 PDT (-0700), geert+renesas@glider.be wrote: > > RISC-V uses platform-specific code to locate the elf core header in > > memory. However, this does not conform to the standard > > "linux,elfcorehdr" DT bindings, as it relies on a reserved memory node > > with the "linux,elfcorehdr" compatible value, instead of on a > > "linux,elfcorehdr" property under the "/chosen" node. > > > > The non-compliant code can just be removed, as the standard behavior is > > already implemented by platform-agnostic handling in the FDT core code. > > > > Fixes: 5640975003d0234d ("RISC-V: Add crash kernel support") > > Signed-off-by: Geert Uytterhoeven > > --- > > v4: > > - No changes. > > --- > > arch/riscv/mm/init.c | 20 -------------------- > > 1 file changed, 20 deletions(-) > > > > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c > > index 269fc648ef3d84b2..4aa4b6a034086df6 100644 > > --- a/arch/riscv/mm/init.c > > +++ b/arch/riscv/mm/init.c > > @@ -829,26 +829,6 @@ static void __init reserve_crashkernel(void) > > } > > #endif /* CONFIG_KEXEC_CORE */ > > > > -#ifdef CONFIG_CRASH_DUMP > > -/* > > - * We keep track of the ELF core header of the crashed > > - * kernel with a reserved-memory region with compatible > > - * string "linux,elfcorehdr". Here we register a callback > > - * to populate elfcorehdr_addr/size when this region is > > - * present. Note that this region will be marked as > > - * reserved once we call early_init_fdt_scan_reserved_mem() > > - * later on. > > - */ > > -static int __init elfcore_hdr_setup(struct reserved_mem *rmem) > > -{ > > - elfcorehdr_addr = rmem->base; > > - elfcorehdr_size = rmem->size; > > - return 0; > > -} > > - > > -RESERVEDMEM_OF_DECLARE(elfcorehdr, "linux,elfcorehdr", elfcore_hdr_setup); > > -#endif > > - > > void __init paging_init(void) > > { > > setup_bootmem(); > > Reviewed-by: Palmer Dabbelt > Acked-by: Palmer Dabbelt > > LMK if you wanted me to take this series, otherwise I'm going to assume > it's going in via some other tree. There will be a v5 of the series in response to the review comments. But I think this patch can already be applied. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec