All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v4 5/6] ARM: shmobile: sh73a0: add MSTP clock assignments to DT
Date: Thu, 06 Nov 2014 19:33:19 +0000	[thread overview]
Message-ID: <CAMuHMdUaZQ3A0VsbYrz+cRu3nRruN2wg3E+xmXZ+khTAOxqjFQ@mail.gmail.com> (raw)
In-Reply-To: <1415292641-30331-6-git-send-email-ulrich.hecht+renesas@gmail.com>

On Thu, Nov 6, 2014 at 5:50 PM, Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:
> @@ -202,6 +209,7 @@
>                 interrupts = <0 140 IRQ_TYPE_LEVEL_HIGH
>                               0 141 IRQ_TYPE_LEVEL_HIGH>;
>                 reg-io-width = <4>;
> +               clocks = <&mstp3_clks SH73A0_CLK_MMCIF0>;

For consistency, I think it would be best to always add "clocks" just
below "interrupts".

So I can add "power-domains" just below clocks later ;-)

>                 status = "disabled";
>         };
>
> @@ -212,6 +220,7 @@
>                               0 84 IRQ_TYPE_LEVEL_HIGH
>                               0 85 IRQ_TYPE_LEVEL_HIGH>;
>                 cap-sd-highspeed;
> +               clocks = <&mstp3_clks SH73A0_CLK_SDHI0>;

Likewise.

>                 status = "disabled";
>         };
>
> @@ -223,6 +232,7 @@
>                               0 89 IRQ_TYPE_LEVEL_HIGH>;
>                 toshiba,mmc-wrprotect-disable;
>                 cap-sd-highspeed;
> +               clocks = <&mstp3_clks SH73A0_CLK_SDHI1>;

Likewise.

>                 status = "disabled";
>         };
>
> @@ -233,6 +243,7 @@
>                               0 105 IRQ_TYPE_LEVEL_HIGH>;
>                 toshiba,mmc-wrprotect-disable;
>                 cap-sd-highspeed;
> +               clocks = <&mstp3_clks SH73A0_CLK_SDHI2>;

Likewise.

>                 status = "disabled";
>         };

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

      reply	other threads:[~2014-11-06 19:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-06 16:50 [PATCH v4 5/6] ARM: shmobile: sh73a0: add MSTP clock assignments to DT Ulrich Hecht
2014-11-06 19:33 ` Geert Uytterhoeven [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdUaZQ3A0VsbYrz+cRu3nRruN2wg3E+xmXZ+khTAOxqjFQ@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.