All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Arnd Bergmann <arnd@arndb.de>, Yury Norov <yury.norov@gmail.com>
Cc: y2038 Mailman List <y2038@lists.linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Linux-Arch <linux-arch@vger.kernel.org>,
	Linux API <linux-api@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	"open list:QUALCOMM HEXAGON..." <linux-hexagon@vger.kernel.org>,
	"moderated list:H8/300 ARCHITECTURE" 
	<uclinux-h8-devel@lists.sourceforge.jp>,
	Stafford Horne <shorne@gmail.com>,
	Vineet Gupta <vgupta@synopsys.com>,
	Palmer Dabbelt <palmer@sifive.com>, Guo Ren <guoren@kernel.org>,
	Greentime Hu <green.hu@gmail.com>,
	linux-riscv@lists.infradead.org, Guan Xuetao <gxt@pku.edu.cn>,
	Yury Norov <ynorov@caviumnetworks.com>,
	Yury Norov <ynorov@marvell.com>
Subject: Re: [PATCH 2/8] 32-bit userspace ABI: introduce ARCH_32BIT_OFF_T config option
Date: Tue, 19 Feb 2019 09:56:19 +0100	[thread overview]
Message-ID: <CAMuHMdUb47nLkorUpQ1ohD-WMaEG7d3DBAs7JWA6rvgKTZAGGw@mail.gmail.com> (raw)
In-Reply-To: <20190218210712.3503891-3-arnd@arndb.de>

Hi Arnd, Yuri,

On Tue, Feb 19, 2019 at 3:35 AM Arnd Bergmann <arnd@arndb.de> wrote:
> From: Yury Norov <ynorov@caviumnetworks.com>
>
> All new 32-bit architectures should have 64-bit userspace off_t type, but
> existing architectures has 32-bit ones.
>
> To enforce the rule, new config option is added to arch/Kconfig that defaults
> ARCH_32BIT_OFF_T to be disabled for new 32-bit architectures. All existing
> 32-bit architectures enable it explicitly.
>
> New option affects force_o_largefile() behaviour. Namely, if userspace
> off_t is 64-bits long, we have no reason to reject user to open big files.
>
> Note that even if architectures has only 64-bit off_t in the kernel
> (arc, c6x, h8300, hexagon, nios2, openrisc, and unicore32),
> a libc may use 32-bit off_t, and therefore want to limit the file size
> to 4GB unless specified differently in the open flags.
>
> Signed-off-by: Yury Norov <ynorov@caviumnetworks.com>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Yury Norov <ynorov@marvell.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

>  arch/m68k/Kconfig       |  1 +

For m68k:
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

> --- a/arch/Kconfig
> +++ b/arch/Kconfig
> @@ -276,6 +276,21 @@ config ARCH_THREAD_STACK_ALLOCATOR
>  config ARCH_WANTS_DYNAMIC_TASK_STRUCT
>         bool
>
> +config ARCH_32BIT_OFF_T
> +       bool
> +       depends on !64BIT
> +       help
> +         All new 32-bit architectures should have 64-bit off_t type on
> +         userspace side which corresponds to the loff_t kernel type. This
> +         is the requirement for modern ABIs. Some existing architectures
> +         already have 32-bit off_t. This option is enabled for all such

s/already/still/

> +         architectures explicitly. Namely: arc, arm, blackfin, cris, frv,
> +         h8300, hexagon, m32r, m68k, metag, microblaze, mips32, mn10300,
> +         nios2, openrisc, parisc32, powerpc32, score, sh, sparc, tile32,
> +         unicore32, x86_32 and xtensa. This is the complete list. Any

Do we really need this list here?  It's intended to shrink only.
It includes removed architectures (blackfin, cris, frv, m32r, metag,
mn10300, score, tile32), but lacks several new ones affected by this
patch (c6x, csky, nds32, riscv).

> +         new 32-bit architecture should declare 64-bit off_t type on user
> +         side and so should not enable this option.
> +
>  config HAVE_REGS_AND_STACK_ACCESS_API
>         bool
>         help

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

WARNING: multiple messages have this Message-ID
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Arnd Bergmann <arnd@arndb.de>, Yury Norov <yury.norov@gmail.com>
Cc: Linux-Arch <linux-arch@vger.kernel.org>,
	"moderated list:H8/300 ARCHITECTURE"
	<uclinux-h8-devel@lists.sourceforge.jp>,
	Yury Norov <ynorov@marvell.com>,
	Yury Norov <ynorov@caviumnetworks.com>,
	y2038 Mailman List <y2038@lists.linaro.org>,
	Linux API <linux-api@vger.kernel.org>,
	Palmer Dabbelt <palmer@sifive.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-riscv@lists.infradead.org,
	Vineet Gupta <vgupta@synopsys.com>, Guo Ren <guoren@kernel.org>,
	Greentime Hu <green.hu@gmail.com>,
	"open list:QUALCOMM HEXAGON..." <linux-hexagon@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Guan Xuetao <gxt@pku.edu.cn>, Stafford Horne <shorne@gmail.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/8] 32-bit userspace ABI: introduce ARCH_32BIT_OFF_T config option
Date: Tue, 19 Feb 2019 09:56:19 +0100	[thread overview]
Message-ID: <CAMuHMdUb47nLkorUpQ1ohD-WMaEG7d3DBAs7JWA6rvgKTZAGGw@mail.gmail.com> (raw)
In-Reply-To: <20190218210712.3503891-3-arnd@arndb.de>

Hi Arnd, Yuri,

On Tue, Feb 19, 2019 at 3:35 AM Arnd Bergmann <arnd@arndb.de> wrote:
> From: Yury Norov <ynorov@caviumnetworks.com>
>
> All new 32-bit architectures should have 64-bit userspace off_t type, but
> existing architectures has 32-bit ones.
>
> To enforce the rule, new config option is added to arch/Kconfig that defaults
> ARCH_32BIT_OFF_T to be disabled for new 32-bit architectures. All existing
> 32-bit architectures enable it explicitly.
>
> New option affects force_o_largefile() behaviour. Namely, if userspace
> off_t is 64-bits long, we have no reason to reject user to open big files.
>
> Note that even if architectures has only 64-bit off_t in the kernel
> (arc, c6x, h8300, hexagon, nios2, openrisc, and unicore32),
> a libc may use 32-bit off_t, and therefore want to limit the file size
> to 4GB unless specified differently in the open flags.
>
> Signed-off-by: Yury Norov <ynorov@caviumnetworks.com>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Yury Norov <ynorov@marvell.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

>  arch/m68k/Kconfig       |  1 +

For m68k:
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

> --- a/arch/Kconfig
> +++ b/arch/Kconfig
> @@ -276,6 +276,21 @@ config ARCH_THREAD_STACK_ALLOCATOR
>  config ARCH_WANTS_DYNAMIC_TASK_STRUCT
>         bool
>
> +config ARCH_32BIT_OFF_T
> +       bool
> +       depends on !64BIT
> +       help
> +         All new 32-bit architectures should have 64-bit off_t type on
> +         userspace side which corresponds to the loff_t kernel type. This
> +         is the requirement for modern ABIs. Some existing architectures
> +         already have 32-bit off_t. This option is enabled for all such

s/already/still/

> +         architectures explicitly. Namely: arc, arm, blackfin, cris, frv,
> +         h8300, hexagon, m32r, m68k, metag, microblaze, mips32, mn10300,
> +         nios2, openrisc, parisc32, powerpc32, score, sh, sparc, tile32,
> +         unicore32, x86_32 and xtensa. This is the complete list. Any

Do we really need this list here?  It's intended to shrink only.
It includes removed architectures (blackfin, cris, frv, m32r, metag,
mn10300, score, tile32), but lacks several new ones affected by this
patch (c6x, csky, nds32, riscv).

> +         new 32-bit architecture should declare 64-bit off_t type on user
> +         side and so should not enable this option.
> +
>  config HAVE_REGS_AND_STACK_ACCESS_API
>         bool
>         help

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Arnd Bergmann <arnd@arndb.de>, Yury Norov <yury.norov@gmail.com>
Cc: Linux-Arch <linux-arch@vger.kernel.org>,
	"moderated list:H8/300 ARCHITECTURE"
	<uclinux-h8-devel@lists.sourceforge.jp>,
	Yury Norov <ynorov@marvell.com>,
	Yury Norov <ynorov@caviumnetworks.com>,
	y2038 Mailman List <y2038@lists.linaro.org>,
	Linux API <linux-api@vger.kernel.org>,
	Palmer Dabbelt <palmer@sifive.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-riscv@lists.infradead.org,
	Vineet Gupta <vgupta@synopsys.com>, Guo Ren <guoren@kernel.org>,
	Greentime Hu <green.hu@gmail.com>,
	"open list:QUALCOMM HEXAGON..." <linux-hexagon@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Guan Xuetao <gxt@pku.edu.cn>, Stafford Horne <shorne@gmail.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/8] 32-bit userspace ABI: introduce ARCH_32BIT_OFF_T config option
Date: Tue, 19 Feb 2019 09:56:19 +0100	[thread overview]
Message-ID: <CAMuHMdUb47nLkorUpQ1ohD-WMaEG7d3DBAs7JWA6rvgKTZAGGw@mail.gmail.com> (raw)
In-Reply-To: <20190218210712.3503891-3-arnd@arndb.de>

Hi Arnd, Yuri,

On Tue, Feb 19, 2019 at 3:35 AM Arnd Bergmann <arnd@arndb.de> wrote:
> From: Yury Norov <ynorov@caviumnetworks.com>
>
> All new 32-bit architectures should have 64-bit userspace off_t type, but
> existing architectures has 32-bit ones.
>
> To enforce the rule, new config option is added to arch/Kconfig that defaults
> ARCH_32BIT_OFF_T to be disabled for new 32-bit architectures. All existing
> 32-bit architectures enable it explicitly.
>
> New option affects force_o_largefile() behaviour. Namely, if userspace
> off_t is 64-bits long, we have no reason to reject user to open big files.
>
> Note that even if architectures has only 64-bit off_t in the kernel
> (arc, c6x, h8300, hexagon, nios2, openrisc, and unicore32),
> a libc may use 32-bit off_t, and therefore want to limit the file size
> to 4GB unless specified differently in the open flags.
>
> Signed-off-by: Yury Norov <ynorov@caviumnetworks.com>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Yury Norov <ynorov@marvell.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

>  arch/m68k/Kconfig       |  1 +

For m68k:
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

> --- a/arch/Kconfig
> +++ b/arch/Kconfig
> @@ -276,6 +276,21 @@ config ARCH_THREAD_STACK_ALLOCATOR
>  config ARCH_WANTS_DYNAMIC_TASK_STRUCT
>         bool
>
> +config ARCH_32BIT_OFF_T
> +       bool
> +       depends on !64BIT
> +       help
> +         All new 32-bit architectures should have 64-bit off_t type on
> +         userspace side which corresponds to the loff_t kernel type. This
> +         is the requirement for modern ABIs. Some existing architectures
> +         already have 32-bit off_t. This option is enabled for all such

s/already/still/

> +         architectures explicitly. Namely: arc, arm, blackfin, cris, frv,
> +         h8300, hexagon, m32r, m68k, metag, microblaze, mips32, mn10300,
> +         nios2, openrisc, parisc32, powerpc32, score, sh, sparc, tile32,
> +         unicore32, x86_32 and xtensa. This is the complete list. Any

Do we really need this list here?  It's intended to shrink only.
It includes removed architectures (blackfin, cris, frv, m32r, metag,
mn10300, score, tile32), but lacks several new ones affected by this
patch (c6x, csky, nds32, riscv).

> +         new 32-bit architecture should declare 64-bit off_t type on user
> +         side and so should not enable this option.
> +
>  config HAVE_REGS_AND_STACK_ACCESS_API
>         bool
>         help

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-02-19  8:56 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-18 21:07 [PATCH 0/8] y2038: remove time32 ABI on rv32 and csky Arnd Bergmann
2019-02-18 21:07 ` Arnd Bergmann
2019-02-18 21:07 ` Arnd Bergmann
2019-02-18 21:07 ` Arnd Bergmann
2019-02-18 21:07 ` [PATCH 1/8] compat ABI: use non-compat openat and open_by_handle_at variants Arnd Bergmann
2019-02-18 21:07   ` Arnd Bergmann
2019-02-18 21:07   ` Arnd Bergmann
2019-02-18 21:07 ` [PATCH 2/8] 32-bit userspace ABI: introduce ARCH_32BIT_OFF_T config option Arnd Bergmann
2019-02-18 21:07   ` Arnd Bergmann
2019-02-18 21:07   ` Arnd Bergmann
2019-02-19  8:56   ` Geert Uytterhoeven [this message]
2019-02-19  8:56     ` Geert Uytterhoeven
2019-02-19  8:56     ` Geert Uytterhoeven
2019-02-19  8:56     ` Geert Uytterhoeven
2019-02-19  9:10     ` Arnd Bergmann
2019-02-19  9:10       ` Arnd Bergmann
2019-02-19  9:10       ` Arnd Bergmann
2019-02-19  9:10       ` Arnd Bergmann
2019-02-18 21:07 ` [PATCH 3/8] asm-generic: Drop getrlimit and setrlimit syscalls from default list Arnd Bergmann
2019-02-18 21:07   ` Arnd Bergmann
2019-02-18 21:07   ` Arnd Bergmann
2019-02-18 21:07 ` [PATCH 4/8] asm-generic: Make time32 syscall numbers optional Arnd Bergmann
2019-02-18 21:07   ` Arnd Bergmann
2019-02-18 21:07   ` Arnd Bergmann
2019-02-19 20:06   ` Geert Uytterhoeven
2019-02-19 20:06     ` Geert Uytterhoeven
2019-02-19 20:06     ` Geert Uytterhoeven
2019-02-19 20:06     ` Geert Uytterhoeven
2019-02-19 20:06     ` Geert Uytterhoeven
2019-02-19 20:29     ` Arnd Bergmann
2019-02-19 20:29       ` Arnd Bergmann
2019-02-19 20:29       ` Arnd Bergmann
2019-02-19 20:29       ` Arnd Bergmann
2019-02-18 21:07 ` [PATCH 5/8] unicore32: Fix __ARCH_WANT_STAT64 definition Arnd Bergmann
2019-02-18 21:07   ` Arnd Bergmann
2019-02-18 21:07   ` Arnd Bergmann
2019-02-18 21:07   ` Arnd Bergmann
2019-02-18 21:07 ` [PATCH 6/8] checksyscalls: fix up mq_timedreceive and stat exceptions Arnd Bergmann
2019-02-18 21:07   ` Arnd Bergmann
2019-02-18 21:07   ` Arnd Bergmann
2019-02-18 21:07 ` [PATCH 7/8] csky: Use latest system call ABI Arnd Bergmann
2019-02-18 21:07   ` Arnd Bergmann
2019-02-18 21:07   ` Arnd Bergmann
2019-02-18 21:07   ` Arnd Bergmann
2019-02-18 22:40   ` Joseph Myers
2019-02-18 22:40     ` Joseph Myers
2019-02-18 22:40     ` Joseph Myers
2019-02-18 22:40     ` Joseph Myers
2019-02-19  2:18   ` Guo Ren
2019-02-19  2:18     ` Guo Ren
2019-02-19  2:18     ` Guo Ren
2019-02-19  9:03     ` Arnd Bergmann
2019-02-19  9:03       ` Arnd Bergmann
2019-02-19  9:03       ` Arnd Bergmann
2019-02-19  9:03       ` Arnd Bergmann
2019-02-18 21:07 ` [PATCH 8/8] riscv: " Arnd Bergmann
2019-02-18 21:07   ` Arnd Bergmann
2019-02-18 21:07   ` Arnd Bergmann
2019-02-18 21:07   ` Arnd Bergmann
2019-02-25 19:19   ` Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdUb47nLkorUpQ1ohD-WMaEG7d3DBAs7JWA6rvgKTZAGGw@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=arnd@arndb.de \
    --cc=green.hu@gmail.com \
    --cc=guoren@kernel.org \
    --cc=gxt@pku.edu.cn \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-hexagon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@sifive.com \
    --cc=shorne@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=uclinux-h8-devel@lists.sourceforge.jp \
    --cc=vgupta@synopsys.com \
    --cc=y2038@lists.linaro.org \
    --cc=ynorov@caviumnetworks.com \
    --cc=ynorov@marvell.com \
    --cc=yury.norov@gmail.com \
    --subject='Re: [PATCH 2/8] 32-bit userspace ABI: introduce ARCH_32BIT_OFF_T config option' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.