All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: John Keeping <john@metanate.com>
Cc: linux-input <linux-input@vger.kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Input: st1232 - increase "wait ready" timeout
Date: Wed, 29 Sep 2021 19:40:12 +0200	[thread overview]
Message-ID: <CAMuHMdUbegj+VOVucw+qs5j=QSf3-Sez2-sVZBFD55-wSwMFLg@mail.gmail.com> (raw)
In-Reply-To: <20210929152609.2421483-1-john@metanate.com>

On Wed, Sep 29, 2021 at 5:26 PM John Keeping <john@metanate.com> wrote:
> I have a ST1633 touch controller which fails to probe due to a timeout
> waiting for the controller to become ready.  Increasing the minimum
> delay to 100ms ensures that the probe sequence completes successfully.
>
> The ST1633 datasheet says nothing about the maximum delay here and the
> ST1232 I2C protocol document says "wait until" with no notion of a
> timeout.
>
> Since this only runs once during probe, being generous with the timout
> seems reasonable and most likely the device will become ready
> eventually.
>
> (It may be worth noting that I saw this issue with a PREEMPT_RT patched
> kernel which probably has tighter wakeups from usleep_range() than other
> preemption models.)
>
> Fixes: f605be6a57b4 ("Input: st1232 - wait until device is ready before reading resolution")
> Signed-off-by: John Keeping <john@metanate.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2021-09-29 17:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-29 15:26 [PATCH] Input: st1232 - increase "wait ready" timeout John Keeping
2021-09-29 17:40 ` Geert Uytterhoeven [this message]
2021-10-06 18:08 ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdUbegj+VOVucw+qs5j=QSf3-Sez2-sVZBFD55-wSwMFLg@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=john@metanate.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.