From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Date: Wed, 10 Sep 2014 12:40:57 +0000 Subject: Re: [PATCH/RFC 4/5] ARM: shmobile: R-Mobile: Add DT support for PM domains Message-Id: List-Id: References: <1410183344-14756-1-git-send-email-geert+renesas@glider.be> <1410183344-14756-5-git-send-email-geert+renesas@glider.be> <7h1trkkc49.fsf@deeprootsystems.com> In-Reply-To: <7h1trkkc49.fsf@deeprootsystems.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org Hi Kevin, On Tue, Sep 9, 2014 at 6:11 PM, Kevin Hilman wrote: >> +static int r8a7740_pd_a4s_suspend(void) >> +{ >> + /* >> + * The A4S domain contains the CPU core and therefore it should >> + * only be turned off if the CPU is in use. >> + */ >> + return -EBUSY; >> +} > > > Do you have plans to use pm_genpd_attach_cpuidle() for this eventually, > maybe by checking if the enclosing node is a CPU? If not, are there > other plans to handle idle for the power domains that contain CPUs? Yes, the plan is to add more power saving features, and use DT topology analysis to get rid of the hardcoded domain logic. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751413AbaIJMlD (ORCPT ); Wed, 10 Sep 2014 08:41:03 -0400 Received: from mail-la0-f50.google.com ([209.85.215.50]:46472 "EHLO mail-la0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750899AbaIJMk7 (ORCPT ); Wed, 10 Sep 2014 08:40:59 -0400 MIME-Version: 1.0 In-Reply-To: <7h1trkkc49.fsf@deeprootsystems.com> References: <1410183344-14756-1-git-send-email-geert+renesas@glider.be> <1410183344-14756-5-git-send-email-geert+renesas@glider.be> <7h1trkkc49.fsf@deeprootsystems.com> Date: Wed, 10 Sep 2014 14:40:57 +0200 X-Google-Sender-Auth: RvVBJ_s4AUjovcVmSKIq9gLpbJU Message-ID: Subject: Re: [PATCH/RFC 4/5] ARM: shmobile: R-Mobile: Add DT support for PM domains From: Geert Uytterhoeven To: Kevin Hilman Cc: Geert Uytterhoeven , "Rafael J. Wysocki" , Len Brown , Pavel Machek , Simon Horman , Magnus Damm , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Ulf Hansson , Tomasz Figa , Philipp Zabel , Linux PM list , "devicetree@vger.kernel.org" , Linux-sh list , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kevin, On Tue, Sep 9, 2014 at 6:11 PM, Kevin Hilman wrote: >> +static int r8a7740_pd_a4s_suspend(void) >> +{ >> + /* >> + * The A4S domain contains the CPU core and therefore it should >> + * only be turned off if the CPU is in use. >> + */ >> + return -EBUSY; >> +} > > > Do you have plans to use pm_genpd_attach_cpuidle() for this eventually, > maybe by checking if the enclosing node is a CPU? If not, are there > other plans to handle idle for the power domains that contain CPUs? Yes, the plan is to add more power saving features, and use DT topology analysis to get rid of the hardcoded domain logic. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH/RFC 4/5] ARM: shmobile: R-Mobile: Add DT support for PM domains Date: Wed, 10 Sep 2014 14:40:57 +0200 Message-ID: References: <1410183344-14756-1-git-send-email-geert+renesas@glider.be> <1410183344-14756-5-git-send-email-geert+renesas@glider.be> <7h1trkkc49.fsf@deeprootsystems.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <7h1trkkc49.fsf@deeprootsystems.com> Sender: linux-sh-owner@vger.kernel.org To: Kevin Hilman Cc: Geert Uytterhoeven , "Rafael J. Wysocki" , Len Brown , Pavel Machek , Simon Horman , Magnus Damm , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Ulf Hansson , Tomasz Figa , Philipp Zabel , Linux PM list , "devicetree@vger.kernel.org" , Linux-sh list , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" List-Id: devicetree@vger.kernel.org Hi Kevin, On Tue, Sep 9, 2014 at 6:11 PM, Kevin Hilman wrote: >> +static int r8a7740_pd_a4s_suspend(void) >> +{ >> + /* >> + * The A4S domain contains the CPU core and therefore it should >> + * only be turned off if the CPU is in use. >> + */ >> + return -EBUSY; >> +} > > > Do you have plans to use pm_genpd_attach_cpuidle() for this eventually, > maybe by checking if the enclosing node is a CPU? If not, are there > other plans to handle idle for the power domains that contain CPUs? Yes, the plan is to add more power saving features, and use DT topology analysis to get rid of the hardcoded domain logic. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 From: geert@linux-m68k.org (Geert Uytterhoeven) Date: Wed, 10 Sep 2014 14:40:57 +0200 Subject: [PATCH/RFC 4/5] ARM: shmobile: R-Mobile: Add DT support for PM domains In-Reply-To: <7h1trkkc49.fsf@deeprootsystems.com> References: <1410183344-14756-1-git-send-email-geert+renesas@glider.be> <1410183344-14756-5-git-send-email-geert+renesas@glider.be> <7h1trkkc49.fsf@deeprootsystems.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Kevin, On Tue, Sep 9, 2014 at 6:11 PM, Kevin Hilman wrote: >> +static int r8a7740_pd_a4s_suspend(void) >> +{ >> + /* >> + * The A4S domain contains the CPU core and therefore it should >> + * only be turned off if the CPU is in use. >> + */ >> + return -EBUSY; >> +} > > > Do you have plans to use pm_genpd_attach_cpuidle() for this eventually, > maybe by checking if the enclosing node is a CPU? If not, are there > other plans to handle idle for the power domains that contain CPUs? Yes, the plan is to add more power saving features, and use DT topology analysis to get rid of the hardcoded domain logic. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds