From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D18B017EE for ; Fri, 19 Aug 2022 09:40:38 +0000 (UTC) Received: by mail-qv1-f53.google.com with SMTP id d1so3006759qvs.0 for ; Fri, 19 Aug 2022 02:40:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=bRymBzdXlfqAZ/An0FhEAiaTJ5r51uvoXyU3bQ2b9Zs=; b=URl40V3Gb29RXVwGpgiVNQTH5uivrloVk1cHjELtfsyLSMEMVQ99rs4I0uiN4k+udz s2v3MzA2tcf24wvlZOMPaFTWEigN3j/5Vvi9htI2ekyHXoIn+aKK4JrfIggD97rvUBHZ /KdGMAUzNb9RZLoAQeBEMam2TJ7Z21UZPpTWU3rmxHAOAlu4N07i17r7J5iSSHUk/Qg2 EClRESGBbKn0GWjNLbjheUHRUfHWQru8lHVBrxHMElA9GgJPjkalA6CH/Wrr48LnN9Ls dK/SVEEJu73kG796hvSVUkVhUDQpSgC07Gxsa3D7OYg0U7DEa9XxkFiahztTrbEriEvN DpkA== X-Gm-Message-State: ACgBeo2GZPlPrVGG7+lV1hDNla+r6QmphLWfptml4A1sugu3nU9DRtqn Rw1aR6BrmQg0k+ksncTTNpm8k82lGUcN5Z8y X-Google-Smtp-Source: AA6agR6LQixIPMO257L7CJMGrwjUyBTKNVXdrxPnaHvfLM1pQrR3R19DIhbYtuWfvprrwpdhygfYSQ== X-Received: by 2002:a05:6214:509e:b0:496:a98a:fd5 with SMTP id kk30-20020a056214509e00b00496a98a0fd5mr5648704qvb.2.1660902037623; Fri, 19 Aug 2022 02:40:37 -0700 (PDT) Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com. [209.85.128.173]) by smtp.gmail.com with ESMTPSA id v9-20020a05622a014900b00342f8d4d0basm2955320qtw.43.2022.08.19.02.40.36 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Aug 2022 02:40:36 -0700 (PDT) Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-3378303138bso67170087b3.9 for ; Fri, 19 Aug 2022 02:40:36 -0700 (PDT) X-Received: by 2002:a25:250b:0:b0:68f:425b:3ee0 with SMTP id l11-20020a25250b000000b0068f425b3ee0mr6898469ybl.89.1660902025045; Fri, 19 Aug 2022 02:40:25 -0700 (PDT) Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20220819014406.32266-1-wangkefeng.wang@huawei.com> In-Reply-To: <20220819014406.32266-1-wangkefeng.wang@huawei.com> From: Geert Uytterhoeven Date: Fri, 19 Aug 2022 11:40:14 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] kernel: exit: cleanup release_thread() To: Kefeng Wang Cc: Richard Henderson , Ivan Kokshaysky , Matt Turner , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Brian Cain , Huacai Chen , WANG Xuerui , Michal Simek , Thomas Bogendoerfer , Dinh Nguyen , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E . J . Bottomley" , Helge Deller , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , "David S . Miller" , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "the arch/x86 maintainers" , Chris Zankel , Max Filippov , alpha , Linux Kernel Mailing List , arcml , Linux ARM , linux-csky@vger.kernel.org, "open list:QUALCOMM HEXAGON..." , "linux-ia64@vger.kernel.org" , loongarch@lists.linux.dev, linux-m68k , "open list:BROADCOM NVRAM DRIVER" , Openrisc , Parisc List , linuxppc-dev , linux-riscv , linux-s390 , Linux-sh list , sparclinux , linux-um , "open list:TENSILICA XTENSA PORT (xtensa)" , Andrew Morton Content-Type: text/plain; charset="UTF-8" Hi Kefeng, On Fri, Aug 19, 2022 at 3:39 AM Kefeng Wang wrote: > Only x86 has own release_thread(), introduce a new weak > release_thread() function to clean empty definitions in > other ARCHs. > > Signed-off-by: Kefeng Wang > arch/m68k/include/asm/processor.h | 5 ----- Acked-by: Geert Uytterhoeven > --- a/kernel/exit.c > +++ b/kernel/exit.c > @@ -183,6 +183,10 @@ void put_task_struct_rcu_user(struct task_struct *task) > call_rcu(&task->rcu, delayed_put_task_struct); > } > > +void __weak release_thread(struct task_struct *dead_task) > +{ > +} As the default implementation is empty, it might be better to keep this as a static inline function, protected by #ifndef release_thread, and let x86 #define release_thread. > + > void release_task(struct task_struct *p) > { > struct task_struct *leader; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05796C32771 for ; Fri, 19 Aug 2022 09:40:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bIY1Z23AXUdXyOJ19seK7WOB69Qw+5YJolHNQT8L6FM=; b=ZYIAd8FhZNYeYE p1sVtd0EvUnufx6aYCDtadQWd7qOuUCTF1jJbgd5f/gD/xFzy8nXrvb1+A0bqHuhFBUydVenu+qr/ wrtJeSs+kvqyXoZTNN3kkRGN9+5ZOJI2THOAxuqFAJTEvlEfLv8s7ozth1OJgNnsmmNzmiUdAGOVl 7+px8azkRWzZ9ldltmRczQvaKqk3IrGZkZvCglXjDONs/iASx+NVkVN1GT7LX9yY7modQEAHK/4Xk q5lYpzJ+2SQWM8WBwUA1WtVsJMnyZaJGLSVcDBSwhuwX/1b9LB8S42wIX/9/KetZX/hPj1z/3h3zr 61vSVcu9PFfcjfJdXt+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oOyUa-0056aH-4g; Fri, 19 Aug 2022 09:40:40 +0000 Received: from mail-oi1-f176.google.com ([209.85.167.176]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oOyUW-0056Y9-SQ; Fri, 19 Aug 2022 09:40:38 +0000 Received: by mail-oi1-f176.google.com with SMTP id w197so4229907oie.5; Fri, 19 Aug 2022 02:40:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=bRymBzdXlfqAZ/An0FhEAiaTJ5r51uvoXyU3bQ2b9Zs=; b=dmhm7PkPP4XybjOnjt1LK7mR2owOCdAYAB1LhHcbI2fG5SqUikCyTZf+lKQ1qzG9BI m0BB0De3uWZWWS+Pgzvtz0iAT20E/fySH/HcpqSMfyYQm0Pm7BFST7Iq65zq1pVNhnRy LkFjS/YARK1yPu/Xc+cZhTsOnZm54Hbz+n4ayyidLTslemfW95MINz7InXk1DC7x6Bjb Xud8MYoYFnjTrkVtVFrifnG66aA0o0MoFBv0JFCVMqb9kCy7TfXU+Cr+nRApNA9vb3cq zFZt5JacUovihzUIKd/0xfvIBWHrZliyd7TA0j3X1COHGQSmPWYGqo3HiQpWvsDBuvP9 Z52A== X-Gm-Message-State: ACgBeo1W35HSomSHbAuAZEEUVfWblDi7wBSf8CDZ6cvCOn5k/K/TY5Kq 31D2MZjT5P4ELy2xXHi9qxuhsPDD42Eg3xjJ X-Google-Smtp-Source: AA6agR5K9gqjuVMdcO0ElADvZAG0zfpvDYn+FaO336ykpcurN7VR8BI07+bx1skyyV9LSdPslQkcVw== X-Received: by 2002:a05:6808:170b:b0:333:53cf:8022 with SMTP id bc11-20020a056808170b00b0033353cf8022mr5468110oib.28.1660902035601; Fri, 19 Aug 2022 02:40:35 -0700 (PDT) Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com. [209.85.210.41]) by smtp.gmail.com with ESMTPSA id v12-20020a056870708c00b0010e20d0b2e3sm1142190oae.44.2022.08.19.02.40.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Aug 2022 02:40:35 -0700 (PDT) Received: by mail-ot1-f41.google.com with SMTP id a14-20020a0568300b8e00b0061c4e3eb52aso2754482otv.3; Fri, 19 Aug 2022 02:40:35 -0700 (PDT) X-Received: by 2002:a25:250b:0:b0:68f:425b:3ee0 with SMTP id l11-20020a25250b000000b0068f425b3ee0mr6898469ybl.89.1660902025045; Fri, 19 Aug 2022 02:40:25 -0700 (PDT) MIME-Version: 1.0 References: <20220819014406.32266-1-wangkefeng.wang@huawei.com> In-Reply-To: <20220819014406.32266-1-wangkefeng.wang@huawei.com> From: Geert Uytterhoeven Date: Fri, 19 Aug 2022 11:40:14 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] kernel: exit: cleanup release_thread() To: Kefeng Wang Cc: Richard Henderson , Ivan Kokshaysky , Matt Turner , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Brian Cain , Huacai Chen , WANG Xuerui , Michal Simek , Thomas Bogendoerfer , Dinh Nguyen , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E . J . Bottomley" , Helge Deller , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , "David S . Miller" , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "the arch/x86 maintainers" , Chris Zankel , Max Filippov , alpha , Linux Kernel Mailing List , arcml , Linux ARM , linux-csky@vger.kernel.org, "open list:QUALCOMM HEXAGON..." , "linux-ia64@vger.kernel.org" , loongarch@lists.linux.dev, linux-m68k , "open list:BROADCOM NVRAM DRIVER" , Openrisc , Parisc List , linuxppc-dev , linux-riscv , linux-s390 , Linux-sh list , sparclinux , linux-um , "open list:TENSILICA XTENSA PORT (xtensa)" , Andrew Morton X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220819_024036_949059_EAB48E25 X-CRM114-Status: GOOD ( 21.16 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Hi Kefeng, On Fri, Aug 19, 2022 at 3:39 AM Kefeng Wang wrote: > Only x86 has own release_thread(), introduce a new weak > release_thread() function to clean empty definitions in > other ARCHs. > > Signed-off-by: Kefeng Wang > arch/m68k/include/asm/processor.h | 5 ----- Acked-by: Geert Uytterhoeven > --- a/kernel/exit.c > +++ b/kernel/exit.c > @@ -183,6 +183,10 @@ void put_task_struct_rcu_user(struct task_struct *task) > call_rcu(&task->rcu, delayed_put_task_struct); > } > > +void __weak release_thread(struct task_struct *dead_task) > +{ > +} As the default implementation is empty, it might be better to keep this as a static inline function, protected by #ifndef release_thread, and let x86 #define release_thread. > + > void release_task(struct task_struct *p) > { > struct task_struct *leader; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A0C2C3F6B0 for ; Fri, 19 Aug 2022 09:40:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WSgG8f/AK0TBWXoKWFkHHxDgFFtAXtAvEr3XAWeJQds=; b=g2OQPqnjGuvQfp RiIKDZd7KP00MKJweS6VzmJUJR/w5DwdRif360EHU8r5/7ArmnwgTp5xMtUIEOpvlxP/+GoJD+I/P AVGJ4JL4rbcuvw0zXNpucg1nO/8au9NaCMZFlT5BiEY4v3HyGoZY2ri68JbX9A2jia1eFtQhldM2+ 9y2hd5bqKGq00rbqB2YfjNFw7q5esPEPHBUC2F+5mmNrhQAJ4vqBnnVE3M4pzRio7blVhIcIWUmza h05ZkmSUuqmXjX7jmepp2yC76HyFymzsfeXvJBSJsKU9OX2CvlAxWQGwwbW1MzflRXE2wOyRzjdVz enMV+h1O5pbaLBkjQxkg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oOyUZ-0056a5-Qf; Fri, 19 Aug 2022 09:40:39 +0000 Received: from mail-oi1-f176.google.com ([209.85.167.176]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oOyUW-0056Y9-SQ; Fri, 19 Aug 2022 09:40:38 +0000 Received: by mail-oi1-f176.google.com with SMTP id w197so4229907oie.5; Fri, 19 Aug 2022 02:40:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=bRymBzdXlfqAZ/An0FhEAiaTJ5r51uvoXyU3bQ2b9Zs=; b=dmhm7PkPP4XybjOnjt1LK7mR2owOCdAYAB1LhHcbI2fG5SqUikCyTZf+lKQ1qzG9BI m0BB0De3uWZWWS+Pgzvtz0iAT20E/fySH/HcpqSMfyYQm0Pm7BFST7Iq65zq1pVNhnRy LkFjS/YARK1yPu/Xc+cZhTsOnZm54Hbz+n4ayyidLTslemfW95MINz7InXk1DC7x6Bjb Xud8MYoYFnjTrkVtVFrifnG66aA0o0MoFBv0JFCVMqb9kCy7TfXU+Cr+nRApNA9vb3cq zFZt5JacUovihzUIKd/0xfvIBWHrZliyd7TA0j3X1COHGQSmPWYGqo3HiQpWvsDBuvP9 Z52A== X-Gm-Message-State: ACgBeo1W35HSomSHbAuAZEEUVfWblDi7wBSf8CDZ6cvCOn5k/K/TY5Kq 31D2MZjT5P4ELy2xXHi9qxuhsPDD42Eg3xjJ X-Google-Smtp-Source: AA6agR5K9gqjuVMdcO0ElADvZAG0zfpvDYn+FaO336ykpcurN7VR8BI07+bx1skyyV9LSdPslQkcVw== X-Received: by 2002:a05:6808:170b:b0:333:53cf:8022 with SMTP id bc11-20020a056808170b00b0033353cf8022mr5468110oib.28.1660902035601; Fri, 19 Aug 2022 02:40:35 -0700 (PDT) Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com. [209.85.210.41]) by smtp.gmail.com with ESMTPSA id v12-20020a056870708c00b0010e20d0b2e3sm1142190oae.44.2022.08.19.02.40.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Aug 2022 02:40:35 -0700 (PDT) Received: by mail-ot1-f41.google.com with SMTP id a14-20020a0568300b8e00b0061c4e3eb52aso2754482otv.3; Fri, 19 Aug 2022 02:40:35 -0700 (PDT) X-Received: by 2002:a25:250b:0:b0:68f:425b:3ee0 with SMTP id l11-20020a25250b000000b0068f425b3ee0mr6898469ybl.89.1660902025045; Fri, 19 Aug 2022 02:40:25 -0700 (PDT) MIME-Version: 1.0 References: <20220819014406.32266-1-wangkefeng.wang@huawei.com> In-Reply-To: <20220819014406.32266-1-wangkefeng.wang@huawei.com> From: Geert Uytterhoeven Date: Fri, 19 Aug 2022 11:40:14 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] kernel: exit: cleanup release_thread() To: Kefeng Wang Cc: Richard Henderson , Ivan Kokshaysky , Matt Turner , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Brian Cain , Huacai Chen , WANG Xuerui , Michal Simek , Thomas Bogendoerfer , Dinh Nguyen , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E . J . Bottomley" , Helge Deller , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , "David S . Miller" , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "the arch/x86 maintainers" , Chris Zankel , Max Filippov , alpha , Linux Kernel Mailing List , arcml , Linux ARM , linux-csky@vger.kernel.org, "open list:QUALCOMM HEXAGON..." , "linux-ia64@vger.kernel.org" , loongarch@lists.linux.dev, linux-m68k , "open list:BROADCOM NVRAM DRIVER" , Openrisc , Parisc List , linuxppc-dev , linux-riscv , linux-s390 , Linux-sh list , sparclinux , linux-um , "open list:TENSILICA XTENSA PORT (xtensa)" , Andrew Morton X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220819_024036_949059_EAB48E25 X-CRM114-Status: GOOD ( 21.16 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org Hi Kefeng, On Fri, Aug 19, 2022 at 3:39 AM Kefeng Wang wrote: > Only x86 has own release_thread(), introduce a new weak > release_thread() function to clean empty definitions in > other ARCHs. > > Signed-off-by: Kefeng Wang > arch/m68k/include/asm/processor.h | 5 ----- Acked-by: Geert Uytterhoeven > --- a/kernel/exit.c > +++ b/kernel/exit.c > @@ -183,6 +183,10 @@ void put_task_struct_rcu_user(struct task_struct *task) > call_rcu(&task->rcu, delayed_put_task_struct); > } > > +void __weak release_thread(struct task_struct *dead_task) > +{ > +} As the default implementation is empty, it might be better to keep this as a static inline function, protected by #ifndef release_thread, and let x86 #define release_thread. > + > void release_task(struct task_struct *p) > { > struct task_struct *leader; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.librecores.org (lists.librecores.org [88.198.125.70]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13BADC32773 for ; Fri, 19 Aug 2022 09:40:42 +0000 (UTC) Received: from [172.31.1.100] (localhost.localdomain [127.0.0.1]) by mail.librecores.org (Postfix) with ESMTP id B8250214F6; Fri, 19 Aug 2022 11:40:41 +0200 (CEST) Received: from mail-oa1-f44.google.com (mail-oa1-f44.google.com [209.85.160.44]) by mail.librecores.org (Postfix) with ESMTPS id 40A79211B0 for ; Fri, 19 Aug 2022 11:40:39 +0200 (CEST) Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-11c59785966so4641721fac.11 for ; Fri, 19 Aug 2022 02:40:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=bRymBzdXlfqAZ/An0FhEAiaTJ5r51uvoXyU3bQ2b9Zs=; b=fg4FP3WKDoH7iIAvWVvHkPI8g/lnriXZB/VnG+/5P/jGcHU5l45EN7A26k2euRO7R2 /g7h0PKZnjzrQMhMGkilaGXm3ti8jMZSdg+o/HspwvCQkkS7wFOxx/ZpFpeCM7BjmdiG 8Va5Djc/hhVIe+tNPPx+LcyY3ldBOE4FgFw+i1tHxYwYKwNOc05rQ216V9i//PlUK7lE D8/eirUZ+JwE77cQMdnf636ubs6kTLylihShxw4VbQeufJIdQlaFlXCXDe0iGOdC/IbI TyBYxzNFqODVrcXZOgiAJkKQnsOjRtY1SJBphLkEgHQYolRT61age9gbaV/3bP2au3v1 45xA== X-Gm-Message-State: ACgBeo2bM7wdWT0Y9FelQ8WAUbI87T2m82Qi2GuGW7/jS0LwDAmo+yB2 ZT/Gt4pGYciP+PI6sTrpDNUjsMwFltnkcGxP X-Google-Smtp-Source: AA6agR6QjplwU8HU1DrSnDBX6hmFsJM6uTqEa/1B05P7XuTlLZ2EcwbNPkBHfPbXKN8N6DRE6BiWuQ== X-Received: by 2002:a05:6870:15c9:b0:101:cdac:3887 with SMTP id k9-20020a05687015c900b00101cdac3887mr3260827oad.35.1660902037884; Fri, 19 Aug 2022 02:40:37 -0700 (PDT) Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com. [209.85.210.52]) by smtp.gmail.com with ESMTPSA id x36-20020a05683040a400b00638cea5947esm1041387ott.25.2022.08.19.02.40.36 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Aug 2022 02:40:36 -0700 (PDT) Received: by mail-ot1-f52.google.com with SMTP id m21-20020a9d6ad5000000b00638df677850so2745843otq.5 for ; Fri, 19 Aug 2022 02:40:36 -0700 (PDT) X-Received: by 2002:a25:250b:0:b0:68f:425b:3ee0 with SMTP id l11-20020a25250b000000b0068f425b3ee0mr6898469ybl.89.1660902025045; Fri, 19 Aug 2022 02:40:25 -0700 (PDT) MIME-Version: 1.0 References: <20220819014406.32266-1-wangkefeng.wang@huawei.com> In-Reply-To: <20220819014406.32266-1-wangkefeng.wang@huawei.com> From: Geert Uytterhoeven Date: Fri, 19 Aug 2022 11:40:14 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] kernel: exit: cleanup release_thread() To: Kefeng Wang Content-Type: text/plain; charset="UTF-8" X-BeenThere: openrisc@lists.librecores.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Discussion around the OpenRISC processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , Thomas Gleixner , Linux-sh list , Catalin Marinas , Dave Hansen , the arch/x86 maintainers , "open list:BROADCOM NVRAM DRIVER" , "James E . J . Bottomley" , Max Filippov , Guo Ren , linux-csky@vger.kernel.org, sparclinux , "open list:QUALCOMM HEXAGON..." , WANG Xuerui , Will Deacon , Alexander Gordeev , Anton Ivanov , Jonas Bonn , linux-s390 , "linux-ia64@vger.kernel.org" , arcml , Yoshinori Sato , Michael Ellerman , Helge Deller , Huacai Chen , Russell King , Christophe Leroy , Ingo Molnar , Vineet Gupta , Matt Turner , Christian Borntraeger , "open list:TENSILICA XTENSA PORT \(xtensa\)" , Vasily Gorbik , Chris Zankel , linux-um , Heiko Carstens , alpha , Richard Henderson , Nicholas Piggin , linux-m68k , Openrisc , Ivan Kokshaysky , loongarch@lists.linux.dev, Paul Walmsley , Andrew Morton , Linux ARM , Brian Cain , Michal Simek , Thomas Bogendoerfer , Parisc List , Linux Kernel Mailing List , Dinh Nguyen , linux-riscv , Palmer Dabbelt , Sven Schnelle , Richard Weinberger , Borislav Petkov , Johannes Berg , linuxppc-dev , "David S . Miller" Errors-To: openrisc-bounces@lists.librecores.org Sender: "OpenRISC" Hi Kefeng, On Fri, Aug 19, 2022 at 3:39 AM Kefeng Wang wrote: > Only x86 has own release_thread(), introduce a new weak > release_thread() function to clean empty definitions in > other ARCHs. > > Signed-off-by: Kefeng Wang > arch/m68k/include/asm/processor.h | 5 ----- Acked-by: Geert Uytterhoeven > --- a/kernel/exit.c > +++ b/kernel/exit.c > @@ -183,6 +183,10 @@ void put_task_struct_rcu_user(struct task_struct *task) > call_rcu(&task->rcu, delayed_put_task_struct); > } > > +void __weak release_thread(struct task_struct *dead_task) > +{ > +} As the default implementation is empty, it might be better to keep this as a static inline function, protected by #ifndef release_thread, and let x86 #define release_thread. > + > void release_task(struct task_struct *p) > { > struct task_struct *leader; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4083C28D13 for ; Fri, 19 Aug 2022 23:27:40 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4M8dG32mWbz3cCW for ; Sat, 20 Aug 2022 09:27:39 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.160.180; helo=mail-qt1-f180.google.com; envelope-from=geert.uytterhoeven@gmail.com; receiver=) Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4M8Gvs1pLNz3c95 for ; Fri, 19 Aug 2022 19:40:39 +1000 (AEST) Received: by mail-qt1-f180.google.com with SMTP id w28so2930027qtc.7 for ; Fri, 19 Aug 2022 02:40:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=bRymBzdXlfqAZ/An0FhEAiaTJ5r51uvoXyU3bQ2b9Zs=; b=1cjjdvt3tO2nhySziP3D98LhsoVwsDhJeaqJbgYOsbjDMk9J89gEipxU/AVbSqTRHv rbjWAoK8pAfPx6OXCGQUp78Lm/fYdgpTptJbGjVi+Q2rvmzWPwVYPK/wb5eduZyjKrmq 83yRt57Bs39cNL46AjNEsBabeHjZZOUShdhcRldp72cSfHOP9atgHoFSd333541BCgWq Sve23b1VFqka/bErH31vbYUfs+TOCIpCKR6dPNQKfehFW3QwoF+XMJk1ki3yKP0YFYXd f2aaAXdLJHOZTEw2/SZoKsaYQl6uOhdAEKWb3dnSSJg4Q6np9ovKy11qUrBKNneEK1n6 9lQQ== X-Gm-Message-State: ACgBeo2oby+X3/7QrmiVDzEK9tmFZQBDc5Czjoc2dMPzFf9OWV3iOYXy nHwuwzJo40Ot+Ty6CE04H0S2lML0QAH9AhFj X-Google-Smtp-Source: AA6agR57N6Jg1c55UfhWZ1eotz6yef4Hq9MYO2Df/X01cMpiYGP3QbvcVSP72YHtRuEk0sALfdfhig== X-Received: by 2002:a05:622a:1716:b0:344:1e56:9436 with SMTP id h22-20020a05622a171600b003441e569436mr5602809qtk.289.1660902035751; Fri, 19 Aug 2022 02:40:35 -0700 (PDT) Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com. [209.85.128.176]) by smtp.gmail.com with ESMTPSA id v9-20020a05622a014900b00342f8d4d0basm2955304qtw.43.2022.08.19.02.40.35 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Aug 2022 02:40:35 -0700 (PDT) Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-3376851fe13so73901387b3.6 for ; Fri, 19 Aug 2022 02:40:35 -0700 (PDT) X-Received: by 2002:a25:250b:0:b0:68f:425b:3ee0 with SMTP id l11-20020a25250b000000b0068f425b3ee0mr6898469ybl.89.1660902025045; Fri, 19 Aug 2022 02:40:25 -0700 (PDT) MIME-Version: 1.0 References: <20220819014406.32266-1-wangkefeng.wang@huawei.com> In-Reply-To: <20220819014406.32266-1-wangkefeng.wang@huawei.com> From: Geert Uytterhoeven Date: Fri, 19 Aug 2022 11:40:14 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] kernel: exit: cleanup release_thread() To: Kefeng Wang Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Sat, 20 Aug 2022 09:27:17 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , Thomas Gleixner , Linux-sh list , Catalin Marinas , Dave Hansen , the arch/x86 maintainers , "open list:BROADCOM NVRAM DRIVER" , "James E . J . Bottomley" , Max Filippov , Guo Ren , linux-csky@vger.kernel.org, sparclinux , "open list:QUALCOMM HEXAGON..." , WANG Xuerui , Will Deacon , Alexander Gordeev , Anton Ivanov , Jonas Bonn , linux-s390 , "linux-ia64@vger.kernel.org" , arcml , Yoshinori Sato , Helge Deller , Huacai Chen , Russell King , Ingo Molnar , Vineet Gupta , Matt Turner , Christian Borntraeger , "open list:TENSILICA XTENSA PORT \(xtensa\)" , Vasily Gorbik , Chris Zankel , linux-um , Heiko Carstens , alpha , Richard Henderson , Nicholas Piggin , Stefan Kristiansson , linux-m68k , Openrisc , Ivan Kokshaysky , loongarch@lists.linux.dev, Paul Walmsley , Stafford Horne , Andrew Morton , Linux ARM , Brian Cain , Michal Simek , Thomas Bogendoerfer , Parisc List , Linux Kernel Mailing List , Dinh Nguyen , linux-riscv , Palmer Dabbelt , Sven Schnelle , Richard Weinberger , Borislav Petkov , Johannes Berg , linuxppc-dev , "David S . Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Kefeng, On Fri, Aug 19, 2022 at 3:39 AM Kefeng Wang wrote: > Only x86 has own release_thread(), introduce a new weak > release_thread() function to clean empty definitions in > other ARCHs. > > Signed-off-by: Kefeng Wang > arch/m68k/include/asm/processor.h | 5 ----- Acked-by: Geert Uytterhoeven > --- a/kernel/exit.c > +++ b/kernel/exit.c > @@ -183,6 +183,10 @@ void put_task_struct_rcu_user(struct task_struct *task) > call_rcu(&task->rcu, delayed_put_task_struct); > } > > +void __weak release_thread(struct task_struct *dead_task) > +{ > +} As the default implementation is empty, it might be better to keep this as a static inline function, protected by #ifndef release_thread, and let x86 #define release_thread. > + > void release_task(struct task_struct *p) > { > struct task_struct *leader; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 MIME-Version: 1.0 Date: Fri, 19 Aug 2022 11:40:14 +0200 References: <20220819014406.32266-1-wangkefeng.wang@huawei.com> In-Reply-To: <20220819014406.32266-1-wangkefeng.wang@huawei.com> Message-ID: Subject: Re: [PATCH] kernel: exit: cleanup release_thread() From: Geert Uytterhoeven Content-Type: text/plain; charset="UTF-8" To: Kefeng Wang Cc: Richard Henderson , Ivan Kokshaysky , Matt Turner , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Brian Cain , Huacai Chen , WANG Xuerui , Michal Simek , Thomas Bogendoerfer , Dinh Nguyen , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E . J . Bottomley" , Helge Deller , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , "David S . Miller" , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , the arch/x86 maintainers , Chris Zankel , Max Filippov , alpha , Linux Kernel Mailing List , arcml , Linux ARM , linux-csky@vger.kernel.org, "open list:QUALCOMM HEXAGON..." , "linux-ia64@vger.kernel.org" , loongarch@lists.linux.dev, linux-m68k , "open list:BROADCOM NVRAM DRIVER" , Openrisc , Parisc List , linuxppc-dev , linux-riscv , linux-s390 , Linux-sh list , sparclinux , linux-um , "open list:TENSILICA XTENSA PORT (xtensa)" , Andrew Morton , Kefeng Wang List-ID: Hi Kefeng, On Fri, Aug 19, 2022 at 3:39 AM Kefeng Wang wrote: > Only x86 has own release_thread(), introduce a new weak > release_thread() function to clean empty definitions in > other ARCHs. > > Signed-off-by: Kefeng Wang > arch/m68k/include/asm/processor.h | 5 ----- Acked-by: Geert Uytterhoeven > --- a/kernel/exit.c > +++ b/kernel/exit.c > @@ -183,6 +183,10 @@ void put_task_struct_rcu_user(struct task_struct *task) > call_rcu(&task->rcu, delayed_put_task_struct); > } > > +void __weak release_thread(struct task_struct *dead_task) > +{ > +} As the default implementation is empty, it might be better to keep this as a static inline function, protected by #ifndef release_thread, and let x86 #define release_thread. > + > void release_task(struct task_struct *p) > { > struct task_struct *leader; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Date: Fri, 19 Aug 2022 09:40:14 +0000 Subject: Re: [PATCH] kernel: exit: cleanup release_thread() Message-Id: List-Id: References: <20220819014406.32266-1-wangkefeng.wang@huawei.com> In-Reply-To: <20220819014406.32266-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Kefeng Wang Cc: Richard Henderson , Ivan Kokshaysky , Matt Turner , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Brian Cain , Huacai Chen , WANG Xuerui , Michal Simek , Thomas Bogendoerfer , Dinh Nguyen , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E . J . Bottomley" , Helge Deller , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , "David S . Miller" , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , the arch/x86 maintainers , Chris Zankel , Max Filippov , alpha , Linux Kernel Mailing List , arcml , Linux ARM , linux-csky@vger.kernel.org, "open list:QUALCOMM HEXAGON..." , "linux-ia64@vger.kernel.org" , loongarch@lists.linux.dev, linux-m68k , "open list:BROADCOM NVRAM DRIVER" , Openrisc , Parisc List , linuxppc-dev , linux-riscv , linux-s390 , Linux-sh list , sparclinux , linux-um , "open list:TENSILICA XTENSA PORT (xtensa)" , Andrew Morton Hi Kefeng, On Fri, Aug 19, 2022 at 3:39 AM Kefeng Wang wrote: > Only x86 has own release_thread(), introduce a new weak > release_thread() function to clean empty definitions in > other ARCHs. > > Signed-off-by: Kefeng Wang > arch/m68k/include/asm/processor.h | 5 ----- Acked-by: Geert Uytterhoeven > --- a/kernel/exit.c > +++ b/kernel/exit.c > @@ -183,6 +183,10 @@ void put_task_struct_rcu_user(struct task_struct *task) > call_rcu(&task->rcu, delayed_put_task_struct); > } > > +void __weak release_thread(struct task_struct *dead_task) > +{ > +} As the default implementation is empty, it might be better to keep this as a static inline function, protected by #ifndef release_thread, and let x86 #define release_thread. > + > void release_task(struct task_struct *p) > { > struct task_struct *leader; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH] kernel: exit: cleanup release_thread() Date: Fri, 19 Aug 2022 11:40:14 +0200 Message-ID: References: <20220819014406.32266-1-wangkefeng.wang@huawei.com> Mime-Version: 1.0 Return-path: In-Reply-To: <20220819014406.32266-1-wangkefeng.wang@huawei.com> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Kefeng Wang Cc: Richard Henderson , Ivan Kokshaysky , Matt Turner , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Brian Cain , Huacai Chen , WANG Xuerui , Michal Simek , Thomas Bogendoerfer , Dinh Nguyen , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E . J . Bottomley" , Helge Deller , Michael Hi Kefeng, On Fri, Aug 19, 2022 at 3:39 AM Kefeng Wang wrote: > Only x86 has own release_thread(), introduce a new weak > release_thread() function to clean empty definitions in > other ARCHs. > > Signed-off-by: Kefeng Wang > arch/m68k/include/asm/processor.h | 5 ----- Acked-by: Geert Uytterhoeven > --- a/kernel/exit.c > +++ b/kernel/exit.c > @@ -183,6 +183,10 @@ void put_task_struct_rcu_user(struct task_struct *task) > call_rcu(&task->rcu, delayed_put_task_struct); > } > > +void __weak release_thread(struct task_struct *dead_task) > +{ > +} As the default implementation is empty, it might be better to keep this as a static inline function, protected by #ifndef release_thread, and let x86 #define release_thread. > + > void release_task(struct task_struct *p) > { > struct task_struct *leader; Gr{oetje,eeting}s, Geert