From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05006C38142 for ; Fri, 27 Jan 2023 09:31:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233082AbjA0JbU (ORCPT ); Fri, 27 Jan 2023 04:31:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232599AbjA0JbN (ORCPT ); Fri, 27 Jan 2023 04:31:13 -0500 Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B65F13525B; Fri, 27 Jan 2023 01:30:59 -0800 (PST) Received: by mail-qt1-f173.google.com with SMTP id d3so3527600qte.8; Fri, 27 Jan 2023 01:30:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=y5Bg3XM00OVfj9CBB6CoZK0gXWkuIJjg1b6VOboGlP0=; b=XwJsvxvMsfDZGSghlm0dYwvsrCL75svGWecLZhJ0aoVePvbuzJ428EN0kFrT8cr6ru 0NVzH4WLglrA6Pbkh0Z56IiC7d2ltc6pie85lxoroxTyrULsyd9erQ7CxBNmLveYHRx1 620Ge5UwZv9s0n2KlMMcXBlh6HMzMivPumZ8MIU9mf+JyMVATgLfqYMIiCMizXxG4tVv UjJK2WjDKCHJAAiZtsZxqKsX31AmqfEfCZct1VwxIQ3rK7yCD8FJ9n9w3Sb12OP0nWFc ojDKOWyLw1GWYq1I01X8LDPldRX5CjSDavZd0trup0PnwgpnKiDhp2nSfF3VZkd5yBHS dBpQ== X-Gm-Message-State: AO0yUKX/3qj204gabMa0AU5YB5yJlwblQAcf9p1M9E3bQIB06vMmueVD UAw5rr0hsKDVvR+r58QD+AXmVAY8s0k04A== X-Google-Smtp-Source: AK7set/Px2mTQDnrXaZgF6X6CiXK0u7yJDkBADmtJXaT3kxEYBk/8+kZaO3X0I854oj+fX8IJVyqlw== X-Received: by 2002:ac8:7f50:0:b0:3b7:fc64:2149 with SMTP id g16-20020ac87f50000000b003b7fc642149mr19026297qtk.44.1674811858627; Fri, 27 Jan 2023 01:30:58 -0800 (PST) Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com. [209.85.219.170]) by smtp.gmail.com with ESMTPSA id n7-20020ac86747000000b003ab43dabfb1sm2344965qtp.55.2023.01.27.01.30.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Jan 2023 01:30:58 -0800 (PST) Received: by mail-yb1-f170.google.com with SMTP id m199so5264617ybm.4; Fri, 27 Jan 2023 01:30:58 -0800 (PST) X-Received: by 2002:a25:dd8:0:b0:80a:6a1c:7c3b with SMTP id 207-20020a250dd8000000b0080a6a1c7c3bmr2129588ybn.89.1674811847373; Fri, 27 Jan 2023 01:30:47 -0800 (PST) MIME-Version: 1.0 References: <20230127001141.407071-1-saravanak@google.com> <20230127001141.407071-4-saravanak@google.com> In-Reply-To: From: Geert Uytterhoeven Date: Fri, 27 Jan 2023 10:30:35 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 03/11] soc: renesas: Move away from using OF_POPULATED for fw_devlink To: Andy Shevchenko Cc: Saravana Kannan , Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Len Brown , Daniel Scally , Heikki Krogerus , Sakari Ailus , Tony Lindgren , Linux Kernel Functional Testing , Naresh Kamboju , Abel Vesa , Alexander Stein , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Miquel Raynal , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi Andy, On Fri, Jan 27, 2023 at 10:25 AM Andy Shevchenko wrote: > On Thu, Jan 26, 2023 at 04:11:30PM -0800, Saravana Kannan wrote: > > The OF_POPULATED flag was set to let fw_devlink know that the device > > tree node will not have a struct device created for it. This information > > is used by fw_devlink to avoid deferring the probe of consumers of this > > device tree node. > > > > Let's use fwnode_dev_initialized() instead because it achieves the same > > effect without using OF specific flags. This allows more generic code to > > be written in driver core. > > ... > > > - of_node_set_flag(np, OF_POPULATED); > > + fwnode_dev_initialized(&np->fwnode, true); > > of_fwnode_handle(np) ? Or of_node_to_fwnode(). Looks like we have (at least) two of them... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72C53C38142 for ; Fri, 27 Jan 2023 09:32:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0Ew1kBYA1PPbamTh7PpwZiMfNBuxUc4jQ0VhGuAlHus=; b=r55fbfJ3L1qN6W XmpcPc8CZJb0+UuoCK++3/Z0UelQeB/wpvGMnhspuDa8HMD7GshGdtY3A+sv92SV3SdrjPg/27J/1 04Gy1d8AaDwgpKAvOq89JdIGFiU7GZwEhWjY81uX6g4rBVe7wkjRfP0AtQciul71DSJKe79nLKaxS utOc7LHZO8Y+Gm09WfLkFMyesvJY7BXa2IeaCspaiRfm03DjHR21odxx01hlcWt+r46wKAOL2aSst GlEVaw20ol4ktMDMFcO6zPoBBjkzhFqmZ55ybJrE3M+R0S1cGoTQXycmDvCDkEv8L8U1BGbnm0kPL mlxB79TKKzrUnWyjNq1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLL55-00DfwA-8Q; Fri, 27 Jan 2023 09:31:35 +0000 Received: from mail-qt1-f180.google.com ([209.85.160.180]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLL4W-00Dfi4-F5 for linux-arm-kernel@lists.infradead.org; Fri, 27 Jan 2023 09:31:02 +0000 Received: by mail-qt1-f180.google.com with SMTP id z9so3532124qtv.5 for ; Fri, 27 Jan 2023 01:30:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=y5Bg3XM00OVfj9CBB6CoZK0gXWkuIJjg1b6VOboGlP0=; b=ViI4OIYj73eSM194m2d1QvEZPUGkYMrdQV/nxNOHhB4L9taaDW0YPUzHTBSMsHnc5U pfjJEmynkn7WqMuhSKp13UY/o/7TG1oElxI8CncnaT61gpNuNjKncAvGODwLwYGNbZ0K s0DpxFaKtE1BFdIbBX7MMTv/DXNSKvkwK1p+rxUXYjUIz43q94vVdj0elII21ft2vLgq +aQsrNJ4mPEdh+RV/50eCTl2kBEBk6Wxb0f0dqTy3dwxf6TjzK4Lh989WIfM/SYTj8DI c6kytZ5zhdyx0J1JMKOnNrmSycObTAfTPe+h33lXCyW2/uwWzdJtKNFYOIHSvS4hugro oukg== X-Gm-Message-State: AFqh2kqAfJ34JVl68EvOGKIwbwTmkYHdLGEc9RlWzuoxicORlIAwgVZh L61eEzxNhB7E3dlXrNpLr+bj1ryZ8JmwRQ== X-Google-Smtp-Source: AMrXdXsa56n/hkaPCG+19JNsxli3uisz0pJF3pETgYePTIdiX4OVzrJD7v/FWIyRYc1/Rgdzpc/81g== X-Received: by 2002:a05:622a:50e:b0:3b6:9753:6429 with SMTP id l14-20020a05622a050e00b003b697536429mr53473583qtx.39.1674811858733; Fri, 27 Jan 2023 01:30:58 -0800 (PST) Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com. [209.85.128.182]) by smtp.gmail.com with ESMTPSA id z6-20020ac84306000000b003b646a99aa6sm2370641qtm.77.2023.01.27.01.30.58 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Jan 2023 01:30:58 -0800 (PST) Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-50112511ba7so59519787b3.3 for ; Fri, 27 Jan 2023 01:30:58 -0800 (PST) X-Received: by 2002:a25:dd8:0:b0:80a:6a1c:7c3b with SMTP id 207-20020a250dd8000000b0080a6a1c7c3bmr2129588ybn.89.1674811847373; Fri, 27 Jan 2023 01:30:47 -0800 (PST) MIME-Version: 1.0 References: <20230127001141.407071-1-saravanak@google.com> <20230127001141.407071-4-saravanak@google.com> In-Reply-To: From: Geert Uytterhoeven Date: Fri, 27 Jan 2023 10:30:35 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 03/11] soc: renesas: Move away from using OF_POPULATED for fw_devlink To: Andy Shevchenko Cc: Saravana Kannan , Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Len Brown , Daniel Scally , Heikki Krogerus , Sakari Ailus , Tony Lindgren , Linux Kernel Functional Testing , Naresh Kamboju , Abel Vesa , Alexander Stein , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Miquel Raynal , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230127_013100_538274_8D921FE1 X-CRM114-Status: GOOD ( 27.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andy, On Fri, Jan 27, 2023 at 10:25 AM Andy Shevchenko wrote: > On Thu, Jan 26, 2023 at 04:11:30PM -0800, Saravana Kannan wrote: > > The OF_POPULATED flag was set to let fw_devlink know that the device > > tree node will not have a struct device created for it. This information > > is used by fw_devlink to avoid deferring the probe of consumers of this > > device tree node. > > > > Let's use fwnode_dev_initialized() instead because it achieves the same > > effect without using OF specific flags. This allows more generic code to > > be written in driver core. > > ... > > > - of_node_set_flag(np, OF_POPULATED); > > + fwnode_dev_initialized(&np->fwnode, true); > > of_fwnode_handle(np) ? Or of_node_to_fwnode(). Looks like we have (at least) two of them... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel