From: Geert Uytterhoeven <geert@linux-m68k.org>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Ulrich Hecht <uli+renesas@fpond.eu>
Subject: Re: [PATCH 1/2] ARM: dts: gose: Fix ports node name for adv7180
Date: Mon, 13 Jul 2020 09:51:08 +0200 [thread overview]
Message-ID: <CAMuHMdUfDzDi1ELwsHeCe71Jm5zr9+rGT3o_R+cyPRqiyax3=g@mail.gmail.com> (raw)
In-Reply-To: <20200713072455.GJ1498036@oden.dyn.berto.se>
Hi Niklas,
On Mon, Jul 13, 2020 at 9:24 AM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> On 2020-07-07 11:59:12 +0200, Geert Uytterhoeven wrote:
> > On Sat, Jul 4, 2020 at 5:59 PM Niklas Söderlund
> > <niklas.soderlund+renesas@ragnatech.se> wrote:
> > > When adding the adv7180 device node the ports node was misspelled as
> > > port, fix this.
> > >
> > > Fixes: 8cae359049a88b75 ("ARM: dts: gose: add composite video input")
> > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> >
> > Thanks for your patch!
> >
> > > --- a/arch/arm/boot/dts/r8a7793-gose.dts
> > > +++ b/arch/arm/boot/dts/r8a7793-gose.dts
> > > @@ -336,7 +336,7 @@ composite-in@20 {
> > > reg = <0x20>;
> > > remote = <&vin1>;
> > >
> > > - port {
> > > + ports {
> > > #address-cells = <1>;
> > > #size-cells = <0>;
> > >
> >
> > Does this have any run-time impact, or dependencies?
>
> No run-time impact.
OK.
> > Don't we need the same fix for the other boards?
>
> The only other board we have that uses the same compatible string
> (adi,adv7180cp) is Draak and there the ports node is already correctly
> named.
Ah, I missed Gose is using "adi,adv7180cp", while Lager, Koelsch, Porter,
Alt, and Silk are using "adi,adv7180".
Next question: why the difference? Gose and Koelsch should be identical
w.r.t. these interfaces. In fact all boards listed above are using
ADV7180WBCP32Z, and seem to use similar wiring.
What's happening?
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2020-07-13 7:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-04 15:58 [PATCH 0/2] ARM: dts: renesas: Cleanup ADV7180 bindings Niklas Söderlund
2020-07-04 15:58 ` [PATCH 1/2] ARM: dts: gose: Fix ports node name for adv7180 Niklas Söderlund
2020-07-07 9:59 ` Geert Uytterhoeven
2020-07-13 7:24 ` Niklas Söderlund
2020-07-13 7:51 ` Geert Uytterhoeven [this message]
2020-07-13 8:15 ` Niklas Söderlund
2020-07-13 9:04 ` Ulrich Hecht
2020-07-04 15:58 ` [PATCH 2/2] ARM: dts: renesas: Remove unused remote property from adv7180 nodes Niklas Söderlund
2020-07-13 9:06 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdUfDzDi1ELwsHeCe71Jm5zr9+rGT3o_R+cyPRqiyax3=g@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=uli+renesas@fpond.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.