From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD0ECE92FF6 for ; Fri, 6 Oct 2023 07:08:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230239AbjJFHI7 convert rfc822-to-8bit (ORCPT ); Fri, 6 Oct 2023 03:08:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230216AbjJFHI6 (ORCPT ); Fri, 6 Oct 2023 03:08:58 -0400 Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD3D7EB; Fri, 6 Oct 2023 00:08:55 -0700 (PDT) Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-59f82ad1e09so21831857b3.0; Fri, 06 Oct 2023 00:08:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696576135; x=1697180935; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bDvOGTbwmYKB4yj3dggVQge2NMSHumJx3EfGcewWqNg=; b=P8PqJC3G4xGo2+ilG1ft2/Fvof8Lb9RvotJJWcCR3e3+cfi+17OQFjLia0vWd8OGqP veIej9+m/+D1C+r63oFOplgNuVO/zw0sXdBVAdenYsYb6m02Eg/OwGZCLQb+zPvTRk4O 2ysBmddfNkWTWe1Zfz6PJhkSGVlFKY1b45BF59lLwUy+0NDp7J/5xEOMCzIcO/83sRym QZo5wiPKaoZMnWJYYSqXSpYFzrsAzIKfoazD6nSEoJa4+5OBOaH93WUEFQAyOVpQf/HR s/OriPE924HzA3N8s33ZtMew23Fidj2N2Z3cR8H/9NlRs2mcmq5f4ujeLenGzX3iY9BY Vobw== X-Gm-Message-State: AOJu0YzmlpjW4rnsDfxKejp16M6y1Vz2gByJMyZbaTZp1lnYw8OFV2cM bz7BWBgztb6VviPOGNt8Af7y0hxoWkh4iQ== X-Google-Smtp-Source: AGHT+IEzHd2u+JyGUA1VxiF3B0cNwRjyZsMoyah2KMOfTfFEXGCZr9IfDNYyZvfkFLKQKb+xtrobBg== X-Received: by 2002:a81:9289:0:b0:5a2:4409:2124 with SMTP id j131-20020a819289000000b005a244092124mr7760070ywg.35.1696576134761; Fri, 06 Oct 2023 00:08:54 -0700 (PDT) Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com. [209.85.128.178]) by smtp.gmail.com with ESMTPSA id u195-20020a8184cc000000b0059f4f30a32bsm1086046ywf.24.2023.10.06.00.08.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Oct 2023 00:08:53 -0700 (PDT) Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-59f55c276c3so21557857b3.2; Fri, 06 Oct 2023 00:08:53 -0700 (PDT) X-Received: by 2002:a81:4a55:0:b0:599:8bd:5bdf with SMTP id x82-20020a814a55000000b0059908bd5bdfmr7486809ywa.50.1696576133283; Fri, 06 Oct 2023 00:08:53 -0700 (PDT) MIME-Version: 1.0 References: <20231005155618.700312-1-peter.griffin@linaro.org> <20231005155618.700312-20-peter.griffin@linaro.org> In-Reply-To: <20231005155618.700312-20-peter.griffin@linaro.org> From: Geert Uytterhoeven Date: Fri, 6 Oct 2023 09:08:41 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 19/21] google/gs101: Add dt overlay for oriole board To: Peter Griffin Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, conor+dt@kernel.org, sboyd@kernel.org, tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, wim@linux-watchdog.org, linux@roeck-us.net, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, cw00.choi@samsung.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, semen.protsenko@linaro.org, soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Peter, On Thu, Oct 5, 2023 at 5:58 PM Peter Griffin wrote: > The LK bootloader on Pixel6 searches for a dt overlay in the > dtbo partition with a board_id and board_rev that matches > what is baked into the device. If this overlay is not present > then the phone will bootloop in fastboot and you can't boot > the upstream kernel. > > This commit adds a dtbo for the production oriole variant. > The other pre-production board overlays are not included > at this time. > > Adding the dtbo here allows for a better experience when > building/booting the upstream kernel on Pixel devices > as all the DT required to boot the device will be created > as part of the kernel build process. Rather than having to > fetch the dtbo from some other repo. > > Signed-off-by: Peter Griffin Thanks for your patch! > --- /dev/null > +++ b/arch/arm64/boot/dts/google/gs101-oriole.dtso > @@ -0,0 +1,21 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Oriole DVT Device Tree > + * > + * Copyright 2021-2023 Google,LLC > + */ > + > +/dts-v1/; > +/plugin/; > + > +/ { > + board_id = <0x20304>; > + board_rev = <0x10000>; > + fragment@boardbase { > + target-path="/"; > + __overlay__ { > + model = "Oriole DVT"; > + compatible = "google,gs101-oriole"; > + }; > + }; Please use sugar-syntax instead of manually defining fragment/target-path/__overlay__ constructs. You can override these properties in the root node of the base DTS using the much simpler: &{/} { model = "Oriole DVT"; compatible = "google,gs101-oriole"; }; The generated DTBO should be identical (modulo naming). > +}; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56C6EE92FF3 for ; Fri, 6 Oct 2023 07:09:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=73rkSlnukQqMUGm5ujzrJnXLP3GSvRYInbKW27Huttw=; b=q4jVnFad6IGPGw tHe6zQRBrsKE55mB2F1czeKoWjFiHbYATIEI90ErYY6o6dk2WJ/y+Wsei1caoufIWa9wqbnnrw4Pl Z9SHUdInmFpLzj40eST4Zzv4Ekcs84P7IJSgYC9qNVBWa5cLIZwf/M9AbKBRCZVj3+SrdwUOQCW4r 0ohkuIxPfVvNdhj+om7B5dNFkqZkIxY5/CAnEwD2KoniEsIDVby3WSY86J/GvgcOr2Vz+q9gnTkjS MWVX9NinZpGIKs8d8/0st+FIhuQbjvtoCOVf2wlqhPFM0bSjnNfbFc6wzJ9riSz3dGpCyt5T7DvEi nJEUGhGFWJoQKdV40/5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qoexI-0057jA-2L; Fri, 06 Oct 2023 07:09:00 +0000 Received: from mail-yw1-f182.google.com ([209.85.128.182]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qoexF-0057iZ-1u for linux-arm-kernel@lists.infradead.org; Fri, 06 Oct 2023 07:08:59 +0000 Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-59f82ad1e09so21831847b3.0 for ; Fri, 06 Oct 2023 00:08:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696576135; x=1697180935; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bDvOGTbwmYKB4yj3dggVQge2NMSHumJx3EfGcewWqNg=; b=P842FpLh3O6QnvQfroF7xK8iy+IoYN3tKADLQMoQP7NR98F7za7TMygGNtDZsoAw+Q gDiYnKKWgc+wWSIRcaEnbMc+mbAH8ZKy4mWcrWB7fFwwEFjdA1HG7jTY1zWGatwX/L2e j2XK1/YBP6V+ncPwa4LjgHUF88EHzskTUpcFAx+yhVA678lmxFwf5fu985ZwkXuX86jT L16cQSBQWVZlVSTN0FOYl5QG++ahu6xBOF35USsVp/6iDF/k2jEttU/dTOiMAqIX16My FGH+0ljsKmTsVgoksNwmCmdrwL52gMDcsAsrSoGq7rQ3TPwC9PfjHEM1PFjmD+XIAODF eLmQ== X-Gm-Message-State: AOJu0Yz+Gbw8XSrAF0EsKeo5dPOSPUIBmKebX5czyrynU5mE7IrP0igz gMKpDMxo6jNMJlbHvsbL3LU/stGrOlCu0w== X-Google-Smtp-Source: AGHT+IHhX4Xz6ASxWUrsBFuaWOKSF65GyqP3uR7oIF1GBES2JkSoZkMILObR6Cf4JD8lWWrU9NRayg== X-Received: by 2002:a0d:e814:0:b0:59f:4cb1:594d with SMTP id r20-20020a0de814000000b0059f4cb1594dmr7729336ywe.3.1696576134682; Fri, 06 Oct 2023 00:08:54 -0700 (PDT) Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com. [209.85.128.175]) by smtp.gmail.com with ESMTPSA id e5-20020a816905000000b00585f60e970esm1097434ywc.134.2023.10.06.00.08.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Oct 2023 00:08:53 -0700 (PDT) Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-59f6041395dso21625027b3.1 for ; Fri, 06 Oct 2023 00:08:53 -0700 (PDT) X-Received: by 2002:a81:4a55:0:b0:599:8bd:5bdf with SMTP id x82-20020a814a55000000b0059908bd5bdfmr7486809ywa.50.1696576133283; Fri, 06 Oct 2023 00:08:53 -0700 (PDT) MIME-Version: 1.0 References: <20231005155618.700312-1-peter.griffin@linaro.org> <20231005155618.700312-20-peter.griffin@linaro.org> In-Reply-To: <20231005155618.700312-20-peter.griffin@linaro.org> From: Geert Uytterhoeven Date: Fri, 6 Oct 2023 09:08:41 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 19/21] google/gs101: Add dt overlay for oriole board To: Peter Griffin Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, conor+dt@kernel.org, sboyd@kernel.org, tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, wim@linux-watchdog.org, linux@roeck-us.net, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, cw00.choi@samsung.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, semen.protsenko@linaro.org, soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231006_000857_629600_F563ECF2 X-CRM114-Status: GOOD ( 28.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgUGV0ZXIsCgpPbiBUaHUsIE9jdCA1LCAyMDIzIGF0IDU6NTjigK9QTSBQZXRlciBHcmlmZmlu IDxwZXRlci5ncmlmZmluQGxpbmFyby5vcmc+IHdyb3RlOgo+IFRoZSBMSyBib290bG9hZGVyIG9u IFBpeGVsNiBzZWFyY2hlcyBmb3IgYSBkdCBvdmVybGF5IGluIHRoZQo+IGR0Ym8gcGFydGl0aW9u IHdpdGggYSBib2FyZF9pZCBhbmQgYm9hcmRfcmV2IHRoYXQgbWF0Y2hlcwo+IHdoYXQgaXMgYmFr ZWQgaW50byB0aGUgZGV2aWNlLiBJZiB0aGlzIG92ZXJsYXkgaXMgbm90IHByZXNlbnQKPiB0aGVu IHRoZSBwaG9uZSB3aWxsIGJvb3Rsb29wIGluIGZhc3Rib290IGFuZCB5b3UgY2FuJ3QgYm9vdAo+ IHRoZSB1cHN0cmVhbSBrZXJuZWwuCj4KPiBUaGlzIGNvbW1pdCBhZGRzIGEgZHRibyBmb3IgdGhl IHByb2R1Y3Rpb24gb3Jpb2xlIHZhcmlhbnQuCj4gVGhlIG90aGVyIHByZS1wcm9kdWN0aW9uIGJv YXJkIG92ZXJsYXlzIGFyZSBub3QgaW5jbHVkZWQKPiBhdCB0aGlzIHRpbWUuCj4KPiBBZGRpbmcg dGhlIGR0Ym8gaGVyZSBhbGxvd3MgZm9yIGEgYmV0dGVyIGV4cGVyaWVuY2Ugd2hlbgo+IGJ1aWxk aW5nL2Jvb3RpbmcgdGhlIHVwc3RyZWFtIGtlcm5lbCBvbiBQaXhlbCBkZXZpY2VzCj4gYXMgYWxs IHRoZSBEVCByZXF1aXJlZCB0byBib290IHRoZSBkZXZpY2Ugd2lsbCBiZSBjcmVhdGVkCj4gYXMg cGFydCBvZiB0aGUga2VybmVsIGJ1aWxkIHByb2Nlc3MuIFJhdGhlciB0aGFuIGhhdmluZyB0bwo+ IGZldGNoIHRoZSBkdGJvIGZyb20gc29tZSBvdGhlciByZXBvLgo+Cj4gU2lnbmVkLW9mZi1ieTog UGV0ZXIgR3JpZmZpbiA8cGV0ZXIuZ3JpZmZpbkBsaW5hcm8ub3JnPgoKVGhhbmtzIGZvciB5b3Vy IHBhdGNoIQoKPiAtLS0gL2Rldi9udWxsCj4gKysrIGIvYXJjaC9hcm02NC9ib290L2R0cy9nb29n bGUvZ3MxMDEtb3Jpb2xlLmR0c28KPiBAQCAtMCwwICsxLDIxIEBACj4gKy8vIFNQRFgtTGljZW5z ZS1JZGVudGlmaWVyOiBHUEwtMi4wLW9ubHkKPiArLyoKPiArICogT3Jpb2xlIERWVCBEZXZpY2Ug VHJlZQo+ICsgKgo+ICsgKiBDb3B5cmlnaHQgMjAyMS0yMDIzIEdvb2dsZSxMTEMKPiArICovCj4g Kwo+ICsvZHRzLXYxLzsKPiArL3BsdWdpbi87Cj4gKwo+ICsvIHsKPiArICAgICAgIGJvYXJkX2lk ID0gPDB4MjAzMDQ+Owo+ICsgICAgICAgYm9hcmRfcmV2ID0gPDB4MTAwMDA+Owo+ICsgICAgICAg ZnJhZ21lbnRAYm9hcmRiYXNlIHsKPiArICAgICAgICAgICAgICAgdGFyZ2V0LXBhdGg9Ii8iOwo+ ICsgICAgICAgICAgICAgICBfX292ZXJsYXlfXyB7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAg bW9kZWwgPSAiT3Jpb2xlIERWVCI7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgY29tcGF0aWJs ZSA9ICJnb29nbGUsZ3MxMDEtb3Jpb2xlIjsKPiArICAgICAgICAgICAgICAgfTsKPiArICAgICAg IH07CgpQbGVhc2UgdXNlIHN1Z2FyLXN5bnRheCBpbnN0ZWFkIG9mIG1hbnVhbGx5IGRlZmluaW5n CmZyYWdtZW50L3RhcmdldC1wYXRoL19fb3ZlcmxheV9fIGNvbnN0cnVjdHMuCllvdSBjYW4gb3Zl cnJpZGUgdGhlc2UgcHJvcGVydGllcyBpbiB0aGUgcm9vdCBub2RlIG9mIHRoZSBiYXNlIERUUwp1 c2luZyB0aGUgbXVjaCBzaW1wbGVyOgoKICAgICZ7L30gewogICAgICAgICAgICBtb2RlbCA9ICJP cmlvbGUgRFZUIjsKICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJnb29nbGUsZ3MxMDEtb3Jpb2xl IjsKICAgIH07CgpUaGUgZ2VuZXJhdGVkIERUQk8gc2hvdWxkIGJlIGlkZW50aWNhbCAobW9kdWxv IG5hbWluZykuCgo+ICt9OwoKR3J7b2V0amUsZWV0aW5nfXMsCgogICAgICAgICAgICAgICAgICAg ICAgICBHZWVydAoKLS0gCkdlZXJ0IFV5dHRlcmhvZXZlbiAtLSBUaGVyZSdzIGxvdHMgb2YgTGlu dXggYmV5b25kIGlhMzIgLS0gZ2VlcnRAbGludXgtbTY4ay5vcmcKCkluIHBlcnNvbmFsIGNvbnZl cnNhdGlvbnMgd2l0aCB0ZWNobmljYWwgcGVvcGxlLCBJIGNhbGwgbXlzZWxmIGEgaGFja2VyLiBC dXQKd2hlbiBJJ20gdGFsa2luZyB0byBqb3VybmFsaXN0cyBJIGp1c3Qgc2F5ICJwcm9ncmFtbWVy IiBvciBzb21ldGhpbmcgbGlrZSB0aGF0LgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IC0tIExpbnVzIFRvcnZhbGRzCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==