From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE2A1C433ED for ; Fri, 30 Apr 2021 07:49:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AFDAD6144B for ; Fri, 30 Apr 2021 07:49:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231497AbhD3Hub (ORCPT ); Fri, 30 Apr 2021 03:50:31 -0400 Received: from mail-vs1-f53.google.com ([209.85.217.53]:37541 "EHLO mail-vs1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230476AbhD3Hua (ORCPT ); Fri, 30 Apr 2021 03:50:30 -0400 Received: by mail-vs1-f53.google.com with SMTP id 2so35114100vsh.4; Fri, 30 Apr 2021 00:49:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3MtcEBgU5dyOOgckSftFjH0gpeoB/1IYhWDTLXUVAzg=; b=RsWObpHcRWajLZaLJTdObKuh0hxQk+q5YKcCQq8hrv6Jvlf8QLQsdFBwVvE//h1oMU vZ/Il77MqRY3KMQUXFBliAprdMr9PXnxKbDl/JC+XJa5HPL1dN5l40GaqgBMGzO5QjNz I5b9wpmkIJYhf+8SkGl2ZGga0jZosxiH4ivJdFU9Gd17GJ4Xgr+B51dFYF8fS/ZfYgzp jhHyZrI+jU76JtQmuQDXX4IStttB6FPBDtTAzIo3lz9ftZgSuxLahX75R0qoAKjIOp6a CzNePLfOe0TG6wTy7ZixKQH1PZU5qLeHqzphbmtRzbhDYheLWf1PSeEUZAGFPtTEvQB5 Lhog== X-Gm-Message-State: AOAM531zJl3S0T7vbZ0rREgJFoFSElmCvCa9tT49hSZH8ihHgoMKIacV uplEYlR0VO6Vb4ID0YaD4vBuKRSK8ZjF6Wl16IQ= X-Google-Smtp-Source: ABdhPJzB0OFCU7TrJ91DtINuAVZDq5FyGyzedvAgeMbCLbnzKyrGO68lofjcEU3xn1vVl34srnKyAGN1/r3BnLtsCzE= X-Received: by 2002:a67:f503:: with SMTP id u3mr4568822vsn.3.1619768981686; Fri, 30 Apr 2021 00:49:41 -0700 (PDT) MIME-Version: 1.0 References: <20210419130106.6707-1-o.rempel@pengutronix.de> <20210419130106.6707-4-o.rempel@pengutronix.de> <20210430072609.GA6711@pengutronix.de> In-Reply-To: <20210430072609.GA6711@pengutronix.de> From: Geert Uytterhoeven Date: Fri, 30 Apr 2021 09:49:30 +0200 Message-ID: Subject: Re: [PATCH net-next v3 3/6] net: add generic selftest support To: Oleksij Rempel Cc: Shawn Guo , Sascha Hauer , Andrew Lunn , Florian Fainelli , Heiner Kallweit , Fugang Duan , Sascha Hauer , netdev , Linux ARM , Linux Kernel Mailing List , NXP Linux Team , Fabio Estevam , David Jander , Russell King , Philippe Schenker Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Oleksij, On Fri, Apr 30, 2021 at 9:26 AM Oleksij Rempel wrote: > On Fri, Apr 30, 2021 at 08:45:05AM +0200, Geert Uytterhoeven wrote: > > On Mon, Apr 19, 2021 at 3:13 PM Oleksij Rempel wrote: > > > Port some parts of the stmmac selftest and reuse it as basic generic selftest > > > library. This patch was tested with following combinations: > > > - iMX6DL FEC -> AT8035 > > > - iMX6DL FEC -> SJA1105Q switch -> KSZ8081 > > > - iMX6DL FEC -> SJA1105Q switch -> KSZ9031 > > > - AR9331 ag71xx -> AR9331 PHY > > > - AR9331 ag71xx -> AR9331 switch -> AR9331 PHY > > > > > > Signed-off-by: Oleksij Rempel > > > > Thanks for your patch, which is now commit 3e1e58d64c3d0a67 ("net: add > > generic selftest support") upstream. > > > > > --- a/net/Kconfig > > > +++ b/net/Kconfig > > > @@ -429,6 +429,10 @@ config GRO_CELLS > > > config SOCK_VALIDATE_XMIT > > > bool > > > > > > +config NET_SELFTESTS > > > + def_tristate PHYLIB > > > > Why does this default to enabled if PHYLIB=y? > > Usually we allow the user to make selftests modular, independent of the > > feature under test, but I may misunderstand the purpose of this test. > > > > Thanks for your clarification! > > There is nothing against making optional. Should I do it? Yes please. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22362C433ED for ; Fri, 30 Apr 2021 07:51:39 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8FE96610A0 for ; Fri, 30 Apr 2021 07:51:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8FE96610A0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3nJpDbz3VVVNwsIEEAUDLpet1aBdaVaSCBbWruhe+XI=; b=RePa0wF5VYcgyZC2YjmBvPIZK 8cS5T7iENHYGXSvTsSW9HV0NxhulSoETBFLkNTWzfdcYqkBmnK3PY9RvsofGIkiNEZr3hbPo1Lbvh mKwiW3kmT9zA8pQlwhij5Cxdp1xILJ6sS0Eo3H/7l0NIFwYtSEYHRgSuRnghi3GUUuFbaEYw5KHn0 5jNr3K1LxPns5KAAD5grmf2tAsuiYeKHCVSnJr+BZsu8U18QMEmbd6limJwrcg5o5nYfwRi/BUTWf wAUZx6eHiFAeSghnAgNkoZ5816GeSWSTCCjitam4FotijX67VobaSZZZzomajfrnROkixiCD4C9Kr g/HKbX67A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lcNuH-007SAC-1F; Fri, 30 Apr 2021 07:49:49 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lcNuD-007S9o-TC for linux-arm-kernel@desiato.infradead.org; Fri, 30 Apr 2021 07:49:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3MtcEBgU5dyOOgckSftFjH0gpeoB/1IYhWDTLXUVAzg=; b=vQqI+ayu9cN6/CVtL8jL2ZnUl4 Xr225XyJtiqeCH4Q/Eq/KGwXeb1pMUCspv0Fq1CHSdbak6TvaO+MUPfNpl8ju47xcfbAh99rfga1R lzQ9zyW8w7DROQU4D4aJZHoSxMt3jZqNPyT+AfYVZNgU6DBJM3J91920tRC5MJa+wTTk+xlMNSRwB D3EdyjRinroNZJ3o/LTtAD9xMfXNEfoX19Nd9cYpgceU/Oo6Ql8e03F6+eL+bDWjWltoXHU6qULqe FeTIdcOWg5gnRp0ymPPIzdIr7U061CLgPoXJMPp7TckyMRSKGVhe46rBmRBbK9PXbQcDcTMiCnnWt JFjJ4O4A==; Received: from mail-vs1-f44.google.com ([209.85.217.44]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lcNuB-001DN6-6V for linux-arm-kernel@lists.infradead.org; Fri, 30 Apr 2021 07:49:44 +0000 Received: by mail-vs1-f44.google.com with SMTP id u22so24130757vsu.6 for ; Fri, 30 Apr 2021 00:49:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3MtcEBgU5dyOOgckSftFjH0gpeoB/1IYhWDTLXUVAzg=; b=KqGVjBwGd5saiH7Q6OpjA60lIsP38ZKO5FiB0DOEzHd5OtaxdLvCclBp7BQ3UYE/IK XjEU+VeP2PkXzPgM1KSNuPeNHrEVqsQwM+zX5TRydZcdSqe6HlXzWIVx+iQqXVAZhS8x S8Kn8fxNEpJUajgrVFQ5DAg4BKPjGTfXFjLcjpNsLkIIMJUGqs1YJeS/gyqOPgAnBYt0 OspQ1Vd0FRfVdQ1MorH6mVTtEyxjWAeeWUe/oVwccdMfYNqLfhvTyGm36S+tKSnz99g8 o8UEjaRBcj9rbTW+0muesjFKLhlHU1mimu6kEiY2oKyJSjFSzPwibqM6PAZez20dToaR AZpw== X-Gm-Message-State: AOAM530Jmpf2SrUOVHjRUQ7WL6AuP3SdtXWRPmaFcKu/Xc6joUZRaRr3 y16bA3GSzXOfgu4YG6RgCvw8YsD8yQ3H4pmRIIs= X-Google-Smtp-Source: ABdhPJzB0OFCU7TrJ91DtINuAVZDq5FyGyzedvAgeMbCLbnzKyrGO68lofjcEU3xn1vVl34srnKyAGN1/r3BnLtsCzE= X-Received: by 2002:a67:f503:: with SMTP id u3mr4568822vsn.3.1619768981686; Fri, 30 Apr 2021 00:49:41 -0700 (PDT) MIME-Version: 1.0 References: <20210419130106.6707-1-o.rempel@pengutronix.de> <20210419130106.6707-4-o.rempel@pengutronix.de> <20210430072609.GA6711@pengutronix.de> In-Reply-To: <20210430072609.GA6711@pengutronix.de> From: Geert Uytterhoeven Date: Fri, 30 Apr 2021 09:49:30 +0200 Message-ID: Subject: Re: [PATCH net-next v3 3/6] net: add generic selftest support To: Oleksij Rempel Cc: Shawn Guo , Sascha Hauer , Andrew Lunn , Florian Fainelli , Heiner Kallweit , Fugang Duan , Sascha Hauer , netdev , Linux ARM , Linux Kernel Mailing List , NXP Linux Team , Fabio Estevam , David Jander , Russell King , Philippe Schenker X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210430_004943_258104_0F531B1B X-CRM114-Status: GOOD ( 26.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Oleksij, On Fri, Apr 30, 2021 at 9:26 AM Oleksij Rempel wrote: > On Fri, Apr 30, 2021 at 08:45:05AM +0200, Geert Uytterhoeven wrote: > > On Mon, Apr 19, 2021 at 3:13 PM Oleksij Rempel wrote: > > > Port some parts of the stmmac selftest and reuse it as basic generic selftest > > > library. This patch was tested with following combinations: > > > - iMX6DL FEC -> AT8035 > > > - iMX6DL FEC -> SJA1105Q switch -> KSZ8081 > > > - iMX6DL FEC -> SJA1105Q switch -> KSZ9031 > > > - AR9331 ag71xx -> AR9331 PHY > > > - AR9331 ag71xx -> AR9331 switch -> AR9331 PHY > > > > > > Signed-off-by: Oleksij Rempel > > > > Thanks for your patch, which is now commit 3e1e58d64c3d0a67 ("net: add > > generic selftest support") upstream. > > > > > --- a/net/Kconfig > > > +++ b/net/Kconfig > > > @@ -429,6 +429,10 @@ config GRO_CELLS > > > config SOCK_VALIDATE_XMIT > > > bool > > > > > > +config NET_SELFTESTS > > > + def_tristate PHYLIB > > > > Why does this default to enabled if PHYLIB=y? > > Usually we allow the user to make selftests modular, independent of the > > feature under test, but I may misunderstand the purpose of this test. > > > > Thanks for your clarification! > > There is nothing against making optional. Should I do it? Yes please. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel