From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f193.google.com ([209.85.223.193]:33550 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750917AbdAQORC (ORCPT ); Tue, 17 Jan 2017 09:17:02 -0500 Received: by mail-io0-f193.google.com with SMTP id 101so15863868iom.0 for ; Tue, 17 Jan 2017 06:16:08 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <1484657360-13101-1-git-send-email-geert+renesas@glider.be> <1484657360-13101-4-git-send-email-geert+renesas@glider.be> From: Geert Uytterhoeven Date: Tue, 17 Jan 2017 15:08:21 +0100 Message-ID: Subject: Re: [PATCH 3/4] arm64: dts: r8a7795: Link ARM GIC to clock and clock domain To: Ramesh Shanmugasundaram Cc: Geert Uytterhoeven , Simon Horman , Magnus Damm , "linux-renesas-soc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Ramesh, On Tue, Jan 17, 2017 at 3:00 PM, Ramesh Shanmugasundaram wrote: >> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi >> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi >> @@ -166,6 +166,9 @@ >> <0x0 0xf1060000 0 0x20000>; >> interrupts = > (GIC_CPU_MASK_SIMPLE(4) | >> IRQ_TYPE_LEVEL_HIGH)>; >> + clocks = <&cpg CPG_MOD 408>; >> + clock-names = "clk"; > > Should the module clock be named "fck"? Not according to Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt. P.S. If you use "git blame", you may think I'm cheating, but naming was ased on the actual Technical Reference Manuals ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 From: geert@linux-m68k.org (Geert Uytterhoeven) Date: Tue, 17 Jan 2017 15:08:21 +0100 Subject: [PATCH 3/4] arm64: dts: r8a7795: Link ARM GIC to clock and clock domain In-Reply-To: References: <1484657360-13101-1-git-send-email-geert+renesas@glider.be> <1484657360-13101-4-git-send-email-geert+renesas@glider.be> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Ramesh, On Tue, Jan 17, 2017 at 3:00 PM, Ramesh Shanmugasundaram wrote: >> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi >> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi >> @@ -166,6 +166,9 @@ >> <0x0 0xf1060000 0 0x20000>; >> interrupts = > (GIC_CPU_MASK_SIMPLE(4) | >> IRQ_TYPE_LEVEL_HIGH)>; >> + clocks = <&cpg CPG_MOD 408>; >> + clock-names = "clk"; > > Should the module clock be named "fck"? Not according to Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt. P.S. If you use "git blame", you may think I'm cheating, but naming was ased on the actual Technical Reference Manuals ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds