From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CACE0ECAAD3 for ; Sun, 11 Sep 2022 17:54:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229608AbiIKRyg (ORCPT ); Sun, 11 Sep 2022 13:54:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229549AbiIKRyd (ORCPT ); Sun, 11 Sep 2022 13:54:33 -0400 Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F043B4B; Sun, 11 Sep 2022 10:54:31 -0700 (PDT) Received: by mail-qk1-f179.google.com with SMTP id d15so4637726qka.9; Sun, 11 Sep 2022 10:54:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=B4bddbQD1NbE7kocxVXmEn8/Skat8LorcHj/QVJVqFM=; b=1IuQqP4skRTNi4CrqTKPyg6uLxf6FNJ3ZO9JDNEt28VRSfkSA5+ivGUT1kvg2e11iI XhpqwVNsOxhLmiI//v/i2uCo0d1kBjdBXTpIMlcQ2d0tgdh4akSsWgLUWdPFVxUEnMvr roIFwFFIwTKCrdkkBDaftw5K3azIqx0OsfgrY9guMzDywyJMsWzYqE89Z4qYUo7Hflkq 139sA5RRT6W+4qG2C/GAUvwM8q3gkkrLf7/CtNoi83nvm1VsWWO3vQfnzv7J2b2O9ODC Fs7o+cMKlvbJ44s2B18X3ei2MWFsCrXwp7t8Aij/9ThdmkhbIEaZemngSS3o7gPcqtDN 6YtA== X-Gm-Message-State: ACgBeo1urJrt24HkPl88M0jE+SrE67MbcAChF/bJH8Lq6ZTGJXSsCHjP 1jPogAznLFeOrL7w3dbNeMcYknZLl4rHvQpu X-Google-Smtp-Source: AA6agR6JODAm8vBbJi1aZlAuJClEHNM7UjEvPFcFcVeUHA4WZXPkd18EJTfNZ46nzMZeN76erh4J7A== X-Received: by 2002:a05:620a:410b:b0:6ce:1edb:35f6 with SMTP id j11-20020a05620a410b00b006ce1edb35f6mr2009214qko.313.1662918870221; Sun, 11 Sep 2022 10:54:30 -0700 (PDT) Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com. [209.85.128.173]) by smtp.gmail.com with ESMTPSA id fu27-20020a05622a5d9b00b003434d3b5938sm5084745qtb.2.2022.09.11.10.54.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 11 Sep 2022 10:54:29 -0700 (PDT) Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-3452214cec6so76058657b3.1; Sun, 11 Sep 2022 10:54:29 -0700 (PDT) X-Received: by 2002:a81:c52:0:b0:344:f9ca:89c4 with SMTP id 79-20020a810c52000000b00344f9ca89c4mr19411353ywm.384.1662918869384; Sun, 11 Sep 2022 10:54:29 -0700 (PDT) MIME-Version: 1.0 References: <20220906190426.3139760-1-matthew.gerlach@linux.intel.com> <20220906190426.3139760-3-matthew.gerlach@linux.intel.com> In-Reply-To: From: Geert Uytterhoeven Date: Sun, 11 Sep 2022 19:54:17 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 2/5] fpga: dfl: Move the DFH definitions To: matthew.gerlach@linux.intel.com Cc: Greg KH , Wu Hao , Xu Yilun , russell.h.weight@intel.com, basheer.ahmed.muddebihal@intel.com, Tom Rix , Moritz Fischer , linux-fpga@vger.kernel.org, "open list:DOCUMENTATION" , Linux Kernel Mailing List , tianfei.zhang@intel.com, Jonathan Corbet , "open list:SERIAL DRIVERS" , Jiri Slaby , Geert Uytterhoeven , Andy Shevchenko , =?UTF-8?Q?Niklas_S=C3=B6derlund?= , Phil Edworthy , "Maciej W. Rozycki" , Johan Hovold , Lukas Wunner , Basheer Ahmed Muddebihal Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Matthew, On Sun, Sep 11, 2022 at 5:40 PM wrote: > On Wed, 7 Sep 2022, Greg KH wrote: > > On Tue, Sep 06, 2022 at 12:04:23PM -0700, matthew.gerlach@linux.intel.com wrote: > >> --- a/drivers/fpga/dfl.h > >> +++ b/drivers/fpga/dfl.h > >> @@ -2,7 +2,7 @@ > >> /* > >> * Driver Header File for FPGA Device Feature List (DFL) Support > >> * > >> - * Copyright (C) 2017-2018 Intel Corporation, Inc. > >> + * Copyright (C) 2017-2022 Intel Corporation, Inc. > > > > I'm all for updated proper copyright dates, but in a patch that > > _removes_ text from a file does not seem like the proper place for that, > > right? Please discuss with your corporate lawyers as to how to do this > > properly and when to do it. > I discussed how and when to do this properly with my corporate lawyers and > confirmed this submission is consistent with their guidelines. > > You do raise an interesting point, though. If you think this approach is > improper, we should probably discuss it, including whether this > restriction is already a condition for contributions or whether it should > be. It wouldn't be the first difference of opinion on the finer points of > copyright law. So each time code is removed from a file, its copyright year should be updated? Eventually, we may end up with an empty file which is copyrighted ? Do you think that makes sense? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds